linux.git/tools/testing/selftests/mm, branch v6.5

selftests/mm: FOLL_LONGTERM need to be updated to 0x100

2023-08-21T20:07:21+00:00

After commit 2c2241081f7d ("mm/gup: move private gup FOLL_ flags to
internal.h") FOLL_LONGTERM flag value got updated from 0x10000 to 0x100 at
include/linux/mm_types.h.

As hmm.hmm_device_private.hmm_gup_test uses FOLL_LONGTERM Updating same
here as well.

Before this change test goes in an infinite assert loop in
hmm.hmm_device_private.hmm_gup_test
==========================================================
 RUN           hmm.hmm_device_private.hmm_gup_test ...
hmm-tests.c:1962:hmm_gup_test:Expected HMM_DMIRROR_PROT_WRITE..
..(2) == m[2] (34)
hmm-tests.c:157:hmm_gup_test:Expected ret (-1) == 0 (0)
hmm-tests.c:157:hmm_gup_test:Expected ret (-1) == 0 (0)
...
==========================================================

 Call Trace:
 
 ? sched_clock+0xd/0x20
 ? __lock_acquire.constprop.0+0x120/0x6c0
 ? ktime_get+0x2c/0xd0
 ? sched_clock+0xd/0x20
 ? local_clock+0x12/0xd0
 ? lock_release+0x26e/0x3b0
 pin_user_pages_fast+0x4c/0x70
 gup_test_ioctl+0x4ff/0xbb0
 ? gup_test_ioctl+0x68c/0xbb0
 __x64_sys_ioctl+0x99/0xd0
 do_syscall_64+0x60/0x90
 ? syscall_exit_to_user_mode+0x2a/0x50
 ? do_syscall_64+0x6d/0x90
 ? syscall_exit_to_user_mode+0x2a/0x50
 ? do_syscall_64+0x6d/0x90
 ? irqentry_exit_to_user_mode+0xd/0x20
 ? irqentry_exit+0x3f/0x50
 ? exc_page_fault+0x96/0x200
 entry_SYSCALL_64_after_hwframe+0x72/0xdc
 RIP: 0033:0x7f6aaa31aaff

After this change test is able to pass successfully.

Link: https://lkml.kernel.org/r/20230808124347.79163-1-ayush.jain3@amd.com
Fixes: 2c2241081f7d ("mm/gup: move private gup FOLL_ flags to internal.h")
Signed-off-by: Ayush Jain 
Reviewed-by: Raghavendra K T 
Reviewed-by: John Hubbard 
Acked-by: David Hildenbrand 
Cc: Jason Gunthorpe 
Cc: 
Signed-off-by: Andrew Morton

selftests: mm: ksm: fix incorrect evaluation of parameter

2023-08-04T20:03:41+00:00

A missing break in kms_tests leads to kselftest hang when the parameter -s
is used.

In current code flow because of missing break in -s, -t parses args
spilled from -s and as -t accepts only valid values as 0,1 so any arg in
-s >1 or <0, gets in ksm_test failure

This went undetected since, before the addition of option -t, the next
case -M would immediately break out of the switch statement but that is no
longer the case

Add the missing break statement.

----Before----
./ksm_tests -H -s 100
Invalid merge type

----After----
./ksm_tests -H -s 100
Number of normal pages:    0
Number of huge pages:    50
Total size:    100 MiB
Total time:    0.401732682 s
Average speed:  248.922 MiB/s

Link: https://lkml.kernel.org/r/20230728163952.4634-1-ayush.jain3@amd.com
Fixes: 07115fcc15b4 ("selftests/mm: add new selftests for KSM")
Signed-off-by: Ayush Jain 
Reviewed-by: David Hildenbrand 
Cc: Stefan Roesch 
Cc: 
Signed-off-by: Andrew Morton

selftests/mm: mkdirty: fix incorrect position of #endif

2023-07-17T19:53:22+00:00

The #endif is the wrong side of a } causing a build failure when
__NR_userfaultfd is not defined.  Fix this by moving the #end to enclose
the }

Link: https://lkml.kernel.org/r/20230712134648.456349-1-colin.i.king@gmail.com
Fixes: 9eac40fc0cc7 ("selftests/mm: mkdirty: test behavior of (pte|pmd)_mkdirty on VMAs without write permissions")
Signed-off-by: Colin Ian King 
Reviewed-by: David Hildenbrand 
Cc: Shuah Khan 
Cc: 
Signed-off-by: Andrew Morton

selftests/mm: give scripts execute permission

2023-07-14T16:24:31+00:00

When run under run_vmtests.sh, test scripts were failing to run with
"permission denied" due to the scripts not being executable.

It is also annoying not to be able to directly invoke run_vmtests.sh,
which is solved by giving also it the execute permission.

Link: https://lkml.kernel.org/r/20230713135440.3651409-3-ryan.roberts@arm.com
Signed-off-by: Ryan Roberts 
Cc: SeongJae Park 
Cc: David Hildenbrand 
Cc: Florent Revest 
Cc: Jérôme Glisse 
Cc: John Hubbard 
Cc: Liam R. Howlett 
Cc: Mark Brown 
Cc: Shuah Khan 
Signed-off-by: Andrew Morton

Merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes.

2023-06-23T23:58:19+00:00

selftests: mm: remove duplicate unneeded defines

2023-06-19T23:19:25+00:00

Remove all defines which aren't needed after correctly including the
kernel header files.

Link: https://lkml.kernel.org/r/20230612095347.996335-2-usama.anjum@collabora.com
Signed-off-by: Muhammad Usama Anjum 
Cc: David Hildenbrand 
Cc: Shuah Khan 
Cc: Stefan Roesch 
Signed-off-by: Andrew Morton

selftests: mm: remove wrong kernel header inclusion

2023-06-19T23:19:25+00:00

It is wrong to include unprocessed user header files directly.  They are
processed to "/usr/include" by running "make headers" and
they are included in selftests by kselftest makefiles automatically with
help of KHDR_INCLUDES variable.  These headers should always bulilt first
before building kselftests.

Link: https://lkml.kernel.org/r/20230612095347.996335-1-usama.anjum@collabora.com
Fixes: 07115fcc15b4 ("selftests/mm: add new selftests for KSM")
Signed-off-by: Muhammad Usama Anjum 
Acked-by: David Hildenbrand 
Cc: Shuah Khan 
Cc: Stefan Roesch 
Signed-off-by: Andrew Morton

selftests/mm: move certain uffd*() routines from vm_util.c to uffd-common.c

2023-06-19T23:19:02+00:00

There are only three uffd*() routines that are used outside of the uffd
selftests. Leave these in vm_util.c, where they are available to any mm
selftest program:

    uffd_register()
    uffd_unregister()
    uffd_register_with_ioctls().

A few other uffd*() routines, however, are only used by the uffd-focused
tests found in uffd-stress.c and uffd-unit-tests.c. Move those routines
into uffd-common.c.

Link: https://lkml.kernel.org/r/20230606071637.267103-10-jhubbard@nvidia.com
Signed-off-by: John Hubbard 
Acked-by: David Hildenbrand 
Tested-by: Muhammad Usama Anjum 
Cc: Peter Xu 
Cc: Jonathan Corbet 
Cc: Nathan Chancellor 
Cc: Shuah Khan 
Signed-off-by: Andrew Morton

selftests/mm: fix build failures due to missing MADV_COLLAPSE

2023-06-19T23:19:02+00:00

MADV_PAGEOUT, MADV_POPULATE_READ, MADV_COLLAPSE are conditionally
defined as necessary. However, that was being done in .c files, and a
new build failure came up that would have been automatically avoided had
these been in a common header file.

So consolidate and move them all to vm_util.h, which fixes the build
failure.

An alternative approach from Muhammad Usama Anjum was: rely on "make
headers" being required, and include asm-generic/mman-common.h. This
works in the sense that it builds, but it still generates warnings about
duplicate MADV_* symbols, and the goal here is to get a fully clean (no
warnings) build here.

Link: https://lkml.kernel.org/r/20230606071637.267103-9-jhubbard@nvidia.com
Signed-off-by: John Hubbard 
Reviewed-by: David Hildenbrand 
Tested-by: Muhammad Usama Anjum 
Cc: Peter Xu 
Cc: Jonathan Corbet 
Cc: Nathan Chancellor 
Cc: Shuah Khan 
Signed-off-by: Andrew Morton

selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h

2023-06-19T23:19:02+00:00

This fixes a real bug, too, because xstate_size()  was assuming that
the stack variable xstate_size was initialized to zero. That's not
guaranteed nor even especially likely.

Link: https://lkml.kernel.org/r/20230606071637.267103-8-jhubbard@nvidia.com
Signed-off-by: John Hubbard 
Reviewed-by: David Hildenbrand 
Tested-by: Muhammad Usama Anjum 
Cc: Peter Xu 
Cc: Jonathan Corbet 
Cc: Nathan Chancellor 
Cc: Shuah Khan 
Signed-off-by: Andrew Morton