linux.git/tools/testing/selftests/kvm/lib, branch v5.2-rc2

KVM: selftests: Wrap vcpu_nested_state_get/set functions with x86 guard

2019-05-24T19:27:17+00:00

struct kvm_nested_state is only available on x86 so far. To be able
to compile the code on other architectures as well, we need to wrap
the related code with #ifdefs.

Signed-off-by: Thomas Huth 
Signed-off-by: Paolo Bonzini

kvm: selftests: aarch64: compile with warnings on

2019-05-24T19:27:16+00:00

aarch64 fixups needed to compile with warnings as errors.

Reviewed-by: Thomas Huth 
Signed-off-by: Andrew Jones 
Signed-off-by: Paolo Bonzini

kvm: selftests: aarch64: fix default vm mode

2019-05-24T19:27:16+00:00

VM_MODE_P52V48_4K is not a valid mode for AArch64. Replace its
use in vm_create_default() with a mode that works and represents
a good AArch64 default. (We didn't ever see a problem with this
because we don't have any unit tests using vm_create_default(),
but it's good to get it fixed in advance.)

Reported-by: Thomas Huth 
Signed-off-by: Andrew Jones 
Signed-off-by: Paolo Bonzini

KVM: selftests: Compile code with warnings enabled

2019-05-24T19:27:05+00:00

So far the KVM selftests are compiled without any compiler warnings
enabled. That's quite bad, since we miss a lot of possible bugs this
way. Let's enable at least "-Wall" and some other useful warning flags
now, and fix at least the trivial problems in the code (like unused
variables).

Signed-off-by: Thomas Huth 
Signed-off-by: Paolo Bonzini

kvm: selftests: avoid type punning

2019-05-24T19:27:05+00:00

Avoid warnings from -Wstrict-aliasing by using memcpy.

Reviewed-by: Thomas Huth 
Signed-off-by: Paolo Bonzini

tests: kvm: Add tests for KVM_SET_NESTED_STATE

2019-05-08T12:12:09+00:00

Add tests for KVM_SET_NESTED_STATE and for various code paths in its implementation in vmx_set_nested_state().

Signed-off-by: Aaron Lewis 
Reviewed-by: Marc Orr 
Reviewed-by: Peter Shier 
Signed-off-by: Paolo Bonzini

selftests: kvm: add a selftest for SMM

2019-04-16T13:38:06+00:00

Add a simple test for SMM, based on VMX.  The test implements its own
sync between the guest and the host as using our ucall library seems to
be too cumbersome: SMI handler is happening in real-address mode.

This patch also fixes KVM_SET_NESTED_STATE to happen after
KVM_SET_VCPU_EVENTS, in fact it places it last.  This is because
KVM needs to know whether the processor is in SMM or not.

Signed-off-by: Vitaly Kuznetsov 
Signed-off-by: Paolo Bonzini

selftests: kvm/evmcs_test: complete I/O before migrating guest state

2019-04-16T13:37:39+00:00

Starting state migration after an IO exit without first completing IO
may result in test failures.  We already have two tests that need this
(this patch in fact fixes evmcs_test, similar to what was fixed for
state_test in commit 0f73bbc851ed, "KVM: selftests: complete IO before
migrating guest state", 2019-03-13) and a third is coming.  So, move the
code to vcpu_save_state, and while at it do not access register state
until after I/O is complete.

Signed-off-by: Paolo Bonzini

KVM: selftests: complete IO before migrating guest state

2019-03-28T16:29:09+00:00

Documentation/virtual/kvm/api.txt states:

  NOTE: For KVM_EXIT_IO, KVM_EXIT_MMIO, KVM_EXIT_OSI, KVM_EXIT_PAPR and
        KVM_EXIT_EPR the corresponding operations are complete (and guest
        state is consistent) only after userspace has re-entered the
        kernel with KVM_RUN.  The kernel side will first finish incomplete
        operations and then check for pending signals.  Userspace can
        re-enter the guest with an unmasked signal pending to complete
        pending operations.

Because guest state may be inconsistent, starting state migration after
an IO exit without first completing IO may result in test failures, e.g.
a proposed change to KVM's handling of %rip in its fast PIO handling[1]
will cause the new VM, i.e. the post-migration VM, to have its %rip set
to the IN instruction that triggered KVM_EXIT_IO, leading to a test
assertion due to a stage mismatch.

For simplicitly, require KVM_CAP_IMMEDIATE_EXIT to complete IO and skip
the test if it's not available.  The addition of KVM_CAP_IMMEDIATE_EXIT
predates the state selftest by more than a year.

[1] https://patchwork.kernel.org/patch/10848545/

Fixes: fa3899add1056 ("kvm: selftests: add basic test for state save and restore")
Reported-by: Jim Mattson 
Signed-off-by: Sean Christopherson 
Signed-off-by: Paolo Bonzini

kvm: selftests: Fix region overlap check in kvm_util

2019-01-25T18:11:36+00:00

Fix a call to userspace_mem_region_find to conform to its spec of
taking an inclusive, inclusive range. It was previously being called
with an inclusive, exclusive range. Also remove a redundant region bounds
check in vm_userspace_mem_region_add. Region overlap checking is already
performed by the call to userspace_mem_region_find.

Tested: Compiled tools/testing/selftests/kvm with -static
	Ran all resulting test binaries on an Intel Haswell test machine
	All tests passed

Signed-off-by: Ben Gardon 
Reviewed-by: Jim Mattson 
Signed-off-by: Paolo Bonzini