linux.git/tools/testing/selftests/bpf/test_maps.c, branch v6.0

selftests/bpf: Remove usage of deprecated feature probing APIs

2022-02-03T15:32:25+00:00

Switch to libbpf_probe_*() APIs instead of the deprecated ones.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann 
Reviewed-by: Quentin Monnet 
Link: https://lore.kernel.org/bpf/20220202225916.3313522-5-andrii@kernel.org

selftests/bpf: Remove explicit setrlimit(RLIMIT_MEMLOCK) in main selftests

2021-12-14T21:16:54+00:00

As libbpf now is able to automatically take care of RLIMIT_MEMLOCK
increase (or skip it altogether on recent enough kernels), remove
explicit setrlimit() invocations in bench, test_maps, test_verifier, and
test_progs.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann 
Link: https://lore.kernel.org/bpf/20211214195904.1785155-3-andrii@kernel.org

selftests/bpf: Migrate selftests to bpf_map_create()

2021-11-25T22:37:38+00:00

Conversion is straightforward for most cases. In few cases tests are
using mutable map_flags and attribute structs, but bpf_map_create_opts
can be used in the similar fashion, so there were no problems. Just lots
of repetitive conversions.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann 
Link: https://lore.kernel.org/bpf/20211124193233.3115996-5-andrii@kernel.org

selftests/bpf: Use explicit bpf_prog_test_load() calls everywhere

2021-11-07T16:34:23+00:00

-Dbpf_prog_load_deprecated=bpf_prog_test_load trick is both ugly and
breaks when deprecation goes into effect due to macro magic. Convert all
the uses to explicit bpf_prog_test_load() calls which avoid deprecation
errors and makes everything less magical.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Acked-by: Dave Marchevsky 
Link: https://lore.kernel.org/bpf/20211103220845.2676888-12-andrii@kernel.org

selftests/bpf: Enlarge select() timeout for test_maps

2021-08-24T21:01:10+00:00

0Day robot observed that it's easily timeout on a heavy load host.
-------------------
 # selftests: bpf: test_maps
 # Fork 1024 tasks to 'test_update_delete'
 # Fork 1024 tasks to 'test_update_delete'
 # Fork 100 tasks to 'test_hashmap'
 # Fork 100 tasks to 'test_hashmap_percpu'
 # Fork 100 tasks to 'test_hashmap_sizes'
 # Fork 100 tasks to 'test_hashmap_walk'
 # Fork 100 tasks to 'test_arraymap'
 # Fork 100 tasks to 'test_arraymap_percpu'
 # Failed sockmap unexpected timeout
 not ok 3 selftests: bpf: test_maps # exit=1
 # selftests: bpf: test_lru_map
 # nr_cpus:8
-------------------
Since this test will be scheduled by 0Day to a random host that could have
only a few cpus(2-8), enlarge the timeout to avoid a false NG report.

In practice, i tried to pin it to only one cpu by 'taskset 0x01 ./test_maps',
and knew 10S is likely enough, but i still perfer to a larger value 30.

Reported-by: kernel test robot 
Signed-off-by: Li Zhijian 
Signed-off-by: Alexei Starovoitov 
Acked-by: Song Liu 
Link: https://lore.kernel.org/bpf/20210820015556.23276-2-lizhijian@cn.fujitsu.com

selftests/bpf: Add exponential backoff to map_delete_retriable in test_maps

2021-08-17T15:17:40+00:00

Using a fixed delay of 1 microsecond has proven flaky in slow CPU environment,
e.g. Github Actions CI system. This patch adds exponential backoff with a cap
of 50ms to reduce the flakiness of the test. Initial delay is chosen at random
in the range [0ms, 5ms).

Signed-off-by: Yucong Sun 
Signed-off-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20210817045713.3307985-1-fallentree@fb.com

selftests/bpf: Add exponential backoff to map_update_retriable in test_maps

2021-08-17T02:13:20+00:00

Using a fixed delay of 1 microsecond has proven flaky in slow CPU environment,
e.g. Github Actions CI system. This patch adds exponential backoff with a cap
of 50ms to reduce the flakiness of the test. Initial delay is chosen at random
in the range [0ms, 5ms).

Signed-off-by: Yucong Sun 
Signed-off-by: Andrii Nakryiko 
Acked-by: Song Liu 
Link: https://lore.kernel.org/bpf/20210816175250.296110-1-fallentree@fb.com

selftests/bpf: Mute expected invalid map creation error msg

2021-07-22T23:44:10+00:00

Previously, the newly introduced test case in test_map_in_map(), which
checks whether the inner map is destroyed after unsuccessful creation of
the outer map, logged the following harmless and expected error:

    libbpf: map 'mim': failed to create: Invalid argument(-22) libbpf:
    failed to load object './test_map_in_map_invalid.o'

To avoid any possible confusion, mute the logging during loading of the
prog.

Fixes: 08f71a1e39a1 ("selftests/bpf: Check inner map deletion")
Reported-by: Andrii Nakryiko 
Signed-off-by: Martynas Pumputis 
Signed-off-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20210721140941.563175-1-m@lambda.lt

bpf, selftests: Fix test_maps now that sockmap supports UDP

2021-07-20T20:18:51+00:00

UDP socket support was added recently so testing UDP insert failure is no
longer correct and causes test_maps failure. The fix is easy though, we
simply need to test that UDP is correctly added instead of blocked.

Fixes: 122e6c79efe1c ("sock_map: Update sock type checks for UDP")
Reported-by: Andrii Nakryiko 
Signed-off-by: John Fastabend 
Signed-off-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20210720184832.452430-1-john.fastabend@gmail.com

selftests/bpf: Check inner map deletion

2021-07-19T22:58:07+00:00

Add a test case to check whether an unsuccessful creation of an outer
map of a BTF-defined map-in-map destroys the inner map.

As bpf_object__create_map() is a static function, we cannot just call it
from the test case and then check whether a map accessible via
map->inner_map_fd has been closed. Instead, we iterate over all maps and
check whether the map "$MAP_NAME.inner" does not exist.

Signed-off-by: Martynas Pumputis 
Signed-off-by: Andrii Nakryiko 
Acked-by: John Fastabend 
Link: https://lore.kernel.org/bpf/20210719173838.423148-3-m@lambda.lt