linux.git/tools/power/cpupower, branch v3.17

cpupower: Remove redundant error check

2014-07-29T23:57:13+00:00

Remove double checks, and move the call to print_error to the
first check. Replace break by return, and return 0 on success.
The simplified version of the coccinelle semantic patch that
fixes this issue is as follows:

// 
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
-	if (E) break;
+	if (E){
+		pr(es);
+		break;
+	}
...
}
- if(E) pr(es);
// 

Signed-off-by: Peter Senna Tschudin 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: bench: parse.c: Fix several minor errors

2014-07-29T23:57:13+00:00

Resolved several minor errors in prepare_config() and made some additional improvements.
Earlier, the risk of file stream that was not closed. Misuse of strncpy, and the use of strncmp with strlen that makes it pointless.
I also check that sscanf has been successful, otherwise continue to the next line. And minimized the use of magic numbers.

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: mperf monitor: Correct use of ! and &

2014-07-29T23:57:12+00:00

In commit ae91d60ba88ef0bdb1b5e9b2363bd52fc45d2af7, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

The Coccinelle semantic patch that makes this change is as follows:

// 
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// 

Signed-off-by: Himangi Saraogi 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

PM / tools: cpupower: drop negativity check on unsigned value

2014-07-19T19:41:17+00:00

Link: https://bugzilla.kernel.org/show_bug.cgi?id=80621
Reported-by: David Binderman 
Signed-off-by: Andrey Utkin 
Signed-off-by: Rafael J. Wysocki

Merge branches 'acpi-tools' and 'pm-tools'

2014-06-03T21:13:34+00:00

* acpi-tools:
  ACPI / tools: Introduce ec_access.c - tool to access the EC

* pm-tools:
  cpupower: Remove mc and smt power aware scheduler info/settings
  cpupower: cpupower info -b should return 0 on success, not the perf bias value
  cpupower: If root, try to load msr driver on x86 if /dev/cpu/0/msr is not available
  cpupower: Install recently added cpupower-idle-{set, info} manpages
  cpupower: Introduce idle state disable-by-latency and enable-all
  cpupower: Remove all manpages on make uninstall
  cpupower: Remove dead link to homepage, and update the targets built.
  cpupower: Rename cpufrequtils -> cpupower, and libcpufreq -> libcpupower.
  PM / tools: cpupower: add option to display values without round offs
  tools / power: turbostat: Drop temperature checks

cpupower: Remove mc and smt power aware scheduler info/settings

2014-05-16T22:36:37+00:00

These kernel interfaces got removed by:

commit 8e7fbcbc22c12414bcc9dfdd683637f58fb32759
Author: Peter Zijlstra 
Date:   Mon Jan 9 11:28:35 2012 +0100

    sched: Remove stale power aware scheduling remnants and dysfunctional knobs

No need to further keep them as userspace configurations.

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: cpupower info -b should return 0 on success, not the perf bias value

2014-05-16T22:36:37+00:00

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: If root, try to load msr driver on x86 if /dev/cpu/0/msr is not available

2014-05-16T22:36:36+00:00

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: Install recently added cpupower-idle-{set, info} manpages

2014-05-16T22:36:36+00:00

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: Introduce idle state disable-by-latency and enable-all

2014-05-16T22:36:36+00:00

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki