linux.git/tools/power/cpupower, branch v3.10

treewide: Fix typos in kernel messages

2013-03-31T15:50:31+00:00

Correct spelling typos in various part of printk.

Signed-off-by: Masanari Iida 
Acked-by: Randy Dunlap 
Signed-off-by: Jiri Kosina

cpupower: IvyBridge (0x3a and 0x3e models) support

2012-11-27T22:07:20+00:00

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower: Provide -c param for cpupower monitor to schedule process on all cores

2012-11-27T22:07:20+00:00

If an MSR based monitor is run in parallel this is not needed. This is the
default case on all/most Intel machines.

But when only sysfs info is read via cpupower monitor -m Idle_Stats (typically
the case for non root users) or when other monitors are PCI based (AMD),
Idle_Stats, read from sysfs can be totally bogus:

cpupower monitor -m Idle_Stats
PKG |CORE|CPU | POLL | C1-N | C3-N | C6-N
   0|   0|   0|  0.00|  0.00|  0.24| 99.81
   0|   0|  32|  0.00|  0.00|  0.00| 100.7
...
   0|  17|  20|  0.00|  0.00|  0.00| 173.1
   0|  17|  52|  0.00|  0.00|  0.07| 173.0
   0|  18|  68|  0.00|  0.00|  0.00|  0.00
   0|  18|  76|  0.00|  0.00|  0.00|  0.00
...

With the -c option all cores are woken up and the kernel
did update cpuidle statistics before reading out sysfs.
This causes some overhead. Therefore avoid if possible, use
if needed:

cpupower monitor -c -m Idle_Stats
PKG |CORE|CPU | POLL | C1-N | C3-N | C6-N
   0|   0|   0|  0.00|  0.00|  0.00| 100.2
   0|   0|  32|  0.00|  0.00|  0.00| 100.2
...
   0|   8|   8|  0.00|  0.00|  0.00| 99.82
   0|   8|  40|  0.00|  0.00|  0.00| 99.81
   0|   9|  24|  0.00|  0.00|  0.00| 100.3
   0|   9|  56|  0.00|  0.00|  0.00| 100.2
   0|  16|   4|  0.00|  0.00|  0.00| 99.75
   0|  16|  36|  0.00|  0.00|  0.00| 99.38
...

Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower tools: Fix warning and a bug with the cpu package count

2012-11-27T22:07:19+00:00

The pkgs member of cpupower_topology is being used as the number of
cpu packages. As the comment in get_cpu_topology notes, the package ids
are not guaranteed to be contiguous. So, simply setting pkgs to the value
of the highest physical_package_id doesn't actually provide a count of
the number of cpu packages. Instead, calculate pkgs by setting it to
the number of distinct physical_packge_id values which is pretty easy
to do after the core_info structs are sorted. Calculating pkgs this
way also has the nice benefit of getting rid of a sign comparison warning
that GCC 4.6 was reporting.

Signed-off-by: Palmer Cox 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower tools: Fix malloc of cpu_info structure

2012-11-27T22:07:19+00:00

The cpu_info member of cpupower_topology was being declared as an unnamed
structure. This member was then being malloced using the size of the
parent cpupower_topology * the number of cpus. This works
because cpu_info is smaller than cpupower_topology. However, there is
no guarantee that will always be the case. Making cpu_info its own
top level structure (named cpuid_core_info) allows for mallocing the actual
size of this structure. This also lets us get rid of a redefinition of
the structure in topology.c with slightly different field names.

Signed-off-by: Palmer Cox 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower tools: Fix issues with sysfs_topology_read_file

2012-11-27T22:07:19+00:00

Fix a variety of issues with sysfs_topology_read_file:
* The return value of sysfs_topology_read_file function was not properly
  being checked for failure.
* The function was reading int valued sysfs variables and then returning
  their value. So, even if a function was trying to check the return value
  of this function, a caller would not be able to tell an failure code apart
  from reading a negative value. This also conflicted with the comment on the
  function which said that a return value of 0 indicated success.
* The function was parsing int valued sysfs values with strtoul instead of
  strtol.
* The function was non-static even though it was only used in the
  file it was declared in.

Signed-off-by: Palmer Cox 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower tools: Fix minor warnings

2012-11-27T22:07:18+00:00

Fix minor warnings reported with GCC 4.6:
* The sysfs_write_file function is unused - remove it.
* The pr_mon_len in the print_header function is unsed - remove it.

Signed-off-by: Palmer Cox 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower tools: Update .gitignore for files created in the debug directories

2012-11-27T22:07:18+00:00

The files generated by the Makefiles in the debug directories aren't listed
in the .gitignore file in the root of the cpupower tool which causes these
files to show up in the output of 'git status'.

Signed-off-by: Palmer Cox 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

cpupower tools: Remove brace expansion from clean target

2012-11-27T22:07:18+00:00

The clean targets from the cpupower tools' Makefiles use brace expansion to
remove some generated files. However, the default shells on many systems do
not support this feature resulting in some generated files not being removed
by clean.

Signed-off-by: Palmer Cox 
Signed-off-by: Thomas Renninger 
Signed-off-by: Rafael J. Wysocki

kbuild: Fix gcc -x syntax

2012-10-03T07:03:24+00:00

The correct syntax for gcc -x is "gcc -x assembler", not
"gcc -xassembler". Even though the latter happens to work, the former
is what is documented in the manual page and thus what gcc wrappers
such as icecream do expect.

This isn't a cosmetic change. The missing space prevents icecream from
recognizing compilation tasks it can't handle, leading to silent kernel
miscompilations.

Besides me, credits go to Michael Matz and Dirk Mueller for
investigating the miscompilation issue and tracking it down to this
incorrect -x parameter syntax.

Signed-off-by: Jean Delvare 
Acked-by: Ingo Molnar 
Cc: stable@vger.kernel.org
Cc: Bernhard Walle 
Cc: Michal Marek 
Cc: Ralf Baechle 
Signed-off-by: Michal Marek