linux.git/tools/perf/util/stat-shadow.c, branch for-next

perf stat: Expand metric+unit buffer size

2024-11-07T19:49:50+00:00

Long metric names combined with units may exceed the metric_bf and
lead to truncation. Double metric_bf in size to avoid this.

Signed-off-by: Ian Rogers 
Acked-by: Kan Liang 
Link: https://lore.kernel.org/r/20241106004818.2174593-1-irogers@google.com
Signed-off-by: Namhyung Kim

perf stat: Change color to threshold in print_metric

2024-10-17T19:44:26+00:00

Colors don't mean things in CSV and JSON output, switch to a threshold
enum value that the standard output can convert to a color. Updating
the CSV and JSON output will be later changes.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Yicong Yang 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: James Clark 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Sumanth Korikkar 
Cc: Thomas Richter 
Cc: Tim Chen 
Cc: John Garry 
Link: https://lore.kernel.org/r/20241017175356.783793-6-irogers@google.com
Signed-off-by: Namhyung Kim

perf stat: Fix/add parameter names for print_metric

2024-10-17T19:44:26+00:00

The print_metric parameter names were rearranged, fix and add comments
in the stat-shadow callers to ensure they are correct.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Yicong Yang 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: James Clark 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Sumanth Korikkar 
Cc: Thomas Richter 
Cc: Tim Chen 
Cc: John Garry 
Link: https://lore.kernel.org/r/20241017175356.783793-3-irogers@google.com
Signed-off-by: Namhyung Kim

perf tool_pmu: Move expr literals to tool_pmu

2024-10-11T06:40:32+00:00

Add the expr literals like "#smt_on" as tool events, this allows stat
events to give the values. On my laptop with hyperthreading enabled:

```
$ perf stat -e "has_pmem,num_cores,num_cpus,num_cpus_online,num_dies,num_packages,smt_on,system_tsc_freq" true

 Performance counter stats for 'true':

                 0      has_pmem
                 8      num_cores
                16      num_cpus
                16      num_cpus_online
                 1      num_dies
                 1      num_packages
                 1      smt_on
     2,496,000,000      system_tsc_freq

       0.001113637 seconds time elapsed

       0.001218000 seconds user
       0.000000000 seconds sys
```

And with hyperthreading disabled:
```
$ perf stat -e "has_pmem,num_cores,num_cpus,num_cpus_online,num_dies,num_packages,smt_on,system_tsc_freq" true

 Performance counter stats for 'true':

                 0      has_pmem
                 8      num_cores
                16      num_cpus
                 8      num_cpus_online
                 1      num_dies
                 1      num_packages
                 0      smt_on
     2,496,000,000      system_tsc_freq

       0.000802115 seconds time elapsed

       0.000000000 seconds user
       0.000806000 seconds sys
```

As zero matters for these values, in stat-display
should_skip_zero_counter only skip the zero value if it is not the
first aggregation index.

The tool event implementations are used in expr but not evaluated as
events for simplicity. Also core_wide isn't made a tool event as it
requires command line parameters.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-8-irogers@google.com
Signed-off-by: Namhyung Kim

perf tool_pmu: Rename enum perf_tool_event to tool_pmu_event

2024-10-11T06:40:32+00:00

To better reflect the events listed are from the tool PMU. Rename the
enum values from PERF_TOOL_* to TOOL_PMU__EVENT_*.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-6-irogers@google.com
Signed-off-by: Namhyung Kim

perf tool_pmu: Factor tool events into their own PMU

2024-10-11T06:40:32+00:00

Rather than treat tool events as a special kind of event, create a
tool only PMU where the events/aliases match the existing
duration_time, user_time and system_time events. Remove special
parsing and printing support for the tool events, but add function
calls for when PMU functions are called on a tool_pmu.

Move the tool PMU code in evsel into tool_pmu.c to better encapsulate
the tool event behavior in that file.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-5-irogers@google.com
Signed-off-by: Namhyung Kim

perf evsel: Remove pmu_name

2024-09-26T20:26:11+00:00

"evsel->pmu_name" is only ever assigned a strdup of "pmu->name", a
strdup of "evsel->pmu_name" or NULL. As such, prefer to use
"pmu->name" directly and even to directly compare PMUs than PMU
names. For safety, add some additional NULL tests.

Acked-by: Namhyung Kim 
Signed-off-by: Ian Rogers 
[ Fix arm-spe.c usage of pmu_name and empty PMU name ]
Acked-by: Kan Liang 
Signed-off-by: James Clark 
Cc: Yang Jihong 
Cc: Dominique Martinet 
Cc: Howard Chu 
Cc: Ze Gao 
Cc: Yicong Yang 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Jing Zhang 
Cc: Yang Li 
Cc: Leo Yan 
Cc: ak@linux.intel.com
Cc: Athira Rajeev 
Cc: linux-arm-kernel@lists.infradead.org
Cc: Sun Haiyong 
Cc: John Garry 
Link: https://lore.kernel.org/r/20240926144851.245903-6-james.clark@linaro.org
Signed-off-by: Namhyung Kim

perf stat: Remove evlist__add_default_attrs use strings

2024-09-26T20:26:11+00:00

add_default_atttributes would add evsels by having pre-created
perf_event_attr, however, this needed fixing for hybrid as the
extended PMU type was necessary for each core PMU. The logic for this
was in an arch specific x86 function and wasn't present for ARM,
meaning that default events weren't being opened on all PMUs on
ARM. Change the creation of the default events to use parse_events and
strings as that will open the events on all PMUs.

Rather than try to detect events on PMUs before parsing, parse the
event but skip its output in stat-display.

The previous order of hardware events was: cycles,
stalled-cycles-frontend, stalled-cycles-backend, instructions. As
instructions is a more fundamental concept the order is changed to:
instructions, cycles, stalled-cycles-frontend, stalled-cycles-backend.

Closes: https://lore.kernel.org/lkml/CAP-5=fVABSBZnsmtRn1uF-k-G1GWM-L5SgiinhPTfHbQsKXb_g@mail.gmail.com/
Acked-by: Namhyung Kim 
Signed-off-by: Ian Rogers 
[Don't display unsupported default events except 'cycles']
Acked-by: Kan Liang 
Signed-off-by: James Clark 
Cc: Yang Jihong 
Cc: Dominique Martinet 
Cc: Colin Ian King 
Cc: Howard Chu 
Cc: Ze Gao 
Cc: Yicong Yang 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Jing Zhang 
Cc: Yang Li 
Cc: Leo Yan 
Cc: ak@linux.intel.com
Cc: Athira Rajeev 
Cc: linux-arm-kernel@lists.infradead.org
Cc: Sun Haiyong 
Cc: John Garry 
Link: https://lore.kernel.org/r/20240926144851.245903-4-james.clark@linaro.org
Signed-off-by: Namhyung Kim

perf evsel: Add accessor for tool_event

2024-09-11T14:28:27+00:00

Currently tool events use a dedicated variable within the evsel. Later
changes will move this to the unused struct perf_event_attr config for
these events. Add an accessor to allow the later change to be well
typed and avoid changing all uses.

Signed-off-by: Ian Rogers 
Link: https://lore.kernel.org/r/20240907050830.6752-4-irogers@google.com
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Mark Rutland 
Cc: Yang Jihong 
Cc: Dominique Martinet 
Cc: Clément Le Goffic 
Cc: Colin Ian King 
Cc: Howard Chu 
Cc: Ze Gao 
Cc: Yicong Yang 
Cc: Changbin Du 
Cc: Junhao He 
Cc: Peter Zijlstra 
Cc: Adrian Hunter 
Cc: Weilin Wang 
Cc: Arnaldo Carvalho de Melo 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Will Deacon 
Cc: James Clark 
Cc: Mike Leach 
Cc: Jing Zhang 
Cc: Leo Yan 
Cc: Oliver Upton 
Cc: Benjamin Gray 
Cc: Andi Kleen 
Cc: Alexander Shishkin 
Cc: Kan Liang 
Cc: Athira Jajeev 
Cc: linux-arm-kernel@lists.infradead.org
Cc: Sun Haiyong 
Cc: Tiezhu Yang 
Cc: Xu Yang 
Cc: John Garry 
Cc: Ingo Molnar 
Cc: Veronika Molnarova 
Cc: Dr. David Alan Gilbert 
Cc: linux-kernel@vger.kernel.org
Cc: linux-perf-users@vger.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf stat: Fix the hard-coded metrics calculation on the hybrid

2024-06-21T16:43:09+00:00

The hard-coded metrics is wrongly calculated on the hybrid machine.

$ perf stat -e cycles,instructions -a sleep 1

 Performance counter stats for 'system wide':

        18,205,487      cpu_atom/cycles/
         9,733,603      cpu_core/cycles/
         9,423,111      cpu_atom/instructions/     #  0.52  insn per cycle
         4,268,965      cpu_core/instructions/     #  0.23  insn per cycle

The insn per cycle for cpu_core should be 4,268,965 / 9,733,603 = 0.44.

When finding the metric events, the find_stat() doesn't take the PMU
type into account. The cpu_atom/cycles/ is wrongly used to calculate
the IPC of the cpu_core.

In the hard-coded metrics, the events from a different PMU are only
SW_CPU_CLOCK and SW_TASK_CLOCK. They both have the stat type,
STAT_NSECS. Except the SW CLOCK events, check the PMU type as well.

Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
Reported-by: Khalil, Amiri 
Reviewed-by: Ian Rogers 
Signed-off-by: Kan Liang 
Acked-by: Namhyung Kim 
Cc: stable@vger.kernel.org
Signed-off-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20240606180316.4122904-1-kan.liang@linux.intel.com