linux.git/tools/perf/util/session.c, branch v2.6.38

perf tools: Fix 64 bit integer format strings

2011-01-23T01:41:57+00:00

Using %L[uxd] has issues in some architectures, like on ppc64.  Fix it
by making our 64 bit integers typedefs of stdint.h types and using
PRI[ux]64 like, for instance, git does.

Reported by Denis Kirjanov that provided a patch for one case, I went
and changed all cases.

Reported-by: Denis Kirjanov 
Tested-by: Denis Kirjanov 
LKML-Reference: <20110120093246.GA8031@hera.kernel.org>
Cc: Denis Kirjanov 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Pingtian Han 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Fix infinite loop in __perf_session__process_events

2011-01-11T00:23:08+00:00

In this if statement:

        if (head + event->header.size >= mmap_size) {
                if (mmaps[map_idx]) {
                        munmap(mmaps[map_idx], mmap_size);
                        mmaps[map_idx] = NULL;
                }

                page_offset = page_size * (head / page_size);
                file_offset += page_offset;
                head -= page_offset;
                goto remap;
        }

With, for instance, these values:

head=2992
event->header.size=48
mmap_size=3040

We end up endlessly looping back to remap. Off by one.

Problem introduced in 55b4462.

Reported-by: Linus Torvalds 
Reported-by: Ingo Molnar 
Reported-by: David Ahern 
Bisected-by: David Ahern 
Tested-by: David Ahern 
Cc: David Ahern 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Thomas Gleixner 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Warn about errors when processing pipe events too

2011-01-05T16:53:10+00:00

Just like we do at __perf_session__process_events

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf util: Move do_read from session to util

2011-01-03T18:50:55+00:00

Not really something to be exported from session.c. Rename it to
'readn' as others did in the past.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Fallback to unordered processing if no sample_id_all

2010-12-21T22:17:51+00:00

If we are running the new perf on an old kernel without support for
sample_id_all, we should fall back to the old unordered processing of
events. If we didn't than we would *always* process events without
timestamps out of order, whether or not we hit a reordering race. In
other words, instead of there being a chance of not attributing samples
correctly, we would guarantee that samples would not be attributed.

While processing all events without timestamps before events with
timestamps may seem like an intuitive solution, it falls down as
PERF_RECORD_EXIT events would also be processed before any samples.
Even with a workaround for that case, samples before/after an exec would
not be attributed correctly.

This patch allows commands to indicate whether they need to fall back to
unordered processing, so that commands that do not care about timestamps
on every event will not be affected. If we do fallback, this will print
out a warning if report -D was invoked.

This patch adds the test in perf_session__new so that we only need to
test once per session. Commands that do not use an event_ops (such as
record and top) can simply pass NULL in it's place.

Acked-by: Thomas Gleixner 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
LKML-Reference: <1291951882-sup-6069@au1.ibm.com>
Signed-off-by: Ian Munsie 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Remove unneeded dump_printf calls

2010-12-09T14:20:20+00:00

Since we check at the beginning of the callers, no need to ask if
dump_trace is set multiple times.

Cc: Frederic Weisbecker 
Cc: Ian Munsie 
Cc: Ingo Molnar 
Cc: Thomas Gleixner 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Split out user event processing

2010-12-09T14:15:43+00:00

Simplify further.

Cc: Frederic Weisbecker 
Cc: Ian Munsie 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
LKML-Reference: <20101207124551.110956235@linutronix.de>
Signed-off-by: Thomas Gleixner 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Split out sample preprocessing

2010-12-09T14:13:13+00:00

Simplify the code a bit.

Cc: Frederic Weisbecker 
Cc: Ian Munsie 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
LKML-Reference: <20101207124551.014649793@linutronix.de>
Signed-off-by: Thomas Gleixner 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Move dump code to event delivery path

2010-12-09T14:10:53+00:00

Preparatory patch for ordered perf report -D

Acked-by: Ian Munsie 
Cc: Frederic Weisbecker 
Cc: Ian Munsie 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
LKML-Reference: <20101207124550.918655066@linutronix.de>
Signed-off-by: Thomas Gleixner 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Add file_offset to event delivery function

2010-12-09T14:09:51+00:00

Preparatory patch for ordered output of perf report -D

Acked-by: Ian Munsie 
Cc: Frederic Weisbecker 
Cc: Ian Munsie 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
LKML-Reference: <20101207124550.818568607@linutronix.de>
Signed-off-by: Thomas Gleixner 
Signed-off-by: Arnaldo Carvalho de Melo