linux.git/tools/perf/util/parse-events.y, branch for-next

perf tool_pmu: Factor tool events into their own PMU

2024-10-11T06:40:32+00:00

Rather than treat tool events as a special kind of event, create a
tool only PMU where the events/aliases match the existing
duration_time, user_time and system_time events. Remove special
parsing and printing support for the tool events, but add function
calls for when PMU functions are called on a tool_pmu.

Move the tool PMU code in evsel into tool_pmu.c to better encapsulate
the tool event behavior in that file.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-5-irogers@google.com
Signed-off-by: Namhyung Kim

perf evsel: Add alternate_hw_config and use in evsel__match

2024-09-26T20:26:11+00:00

There are cases where we want to match events like instructions and
cycles with legacy hardware values, in particular in stat-shadow's
hard coded metrics. An evsel's name isn't a good point of reference as
it gets altered, strstr would be too imprecise and re-parsing the
event from its name is silly. Instead, hold the legacy hardware event
name, determined during parsing, in the evsel for this matching case.

Inline evsel__match2 that is only used in builtin-diff.

Acked-by: Namhyung Kim 
Signed-off-by: Ian Rogers 
Acked-by: Kan Liang 
Signed-off-by: James Clark 
Cc: Yang Jihong 
Cc: Dominique Martinet 
Cc: Colin Ian King 
Cc: Howard Chu 
Cc: Yunseong Kim 
Cc: Ze Gao 
Cc: Yicong Yang 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Jing Zhang 
Cc: Yang Li 
Cc: Leo Yan 
Cc: ak@linux.intel.com
Cc: Athira Rajeev 
Cc: linux-arm-kernel@lists.infradead.org
Cc: Sun Haiyong 
Cc: John Garry 
Link: https://lore.kernel.org/r/20240926144851.245903-2-james.clark@linaro.org
Signed-off-by: Namhyung Kim

Revert "perf parse-events: Prefer sysfs/JSON hardware events over legacy"

2024-05-26T11:41:34+00:00

This reverts commit 617824a7f0f73e4de325cf8add58e55b28c12493.

This made a simple 'perf record -e cycles:pp make -j199' stop working on
the Ampere ARM64 system Linus uses to test ARM64 kernels, as discussed
at length in the threads in the Link tags below.

The fix provided by Ian wasn't acceptable and work to fix this will take
time we don't have at this point, so lets revert this and work on it on
the next devel cycle.

Reported-by: Linus Torvalds 
Cc: Adrian Hunter 
Cc: Bhaskar Chowdhury 
Cc: Ethan Adams 
Cc: Ian Rogers 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Namhyung Kim 
Cc: Thomas Gleixner 
Cc: Thomas Richter 
Cc: Tycho Andersen 
Cc: Yang Jihong 
Link: https://lore.kernel.org/lkml/CAHk-=wi5Ri=yR2jBVk-4HzTzpoAWOgstr1LEvg_-OXtJvXXJOA@mail.gmail.com
Link: https://lore.kernel.org/lkml/CAHk-=wiWvtFyedDNpoV7a8Fq_FpbB+F5KmWK2xPY3QoYseOf_A@mail.gmail.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: pass parse_state to add_tracepoint

2024-05-10T13:49:09+00:00

The next patch will add another flag to parse_state that we will want to
pass to evsel__newtp_idx(), so pass the whole parse_state all the way
down instead of giving only the index

Originally-by: Jiri Olsa 
Reviewed-by: Ian Rogers 
Signed-off-by: Dominique Martinet 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240510-perf_digit-v4-1-db1553f3233b@codewreck.org
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Tidy the setting of the default event name

2024-04-27T01:07:21+00:00

Add comments. Pass ownership of the event name to save on a strdup.

Signed-off-by: Ian Rogers 
Reviewed-by: Kan Liang 
Tested-by: Atish Patra 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Beeman Strong 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240416061533.921723-17-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Minor grouping tidy up

2024-04-27T01:07:20+00:00

Add comments. Ensure leader->group_name is freed before overwriting
it.

Signed-off-by: Ian Rogers 
Reviewed-by: Kan Liang 
Tested-by: Atish Patra 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Beeman Strong 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240416061533.921723-16-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Improvements to modifier parsing

2024-04-27T01:07:20+00:00

Use a struct/bitmap rather than a copied string from lexer.

In lexer give improved error message when too many precise flags are
given or repeated modifiers.

Before:

  $ perf stat -e 'cycles:kuk' true
  event syntax error: 'cycles:kuk'
                              \___ Bad modifier
  ...
  $ perf stat -e 'cycles:pppp' true
  event syntax error: 'cycles:pppp'
                              \___ Bad modifier
  ...
  $ perf stat -e '{instructions:p,cycles:pp}:pp' -a true
  event syntax error: '..cycles:pp}:pp'
                                    \___ Bad modifier
  ...

After:

  $ perf stat -e 'cycles:kuk' true
  event syntax error: 'cycles:kuk'
                                \___ Duplicate modifier 'k' (kernel)
  ...
  $ perf stat -e 'cycles:pppp' true
  event syntax error: 'cycles:pppp'
                                 \___ Maximum precise value is 3
  ...
  $ perf stat -e '{instructions:p,cycles:pp}:pp' true
  event syntax error: '..cycles:pp}:pp'
                                    \___ Maximum combined precise value is 3, adding precision to "cycles:pp"
  ...

Signed-off-by: Ian Rogers 
Reviewed-by: Kan Liang 
Tested-by: Atish Patra 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Beeman Strong 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240416061533.921723-14-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Inline parse_events_evlist_error

2024-04-27T01:07:20+00:00

Inline parse_events_evlist_error that is only used in
parse_events_error. Modify parse_events_error to not report a parser
error unless errors haven't already been reported. Make it clearer
that the latter case only happens for unrecognized input.

Before:

  $ perf stat -e 'cycles/period=99999999999999999999/' true
  event syntax error: 'cycles/period=99999999999999999999/'
                                    \___ parser error

  event syntax error: '..les/period=99999999999999999999/'
                                    \___ Bad base 10 number "99999999999999999999"
  Run 'perf list' for a list of valid events

   Usage: perf stat [] []

      -e, --event    event selector. use 'perf list' to list available events
  $ perf stat -e 'cycles:xyz' true
  event syntax error: 'cycles:xyz'
                             \___ parser error
  Run 'perf list' for a list of valid events

   Usage: perf stat [] []

      -e, --event    event selector. use 'perf list' to list available events

After:

  $ perf stat -e 'cycles/period=99999999999999999999/xyz' true
  event syntax error: '..les/period=99999999999999999999/xyz'
                                    \___ Bad base 10 number "99999999999999999999"
  Run 'perf list' for a list of valid events

   Usage: perf stat [] []

      -e, --event    event selector. use 'perf list' to list available events
  $ perf stat -e 'cycles:xyz' true
  event syntax error: 'cycles:xyz'
                             \___ Unrecognized input
  Run 'perf list' for a list of valid events

   Usage: perf stat [] []

      -e, --event    event selector. use 'perf list' to list available events

Signed-off-by: Ian Rogers 
Reviewed-by: Kan Liang 
Tested-by: Atish Patra 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Beeman Strong 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240416061533.921723-13-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Inline parse_events_update_lists

2024-04-27T01:07:20+00:00

The helper function just wraps a splice and free. Making the free
inline removes a comment, so then it just wraps a splice which we can
make inline too.

Signed-off-by: Ian Rogers 
Reviewed-by: Kan Liang 
Tested-by: Atish Patra 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Beeman Strong 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240416061533.921723-11-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Prefer sysfs/JSON hardware events over legacy

2024-04-27T01:07:20+00:00

It was requested that RISC-V be able to add events to the perf tool so
the PMU driver didn't need to map legacy events to config encodings:
https://lore.kernel.org/lkml/20240217005738.3744121-1-atishp@rivosinc.com/

This change makes the priority of events specified without a PMU the
same as those specified with a PMU, namely sysfs and JSON events are
checked first before using the legacy encoding.

The hw_term is made more generic as a hardware_event that encodes a
pair of string and int value, allowing parse_events_multi_pmu_add to
fall back on a known encoding when the sysfs/JSON adding fails for
core events. As this covers PE_VALUE_SYM_HW, that token is removed and
related code simplified.

Signed-off-by: Ian Rogers 
Reviewed-by: Kan Liang 
Tested-by: Atish Patra 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Beeman Strong 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240416061533.921723-10-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo