linux.git/tools/perf/util/parse-events.h, branch for-next

perf tool_pmu: Factor tool events into their own PMU

2024-10-11T06:40:32+00:00

Rather than treat tool events as a special kind of event, create a
tool only PMU where the events/aliases match the existing
duration_time, user_time and system_time events. Remove special
parsing and printing support for the tool events, but add function
calls for when PMU functions are called on a tool_pmu.

Move the tool PMU code in evsel into tool_pmu.c to better encapsulate
the tool event behavior in that file.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-5-irogers@google.com
Signed-off-by: Namhyung Kim

perf parse-events: Expose/rename config_term_name

2024-10-11T06:40:32+00:00

Expose config_term_name as parse_events__term_type_str so that PMUs not
in pmu.c may access it.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-4-irogers@google.com
Signed-off-by: Namhyung Kim

perf evsel: Add alternate_hw_config and use in evsel__match

2024-09-26T20:26:11+00:00

There are cases where we want to match events like instructions and
cycles with legacy hardware values, in particular in stat-shadow's
hard coded metrics. An evsel's name isn't a good point of reference as
it gets altered, strstr would be too imprecise and re-parsing the
event from its name is silly. Instead, hold the legacy hardware event
name, determined during parsing, in the evsel for this matching case.

Inline evsel__match2 that is only used in builtin-diff.

Acked-by: Namhyung Kim 
Signed-off-by: Ian Rogers 
Acked-by: Kan Liang 
Signed-off-by: James Clark 
Cc: Yang Jihong 
Cc: Dominique Martinet 
Cc: Colin Ian King 
Cc: Howard Chu 
Cc: Yunseong Kim 
Cc: Ze Gao 
Cc: Yicong Yang 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Jing Zhang 
Cc: Yang Li 
Cc: Leo Yan 
Cc: ak@linux.intel.com
Cc: Athira Rajeev 
Cc: linux-arm-kernel@lists.infradead.org
Cc: Sun Haiyong 
Cc: John Garry 
Link: https://lore.kernel.org/r/20240926144851.245903-2-james.clark@linaro.org
Signed-off-by: Namhyung Kim

perf pmus: Fake PMU clean up

2024-09-11T14:27:42+00:00

Rather than passing a fake PMU around, just pass that the fake PMU
should be used - true when doing testing. Move the fake PMU into
pmus.[ch] and try to abstract the PMU's properties in pmu.c, ie so
there is less "if fake_pmu" in non-PMU code. Give the fake PMU a made
up type number.

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Benjamin Gray 
Cc: Changbin Du 
Cc: Clément Le Goffic 
Cc: Colin Ian King 
Cc: Dominique Martinet 
Cc: Dr. David Alan Gilbert 
Cc: Howard Chu 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jing Zhang 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Junhao He 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Mark Rutland 
Cc: Mike Leach 
Cc: Namhyung Kim 
Cc: Oliver Upton 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sun Haiyong 
Cc: Tiezhu Yang 
Cc: Veronika Molnarova 
Cc: Weilin Wang 
Cc: Will Deacon 
Cc: Xu Yang 
Cc: Yang Jihong 
Cc: Yicong Yang 
Cc: Ze Gao 
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20240907050830.6752-3-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Add default_breakpoint_len helper

2024-09-04T12:49:09+00:00

The default breakpoint length is "sizeof(long)" however this is
incorrect on platforms like Aarch64 where sizeof(long) is 8 but the
breakpoint length is 4. Add a helper function that can be used to
determine the correct breakpoint length, in this change it just
returns the existing default sizeof(long) value.

Use the helper in the bp_account test so that, when modifying the
event from a watchpoint to a breakpoint, the breakpoint length is
appropriate for the architecture and not just sizeof(long).

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Athira Rajeev 
Cc: Chaitanya S Prakash 
Cc: Colin Ian King 
Cc: Dominique Martinet 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Junhao He 
Cc: Kan Liang 
Cc: Mark Rutland 
Cc: Masami Hiramatsu 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20240904050606.752788-5-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Add a retirement latency modifier

2024-08-12T21:15:27+00:00

Retirement latency is a separate sampled count used on newer Intel
CPUs.

Reviewed-by: Namhyung Kim 
Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Caleb Biggers 
Cc: Ingo Molnar 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Samantha Alt 
Link: https://lore.kernel.org/r/20240720062102.444578-2-weilin.wang@intel.com
Signed-off-by: Weilin Wang 
Signed-off-by: Arnaldo Carvalho de Melo

Revert "perf parse-events: Prefer sysfs/JSON hardware events over legacy"

2024-05-26T11:41:34+00:00

This reverts commit 617824a7f0f73e4de325cf8add58e55b28c12493.

This made a simple 'perf record -e cycles:pp make -j199' stop working on
the Ampere ARM64 system Linus uses to test ARM64 kernels, as discussed
at length in the threads in the Link tags below.

The fix provided by Ian wasn't acceptable and work to fix this will take
time we don't have at this point, so lets revert this and work on it on
the next devel cycle.

Reported-by: Linus Torvalds 
Cc: Adrian Hunter 
Cc: Bhaskar Chowdhury 
Cc: Ethan Adams 
Cc: Ian Rogers 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Namhyung Kim 
Cc: Thomas Gleixner 
Cc: Thomas Richter 
Cc: Tycho Andersen 
Cc: Yang Jihong 
Link: https://lore.kernel.org/lkml/CAHk-=wi5Ri=yR2jBVk-4HzTzpoAWOgstr1LEvg_-OXtJvXXJOA@mail.gmail.com
Link: https://lore.kernel.org/lkml/CAHk-=wiWvtFyedDNpoV7a8Fq_FpbB+F5KmWK2xPY3QoYseOf_A@mail.gmail.com
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: Add new 'fake_tp' parameter for tests

2024-05-10T13:49:26+00:00

The next commit will allow tracepoints starting with digits, but most
systems do not have any available by default so tests should skip the
actual "check if it exists in /sys/kernel/debug/tracing" step.

In order to do that, add a new boolean flag specifying if we should
actually "format" the probe or not.

Originally-by: Jiri Olsa 
Reviewed-by: Ian Rogers 
Signed-off-by: Dominique Martinet 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240510-perf_digit-v4-2-db1553f3233b@codewreck.org
Signed-off-by: Arnaldo Carvalho de Melo

perf parse-events: pass parse_state to add_tracepoint

2024-05-10T13:49:09+00:00

The next patch will add another flag to parse_state that we will want to
pass to evsel__newtp_idx(), so pass the whole parse_state all the way
down instead of giving only the index

Originally-by: Jiri Olsa 
Reviewed-by: Ian Rogers 
Signed-off-by: Dominique Martinet 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: https://lore.kernel.org/r/20240510-perf_digit-v4-1-db1553f3233b@codewreck.org
Signed-off-by: Arnaldo Carvalho de Melo

perf test pmu: Refactor format test and exposed test APIs

2024-05-03T20:08:20+00:00

In tests/pmu.c, make a common utility that creates a PMU in a mkdtemp
directory and uses regular PMU parsing logic to load that PMU. Formats
must still be eagerly loaded as by default the PMU code assumes devices
are going to be in sysfs.

In util/pmu.[ch], hide perf_pmu__format_parse but add the eager argument
to perf_pmu__lookup called by perf_pmus__add_test_pmu. Later patches
will eagerly load other non-sysfs files when eager loading is enabled.

In tests/pmu.c, rather than manually constructing a list of term
arguments, just use the term parsing code from a string.

Add more comments and debug logging.

Reviewed-by: Kan Liang 
Signed-off-by: Ian Rogers 
Cc: Alexander Shishkin 
Cc: Bjorn Helgaas 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jing Zhang 
Cc: Jiri Olsa 
Cc: Jonathan Corbet 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Randy Dunlap 
Cc: Ravi Bangoria 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20240502213507.2339733-4-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo