linux.git/tools/perf/util/evsel.c, branch for-next

perf tools: Fix precise_ip fallback logic

2024-12-05T23:15:29+00:00

Sometimes it returns other than EOPNOTSUPP for invalid precise_ip so
it cannot check the error code.  Let's move the fallback after the
missing feature checks so that it can handle EINVAL as well.  This also
aligns well with the existing behavior which blindly turns off the
precise_ip but we check the missing features correctly now.

Fixes: af954f76eea56453 ("perf tools: Check fallback error and order")
Reported-by: kernel test robot 
Reported-by: Arnaldo Carvalho de Melo 
Closes: https://lore.kernel.org/oe-lkp/202411301431.799e5531-lkp@intel.com
Tested-by: Arnaldo Carvalho de Melo 
Link: https://lore.kernel.org/r/Z1DV0lN8qHSysX7f@google.com
Signed-off-by: Namhyung Kim

perf pmu: Add calls enabling the hwmon_pmu

2024-11-09T16:28:03+00:00

Add the base PMU calls necessary for hwmon_pmu(s) to be
created/deleted and events found, listed, opened and read.

Signed-off-by: Ian Rogers 
Cc: Ravi Bangoria 
Cc: Yoshihiro Furudera 
Cc: Howard Chu 
Cc: Ze Gao 
Cc: Changbin Du 
Cc: Junhao He 
Cc: Weilin Wang 
Cc: James Clark 
Cc: Oliver Upton 
Cc: Athira Jajeev 
Link: https://lore.kernel.org/r/20241109003759.473460-6-irogers@google.com
Signed-off-by: Namhyung Kim

perf build: Include libtraceevent headers directly indicated by pkg-config

2024-11-09T06:42:57+00:00

Currently the libtraceevent's found by pkg-config, which give the
include path as:

  [root@localhost tmp]# pkg-config --cflags libtraceevent
  -I/usr/local/include/traceevent

So we should include the libtraceevent headers directly without
"traceevent/" prefix. Update all the users.

Fixes: 0f0e1f445690 ("perf build: Use pkg-config for feature check for libtrace{event,fs}")
Suggested-by: Namhyung Kim 
Link: https://lore.kernel.org/linux-perf-users/ZyF5_Hf1iL01kldE@google.com/
Signed-off-by: Yicong Yang 
Cc: leo.yan@arm.com
Cc: amadio@gentoo.org
Cc: linuxarm@huawei.com
Link: https://lore.kernel.org/r/20241105105649.45399-1-yangyicong@huawei.com
Signed-off-by: Namhyung Kim

perf tools: Check fallback error and order

2024-10-22T16:55:08+00:00

The perf_event_open might fail due to various reasons, so blindly
reducing precise_ip level might not be the best way to deal with it.

It seems the kernel return -EOPNOTSUPP when PMU doesn't support the
given precise level.  Let's try again with the correct error code.

This caused a problem on AMD, as it stops on precise_ip of 2 for IBS but
user events with exclude_kernel=1 cannot make progress.  Let's add the
evsel__handle_error_quirks() to this case specially.  I plan to work on
the kernel side to improve this situation but it'd still need some
special handling for IBS.

Reviewed-by: James Clark 
Reviewed-by: Ravi Bangoria 
Acked-by: Kan Liang 
Cc: James Clark 
Cc: Atish Patra 
Cc: Mingwei Zhang 
Cc: Kajol Jain 
Cc: Thomas Richter 
Cc: Palmer Dabbelt 
Link: https://lore.kernel.org/r/20241016062359.264929-8-namhyung@kernel.org
Signed-off-by: Namhyung Kim

perf tools: Detect missing kernel features properly

2024-10-22T16:52:11+00:00

The evsel__detect_missing_features() is to check if the attributes of
the evsel is supported or not.  But it checks the attribute based on the
given evsel, it might miss something if the attr doesn't have the bit or
give incorrect results if the event is special.

Also it maintains the order of the feature that was added to the kernel
which means it can assume older features should be supported once it
detects the current feature is working.  To minimized the confusion and
to accurately check the kernel features, I think it's better to use a
software event and go through all the features at once.

Also make the function static since it's only used in evsel.c.

Reviewed-by: James Clark 
Reviewed-by: Ravi Bangoria 
Acked-by: Kan Liang 
Cc: James Clark 
Cc: Atish Patra 
Cc: Mingwei Zhang 
Cc: Kajol Jain 
Cc: Thomas Richter 
Cc: Palmer Dabbelt 
Link: https://lore.kernel.org/r/20241016062359.264929-6-namhyung@kernel.org
Signed-off-by: Namhyung Kim

perf tools: Simplify evsel__add_modifier()

2024-10-22T16:52:11+00:00

Since it doesn't set the exclude_guest, no need to special handle the
bit and simply show only if one of host or guest bit is set.  Now the
default event name might not have :H prefix anymore so change the
dlfilter test not to compare the ":" at the end.

Reviewed-by: Ian Rogers 
Reviewed-by: James Clark 
Reviewed-by: Ravi Bangoria 
Acked-by: Kan Liang 
Cc: James Clark 
Cc: Atish Patra 
Cc: Mingwei Zhang 
Cc: Kajol Jain 
Cc: Thomas Richter 
Cc: Palmer Dabbelt 
Link: https://lore.kernel.org/r/20241016062359.264929-4-namhyung@kernel.org
Signed-off-by: Namhyung Kim

perf tools: Add fallback for exclude_guest

2024-10-22T16:51:22+00:00

Commit 7b100989b4f6bce70 ("perf evlist: Remove __evlist__add_default")
changed to parse "cycles:P" event instead of creating a new cycles
event for perf record.  But it also changed the way how modifiers are
handled so it doesn't set the exclude_guest bit by default.

It seems Apple M1 PMU requires exclude_guest set and returns EOPNOTSUPP
if not.  Let's add a fallback so that it can work with default events.

Also update perf stat hybrid tests to handle possible u or H modifiers.

Reviewed-by: Ian Rogers 
Reviewed-by: James Clark 
Reviewed-by: Ravi Bangoria 
Acked-by: Kan Liang 
Cc: James Clark 
Cc: Atish Patra 
Cc: Mingwei Zhang 
Cc: Kajol Jain 
Cc: Thomas Richter 
Cc: Palmer Dabbelt 
Link: https://lore.kernel.org/r/20241016062359.264929-2-namhyung@kernel.org
Fixes: 7b100989b4f6bce70 ("perf evlist: Remove __evlist__add_default")
Signed-off-by: Namhyung Kim

perf test: Remove C test wrapper for attr.py

2024-10-17T20:17:36+00:00

Remove the C wrapper now a shell script wrapper exists. Move
perf_event_attr dumping functions to evsel.c and reduce the scope of
variables/defines. Use fprintf to avoid snprintf complexities in
WRITE_ASS.

Add __SANE_USERSPACE_TYPES__ to evsel.c to fix format flag issues on
PowerPC triggered by moving attr.c functions to evsel.c.

Signed-off-by: Ian Rogers 
Tested-by: Athira Rajeev 
Cc: Stephen Rothwell 
Cc: zhaimingbing 
Cc: Howard Chu 
Cc: Ze Gao 
Cc: Weilin Wang 
Cc: James Clark 
Cc: Leo Yan 
Cc: Thomas Richter 
Cc: Veronika Molnarova 
Link: https://lore.kernel.org/r/20241015000158.871828-3-irogers@google.com
Signed-off-by: Namhyung Kim

perf evsel: Fix missing inherit + sample read check

2024-10-14T19:04:31+00:00

It should not clear the inherit bit simply because the kernel doesn't
support the sample read with it.  IOW the inherit bit should be kept
when the sample read is not requested for the event.

Fixes: 90035d3cd876cb71 ("tools/perf: Allow inherit + PERF_SAMPLE_READ when opening events")
Acked-by: Ben Gainey 
Link: https://lore.kernel.org/r/20241009062250.730192-1-namhyung@kernel.org
Signed-off-by: Namhyung Kim

perf tool_pmu: Rename perf_tool_event__* to tool_pmu__*

2024-10-11T06:40:32+00:00

Now the events are associated with the tool PMU, rename the functions
to reflect this.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20241002032016.333748-7-irogers@google.com
Signed-off-by: Namhyung Kim