linux.git/tools/perf/builtin-script.c, branch v7.3-rc2

perf script: Fix metric_evlist leak in script_find_metrics

2026-08-10T04:58:10+00:00

Fix a memory leak in script_find_metrics() where metric_evlist is leaked
when returning early on error paths.

Assisted-by: Antigravity:gemini-3.1-pro
Fixes: 3622990efaab ("perf script: Change metric format to use json metrics")
Signed-off-by: Ian Rogers 
Signed-off-by: Namhyung Kim

perf parse-events: Restrict core PMU bypass to --cputype option

2026-07-01T00:09:13+00:00

Commit b1c5efbfd92e ("perf parse-events: Remove hard coded legacy hardware
and cache parsing") introduced a bypass to PMU filtering to prevent uncore
PMUs from being filtered out during event parsing, which was required for
resolving `duration_time` and `uncore_freq` when running with `--cputype`.
However, this bypass was active whenever `pmu_filter` was set, which also
incorrectly bypassed filtering for the `--pmu-filter` option.

Introduce a `cputype_filter` boolean flag in `parse_events_state` and
`parse_events_option_args` to distinguish filtering initiated by
`--cputype` from that initiated by `--pmu-filter`. Restrict the core-only
check in `parse_events__filter_pmu()` to when `cputype_filter` is true.

Fixes: b1c5efbfd92e ("perf parse-events: Remove hard coded legacy hardware and cache parsing")
Assisted-by: Antigravity:gemini-3.1-pro
Signed-off-by: Ian Rogers 
Signed-off-by: Namhyung Kim

perf evlist: Add reference count checking

2026-06-30T17:17:11+00:00

Now the evlist is reference counted, add reference count checking so
that gets and puts are paired and easy to debug. Reference count
checking is documented here:
https://perfwiki.github.io/main/reference-count-checking/

This large patch is adding accessors to evlist functions and switching
to their use. There was some minor renaming as evlist__mmap is now an
accessor to the mmap variable, and the original evlist__mmap is
renamed to evlist__do_mmap.

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alice Rogers 
Cc: Dapeng Mi 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Leo Yan 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: Namhyung Kim

perf evlist: Add reference count

2026-06-30T17:17:10+00:00

This a no-op for most of the perf tool. The reference count is set to
1 at allocation, the put will see the 1, decrement it and perform the
delete.

The purpose for adding the reference count is for the python code. Prior
to this change the python code would clone evlists, but this has issues
if events are opened, etc.

This change adds a reference count for the evlists and a later change
will add it to evsels. The combination is needed for the python code to
operate correctly (not hit asserts in the evsel clone), but the changes
are broken apart for the sake of smaller patches.

Assisted-by: Gemini:gemini-3.1-pro-preview
Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alice Rogers 
Cc: Dapeng Mi 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Leo Yan 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: Namhyung Kim

perf tools: Guard remaining test_bit calls from OOB sample CPU

2026-06-04T22:17:36+00:00

auxtrace.c:filter_cpu() and builtin-script.c:filter_cpu() call
test_bit(cpu, cpu_bitmap) where cpu_bitmap is declared with
MAX_NR_CPUS bits.  When the CPU value from a perf.data event is
corrupt or absent (e.g. negative or >= MAX_NR_CPUS), test_bit reads
out of bounds.

Add bounds checks before test_bit(): >= 0 for the int16_t cpu.cpu in
auxtrace (which also covers the -1 sentinel), and < MAX_NR_CPUS for
both sites.  Matches the pattern applied in the previous series for
builtin-annotate.c, builtin-diff.c, builtin-report.c, and
builtin-sched.c.

Fixes: 644e0840ad46 ("perf auxtrace: Add CPU filter support")
Fixes: 5d67be97f890 ("perf report/annotate/script: Add option to specify a CPU range")
Reported-by: sashiko-bot 
Cc: Adrian Hunter 
Cc: Anton Blanchard 
Cc: Jiri Olsa 
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Include file offset and event type name in skip messages

2026-06-03T19:31:03+00:00

Add the perf.data file offset and use perf_event__name() instead of raw
event type integers in the 'problem processing event, skipping it'
messages emitted by process_sample_event() callbacks across annotate,
c2c, diff, kmem, kvm, kwork, lock, report, script, and build-id.

This lets users cross-reference skipped events with 'perf report -D'
output.  Also add explicit #include "util/event.h" and 
where needed to avoid depending on transitive includes.

Reviewed-by: Ian Rogers 
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Arnaldo Carvalho de Melo

perf script: Fix missing '+' indicator when branch counter reaches upper limit

2026-05-30T00:22:44+00:00

When displaying branch counter (br_cntr) information, a "+" suffix
represents that event occurrences may have been lost due to branch
counter saturation. However, this indicator was missing in perf script.
Add it back.

Before:

 # Branch counter abbr list:
 # cpu_core/event=0xc4,umask=0x20/ppp = A
 # cpu_core/instructions/ = B
 # cpu_core/MEM_INST_RETIRED.ALL_LOADS/ = C
 # cpu_core/MEM_LOAD_RETIRED.L2_MISS/ = D
 # '-' No event occurs
 # '+' Event occurrences may be lost due to branch counter saturated
...
        datasym+190:
        00005567f9951676        jz 0x5567f995162dr_cntr: BBBC   # PRED 1 cycles [1]
...
After:
...
        datasym+190:
        00005567f9951676        jz 0x5567f995162dr_cntr: BBB+C  # PRED 1 cycles [1]
...

Reviewed-by: Dapeng Mi 
Signed-off-by: Dapeng Mi 
Signed-off-by: Thomas Falcon 
Acked-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Signed-off-by: Arnaldo Carvalho de Melo

perf script: Sort includes and add missed explicit dependencies

2026-05-27T11:20:43+00:00

Fix missing #include of pmu.h found while cleaning the evsel/evlist
header files. Sort the remaining header files for consistency with the
rest of the code. Doing this exposed a missing forward declaration of
addr_location in print_insn.h, add this and sort the forward
declarations.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Adrian Hunter 
Cc: Alice Rogers 
Cc: Dapeng Mi 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Leo Yan 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Signed-off-by: Arnaldo Carvalho de Melo

perf script: Don't pass evsel with sample

2026-05-20T19:39:40+00:00

As struct perf_sample now directly contains its own resolved evsel pointer,
passing the evsel separately is redundant and clutters the interface.

Remove the redundant evsel parameter from script-specific handlers and
structures, ensuring the tool always directly accesses the evsel bound to the
sample. This simplifies the API signatures and eliminates the risk of passing
an inconsistent evsel.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Adrian Hunter 
Cc: Albert Ou 
Cc: Alexander Shishkin 
Cc: Alexandre Ghiti 
Cc: Andi Kleen 
Cc: Andrew Jones 
Cc: Anup Patel 
Cc: Athira Rajeev 
Cc: Blake Jones 
Cc: Chen Ni 
Cc: Chun-Tse Shao 
Cc: Dapeng Mi 
Cc: Derek Foreman 
Cc: Dmitriy Vyukov 
Cc: Dr. David Alan Gilbert 
Cc: Howard Chu 
Cc: Hrishikesh Suresh 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Krzysztof Łopatowski 
Cc: Leo Yan 
Cc: Palmer Dabbelt 
Cc: Paul Walmsley 
Cc: Peter Zijlstra 
Cc: Quan Zhou 
Cc: Ravi Bangoria 
Cc: Swapnil Sapkal 
Cc: Thomas Falcon 
Cc: Tianyou Li 
Cc: Yujie Liu 
Cc: tanze 
Signed-off-by: Arnaldo Carvalho de Melo

perf callchain: Don't pass evsel and sample

2026-05-20T19:35:59+00:00

As struct perf_sample now directly contains its own resolved evsel pointer,
passing the evsel separately is redundant and clutters the interface.

Remove the redundant evsel parameter from callchain-specific handlers and
structures, ensuring the tool always directly accesses the evsel bound to the
sample. This simplifies the API signatures and eliminates the risk of passing
an inconsistent evsel.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Adrian Hunter 
Cc: Albert Ou 
Cc: Alexander Shishkin 
Cc: Alexandre Ghiti 
Cc: Andi Kleen 
Cc: Andrew Jones 
Cc: Anup Patel 
Cc: Athira Rajeev 
Cc: Blake Jones 
Cc: Chen Ni 
Cc: Chun-Tse Shao 
Cc: Dapeng Mi 
Cc: Derek Foreman 
Cc: Dmitriy Vyukov 
Cc: Dr. David Alan Gilbert 
Cc: Howard Chu 
Cc: Hrishikesh Suresh 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Krzysztof Łopatowski 
Cc: Leo Yan 
Cc: Palmer Dabbelt 
Cc: Paul Walmsley 
Cc: Peter Zijlstra 
Cc: Quan Zhou 
Cc: Ravi Bangoria 
Cc: Swapnil Sapkal 
Cc: Thomas Falcon 
Cc: Tianyou Li 
Cc: Yujie Liu 
Cc: tanze 
Signed-off-by: Arnaldo Carvalho de Melo