linux.git/tools/perf/Build, branch v7.2-rc1

perf trace beauty: Make beauty generated C code standalone .o files

2026-05-20T20:46:45+00:00

Previously, builtin-trace.c directly included 15 embedded C files
(e.g. trace/beauty/mmap.c and fsconfig_arrays.c), which in turn depend
on dozens of generated beauty script arrays. To satisfy these embedded
inclusions, the global Makefile.perf would define all the generator
variables/rules and include them in the prepare umbrella target, choking
parallel build startup.

Furthermore, tools/perf/util/syscalltbl.c included its own generated mapper,
and util/env.c conditionally included arch_errno_names.c inline, splitting
consumers across directories and preventing clean Make encapsulation.

Refactor the framework to achieve better encapsulation:
1. Move util/syscalltbl.[ch] into trace/beauty/ to co-locate with all
   generated code consumers.
2. Create fsconfig.c and flatten embedded beauty .c files to compile as
   independent standalone objects via trace/beauty/Build, exporting their
   formatting functions via beauty.h and env.h. Switch arch_errno_names.o
   and syscalltbl.o assignments directly to perf-util-y and add an
   unconditional top-level recursive kbuild hook (perf-util-y += trace/beauty/)
   to compile them into libperf-util.a, resolving remote linkage for util/env.c,
   util/bpf-trace-summary.c, and standalone python extensions.
3. Bridge private opaque references (struct trace) securely via accessors
   trace__show_zeros() and trace__host(), avoiding header entanglements.
4. Consolidate all generator variables, script paths, and array generation
   rules entirely out of Makefile.perf and place them directly inside the
   exact local Build files where their output objects are compiled
   (trace/beauty/Build and trace/beauty/tracepoints/Build), binding
   prerequisites locally. Use  directly inside
   generator recipes to guarantee dynamic directory creation before script
   redirection, and append  across all rules to print
   clean, standardized GEN ... file.c output during compilation.
5. Clean up clean target to recursively remove the generated directory
   instead of relying on dozens of individual variables.

This unchokes the "prepare" target parallel barrier, allows make to evaluate
generation scripts purely locally where consumed, and flattens the tracepoint
formatting architecture.

Testing a parallel build (make -j28 all from scratch) shows improvements:
  Before:
    real    0m28.689s
    user    2m38.490s
    sys     0m30.148s

  After:
    real    0m27.642s
    user    2m32.356s
    sys     0m26.683s

So reclaiming ~9.6 seconds of raw CPU time and over 1 full second off
overall real-world build latency, by overlapping sub-make startup and
avoiding top-level double-parsing overhead.

Reviewed-by: Namhyung Kim 
Assisted-by: Gemini:gemini-3.1-pro-preview
Signed-off-by: Ian Rogers 
Tested-by: James Clark 
Cc: Adrian Hunter 
Cc: Albert Ou 
Cc: Alexandre Chartre 
Cc: Alexandre Ghiti 
Cc: Andrii Nakryiko 
Cc: Ankur Arora 
Cc: Collin Funk 
Cc: Costa Shulyupin 
Cc: Daniel Borkmann 
Cc: Dapeng Mi 
Cc: David Sterba 
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: Eduard Zingerman 
Cc: Howard Chu 
Cc: Ingo Molnar 
Cc: Jiri Olsa 
Cc: Kumar Kartikeya Dwivedi 
Cc: Leo Yan 
Cc: Markus Mayer 
Cc: Martin KaFai Lau 
Cc: Nathan Chancellor 
Cc: Nick Terrell 
Cc: Palmer Dabbelt 
Cc: Paul Walmsley 
Cc: Peter Zijlstra 
Cc: Quentin Monnet 
Cc: Ricky Ringler 
Cc: Song Liu 
Cc: Swapnil Sapkal 
Cc: Thomas Falcon 
Cc: Tomas Glozar 
Cc: Yonghong Song 
Signed-off-by: Arnaldo Carvalho de Melo

perf build: Specify shellcheck should use bash

2025-06-30T16:43:06+00:00

When someone has a global shellcheckrc file, for example at
~/.config/shellcheckrc, with the directive 'shell=sh', building perf
will fail with many shellcheck errors like:

    In tests/shell/base_probe/test_adding_kernel.sh line 294:
    (( TEST_RESULT += $? ))
    ^---------------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.

    For more information:
      https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...
    make[5]: *** [tests/Build:91: tests/shell/base_probe/test_adding_kernel.sh.shellcheck_log] Error 1

Passing the '-s bash' option ensures that it runs correctly regardless
of a developers global configuration.

This patch adds '-s bash' and other options to the SHELLCHECK variable
in Makefile.perf and makes use of the variable consistently.

Signed-off-by: Collin Funk 
Link: https://lore.kernel.org/r/63491dbc8439edf2e949d80e264b9d22332fea61.1751082075.git.collin.funk1@gmail.com
Signed-off-by: Namhyung Kim

perf build: Add pylint build tests

2025-03-24T16:38:20+00:00

If PYLINT=1 is passed to the build then run pylint over python code in
perf. Unlike shellcheck this isn't default on as there are currently
too many errors.

An example of an error:
```
************* Module setup
util/setup.py:19:0: C0301: Line too long (127/100) (line-too-long)
util/setup.py:20:0: C0301: Line too long (138/100) (line-too-long)
util/setup.py:63:0: C0301: Line too long (106/100) (line-too-long)
util/setup.py:1:0: C0114: Missing module docstring (missing-module-docstring)
util/setup.py:24:4: W0622: Redefining built-in 'vars' (redefined-builtin)
util/setup.py:11:4: C0103: Constant name "cc_options" doesn't conform to UPPER_CASE naming style (invalid-name)
util/setup.py:13:4: C0103: Constant name "cc_options" doesn't conform to UPPER_CASE naming style (invalid-name)
util/setup.py:15:34: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
util/setup.py:18:0: C0116: Missing function or method docstring (missing-function-docstring)
util/setup.py:19:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
util/setup.py:44:0: C0413: Import "from setuptools import setup, Extension" should be placed at the top of the module (wrong-import-position)
util/setup.py:46:0: C0413: Import "from setuptools.command.build_ext import build_ext as _build_ext" should be placed at the top of the module (wrong-import-position)
util/setup.py:47:0: C0413: Import "from setuptools.command.install_lib import install_lib as _install_lib" should be placed at the top of the module (wrong-import-position)
util/setup.py:49:0: C0115: Missing class docstring (missing-class-docstring)
util/setup.py:49:0: C0103: Class name "build_ext" doesn't conform to PascalCase naming style (invalid-name)
util/setup.py:52:8: W0201: Attribute 'build_lib' defined outside __init__ (attribute-defined-outside-init)
util/setup.py:53:8: W0201: Attribute 'build_temp' defined outside __init__ (attribute-defined-outside-init)
util/setup.py:55:0: C0115: Missing class docstring (missing-class-docstring)
util/setup.py:55:0: C0103: Class name "install_lib" doesn't conform to PascalCase naming style (invalid-name)
util/setup.py:58:8: W0201: Attribute 'build_dir' defined outside __init__ (attribute-defined-outside-init)

*-----------------------------------------------------------------
Your code has been rated at 6.67/10 (previous run: 6.51/10, +0.16)

make[4]: *** [util/Build:442: util/setup.py.pylint_log] Error 1
```

Reviewed-by: James Clark 
Signed-off-by: Ian Rogers 
Link: https://lore.kernel.org/r/20250311213628.569562-5-irogers@google.com
Signed-off-by: Namhyung Kim

perf build: Add mypy build tests

2025-03-24T16:38:20+00:00

If MYPY=1 is passed to the build then run mypy over python code in
perf. Unlike shellcheck this isn't default on as there are currently
too many errors.

An example of an error:
```
util/setup.py:8: error: Item "None" of "str | None" has no attribute "split"  [union-attr]
util/setup.py:15: error: Item "None" of "IO[bytes] | None" has no attribute "readline"  [union-attr]
util/setup.py:15: error: List item 0 has incompatible type "str | None"; expected "str | bytes | PathLike[str] | PathLike[bytes]"  [list-item]
util/setup.py:16: error: Unsupported left operand type for + ("None")  [operator]
util/setup.py:16: note: Left operand is of type "str | None"
util/setup.py:74: error: Unsupported left operand type for + ("None")  [operator]
util/setup.py:74: note: Left operand is of type "str | None"
Found 5 errors in 1 file (checked 1 source file)
make[4]: *** [util/Build:430: util/setup.py.mypy_log] Error 1
```

Reviewed-by: James Clark 
Signed-off-by: Ian Rogers 
Link: https://lore.kernel.org/r/20250311213628.569562-4-irogers@google.com
Signed-off-by: Namhyung Kim

perf build: Rename TEST_LOGS to SHELL_TEST_LOGS

2025-03-24T16:38:20+00:00

Rename TEST_LOGS to SHELL_TEST_LOGS as later changes will add more
kinds of test logs.
Minor comment tweak in Makefile.perf as more than just test shell
tests are checked.

Reviewed-by: James Clark 
Signed-off-by: Ian Rogers 
Link: https://lore.kernel.org/r/20250311213628.569562-3-irogers@google.com
Signed-off-by: Namhyung Kim

perf check: Introduce 'check' subcommand

2024-09-04T12:56:05+00:00

Currently the presence of a feature is checked with a combination of
perf version --build-options and greps, such as:

    perf version --build-options | grep " on .* HAVE_FEATURE"

Instead of this, introduce a subcommand "perf check feature", with which
scripts can test for presence of a feature, such as:

    perf check feature HAVE_FEATURE

'perf check feature' command is expected to have exit status of 0 if
feature is built-in, and 1 if it's not built-in or if feature is not known.

Multiple features can also be passed as a comma-separated list, in which
case the exit status will be 1 only if all of the passed features are
built-in. For example, with below command, it will have exit status of 0
only if both libtraceevent and bpf are enabled, else 1 in all other cases

    perf check feature libtraceevent,bpf

The arguments are case-insensitive.
An array 'supported_features' has also been introduced that can be used by
other commands like 'perf version --build-options', so that new features
can be added in one place, with the array

Committer testing:

  $ perf check feature libtraceevent,bpf
           libtraceevent: [ on  ]  # HAVE_LIBTRACEEVENT
                     bpf: [ on  ]  # HAVE_LIBBPF_SUPPORT
  $ perf check feature libtraceevent
           libtraceevent: [ on  ]  # HAVE_LIBTRACEEVENT
  $ perf check feature bpf
                     bpf: [ on  ]  # HAVE_LIBBPF_SUPPORT
  $ perf check -q feature bpf && echo "BPF support is present"
  BPF support is present
  $ perf check -q feature Bogus && echo "Bogus support is present"
  $

Reviewed-by: Athira Rajeev 
Signed-off-by: Aditya Gupta 
Tested-by: Arnaldo Carvalho de Melo 
Cc: Athira Rajeev 
Cc: Disha Goel 
Cc: Ian Rogers 
Cc: Jiri Olsa 
Cc: Kajol Jain 
Cc: Madhavan Srinivasan 
Cc: Namhyung Kim 
Link: https://lore.kernel.org/r/20240904061836.55873-3-adityag@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf util: Make util its own library

2024-06-26T18:07:42+00:00

Make the util directory into its own library. This is done to avoid
compiling code twice, once for the perf tool and once for the perf
python module. For convenience:
  arch/common.c
  scripts/perl/Perf-Trace-Util/Context.c
  scripts/python/Perf-Trace-Util/Context.c
are made part of this library.

Signed-off-by: Ian Rogers 
Reviewed-by: James Clark 
Cc: Suzuki K Poulose 
Cc: Kees Cook 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: Nick Terrell 
Cc: Gary Guo 
Cc: Alex Gaynor 
Cc: Boqun Feng 
Cc: Wedson Almeida Filho 
Cc: Ze Gao 
Cc: Alice Ryhl 
Cc: Andrei Vagin 
Cc: Yicong Yang 
Cc: Jonathan Cameron 
Cc: Guo Ren 
Cc: Miguel Ojeda 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Oliver Upton 
Cc: John Garry 
Cc: Benno Lossin 
Cc: Björn Roy Baron 
Cc: Andreas Hindborg 
Cc: Paul Walmsley 
Signed-off-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20240625214117.953777-7-irogers@google.com

perf bench: Make bench its own library

2024-06-26T18:07:28+00:00

Make the benchmark code into a library so it may be linked against
things like the python module to avoid compiling code twice.

Signed-off-by: Ian Rogers 
Reviewed-by: James Clark 
Cc: Suzuki K Poulose 
Cc: Kees Cook 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: Nick Terrell 
Cc: Gary Guo 
Cc: Alex Gaynor 
Cc: Boqun Feng 
Cc: Wedson Almeida Filho 
Cc: Ze Gao 
Cc: Alice Ryhl 
Cc: Andrei Vagin 
Cc: Yicong Yang 
Cc: Jonathan Cameron 
Cc: Guo Ren 
Cc: Miguel Ojeda 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Oliver Upton 
Cc: John Garry 
Cc: Benno Lossin 
Cc: Björn Roy Baron 
Cc: Andreas Hindborg 
Cc: Paul Walmsley 
Signed-off-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20240625214117.953777-6-irogers@google.com

perf test: Make tests its own library

2024-06-26T18:07:11+00:00

Make the tests code its own library. This is done to avoid compiling
code twice, once for the perf tool and once for the perf python
module.

Signed-off-by: Ian Rogers 
Reviewed-by: James Clark 
Cc: Suzuki K Poulose 
Cc: Kees Cook 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: Nick Terrell 
Cc: Gary Guo 
Cc: Alex Gaynor 
Cc: Boqun Feng 
Cc: Wedson Almeida Filho 
Cc: Ze Gao 
Cc: Alice Ryhl 
Cc: Andrei Vagin 
Cc: Yicong Yang 
Cc: Jonathan Cameron 
Cc: Guo Ren 
Cc: Miguel Ojeda 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Oliver Upton 
Cc: John Garry 
Cc: Benno Lossin 
Cc: Björn Roy Baron 
Cc: Andreas Hindborg 
Cc: Paul Walmsley 
Signed-off-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20240625214117.953777-5-irogers@google.com

perf ui: Make ui its own library

2024-06-26T18:06:34+00:00

Make the ui code its own library. This is done to avoid compiling code
twice, once for the perf tool and once for the perf python module.

Signed-off-by: Ian Rogers 
Reviewed-by: James Clark 
Cc: Suzuki K Poulose 
Cc: Kees Cook 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: Nick Terrell 
Cc: Gary Guo 
Cc: Alex Gaynor 
Cc: Boqun Feng 
Cc: Wedson Almeida Filho 
Cc: Ze Gao 
Cc: Alice Ryhl 
Cc: Andrei Vagin 
Cc: Yicong Yang 
Cc: Jonathan Cameron 
Cc: Guo Ren 
Cc: Miguel Ojeda 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Oliver Upton 
Cc: John Garry 
Cc: Benno Lossin 
Cc: Björn Roy Baron 
Cc: Andreas Hindborg 
Cc: Paul Walmsley 
Signed-off-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20240625214117.953777-3-irogers@google.com