linux.git/tools/net/sunrpc, branch v6.17

xdrgen: Fix code generated for counted arrays

2025-05-16T14:58:48+00:00

When an XDR counted array has a maximum element count, xdrgen adds
a bounds check to the encoder or decoder for that type. But in cases
where the .x provides no maximum element count, such as

struct notify4 {
        /* composed from notify_type4 or notify_deviceid_type4 */
        bitmap4         notify_mask;
        notifylist4     notify_vals;
};

struct CB_NOTIFY4args {
        stateid4    cna_stateid;
        nfs_fh4     cna_fh;
        notify4     cna_changes<>;
};

xdrgen is supposed to omit that bounds check. Some of the Jinja2
templates handle that correctly, but a few are incorrect and leave
the bounds check in place with a maximum of zero, which causes
encoding/decoding of that type to fail unconditionally.

Reported-by: Jeff Layton 
Signed-off-by: Chuck Lever

xdrgen: Remove program_stat_to_errno() call sites

2024-11-19T01:23:07+00:00

Refactor: Translating an on-the-wire value to a local host errno is
architecturally a job for the proc function, not the XDR decoder.

Signed-off-by: Chuck Lever

xdrgen: Update the files included in client-side source code

2024-11-19T01:23:06+00:00

In particular, client-side source code needs the definition of
"struct rpc_procinfo" and does not want header files that pull
in "struct svc_rqst". Otherwise, the source does not compile.

Signed-off-by: Chuck Lever

xdrgen: Remove check for "nfs_ok" in C templates

2024-11-19T01:23:06+00:00

Obviously, "nfs_ok" is defined only for NFS protocols. Other XDR
protocols won't know "nfs_ok" from Adam.

Signed-off-by: Chuck Lever

xdrgen: Remove tracepoint call site

2024-11-19T01:23:06+00:00

This tracepoint was a "note to self" and is not operational. It is
added only to client-side code, which so far we haven't needed. It
will cause immediate breakage once we start generating client code,
though, so remove it now.

Signed-off-by: Chuck Lever

xdrgen: Add a utility for extracting XDR from RFCs

2024-11-19T01:22:59+00:00

For convenience, copy the XDR extraction script from RFC

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

xdrgen: emit maxsize macros

2024-11-11T18:42:06+00:00

Add "definitions" subcommand logic to emit maxsize macros in
generated code.

Signed-off-by: Chuck Lever

xdrgen: Add generator code for XDR width macros

2024-11-11T18:42:05+00:00

Introduce logic in the code generators to emit maxsize (XDR
width) definitions. In C, these are pre-processor macros.

Signed-off-by: Chuck Lever

xdrgen: XDR width for union types

2024-11-11T18:42:05+00:00

Not yet complete.

The tool doesn't do any math yet. Thus, even though the maximum XDR
width of a union is the width of the union enumerator plus the width
of its largest arm, we're using the sum of all the elements of the
union for the moment.

This means that buffer size requirements are overestimated, and that
the generated maxsize macro cannot yet be used for determining data
element alignment in the XDR buffer.

Signed-off-by: Chuck Lever

xdrgen: XDR width for pointer types

2024-11-11T18:42:05+00:00

The XDR width of a pointer type is the sum of the widths of each of
the struct's fields, except for the last field. The width of the
implicit boolean "value follows" field is added as well.

Signed-off-by: Chuck Lever