linux.git/tools/lib/bpf/btf_dump.c, branch v5.6

libbpf: Fix error handling bug in btf_dump__new

2020-01-17T16:33:17+00:00

Fix missing jump to error handling in btf_dump__new, found by Coverity static
code analysis.

Fixes: 9f81654eebe8 ("libbpf: Expose BTF-to-C type declaration emitting API")
Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Link: https://lore.kernel.org/bpf/20200117060801.1311525-2-andriin@fb.com

libbpf: Poison kernel-only integer types

2020-01-10T18:38:00+00:00

It's been a recurring issue with types like u32 slipping into libbpf source
code accidentally. This is not detected during builds inside kernel source
tree, but becomes a compilation error in libbpf's Github repo. Libbpf is
supposed to use only __{s,u}{8,16,32,64} typedefs, so poison {s,u}{8,16,32,64}
explicitly in every .c file. Doing that in a bit more centralized way, e.g.,
inside libbpf_internal.h breaks selftests, which are both using kernel u32 and
libbpf_internal.h.

This patch also fixes a new u32 occurence in libbpf.c, added recently.

Fixes: 590a00888250 ("bpf: libbpf: Add STRUCT_OPS support")
Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Acked-by: Martin KaFai Lau 
Link: https://lore.kernel.org/bpf/20200110181916.271446-1-andriin@fb.com

libbpf: Expose BTF-to-C type declaration emitting API

2019-12-15T23:58:05+00:00

Expose API that allows to emit type declaration and field/variable definition
(if optional field name is specified) in valid C syntax for any provided BTF
type. This is going to be used by bpftool when emitting data section layout as
a struct. As part of making this API useful in a stand-alone fashion, move
initialization of some of the internal btf_dump state to earlier phase.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Acked-by: Martin KaFai Lau 
Link: https://lore.kernel.org/bpf/20191214014341.3442258-8-andriin@fb.com

libbpf: Expose btf__align_of() API

2019-12-15T23:58:05+00:00

Expose BTF API that calculates type alignment requirements.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Link: https://lore.kernel.org/bpf/20191214014341.3442258-7-andriin@fb.com

tools, bpf: Rename pr_warning to pr_warn to align with kernel logging

2019-10-21T12:38:41+00:00

For kernel logging macros, pr_warning() is completely removed and
replaced by pr_warn(). By using pr_warn() in tools/lib/bpf/ for
symmetry to kernel logging macros, we could eventually drop the
use of pr_warning() in the whole kernel tree.

Signed-off-by: Kefeng Wang 
Signed-off-by: Daniel Borkmann 
Reviewed-by: Sergey Senozhatsky 
Acked-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20191021055532.185245-1-wangkefeng.wang@huawei.com

libbpf: Handle invalid typedef emitted by old GCC

2019-10-11T21:11:55+00:00

Old GCC versions are producing invalid typedef for __gnuc_va_list
pointing to void. Special-case this and emit valid:

typedef __builtin_va_list __gnuc_va_list;

Reported-by: John Fastabend 
Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann 
Acked-by: Martin KaFai Lau 
Acked-by: John Fastabend 
Link: https://lore.kernel.org/bpf/20191011032901.452042-1-andriin@fb.com

libbpf: Fix struct end padding in btf_dump

2019-10-09T22:38:36+00:00

Fix a case where explicit padding at the end of a struct is necessary
due to non-standart alignment requirements of fields (which BTF doesn't
capture explicitly).

Fixes: 351131b51c7a ("libbpf: add btf_dump API for BTF-to-C conversion")
Reported-by: John Fastabend 
Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Tested-by: John Fastabend 
Link: https://lore.kernel.org/bpf/20191008231009.2991130-2-andriin@fb.com

libbpf: Teach btf_dumper to emit stand-alone anonymous enum definitions

2019-09-26T12:38:29+00:00

BTF-to-C converter previously skipped anonymous enums in an assumption
that those are embedded in struct's field definitions. This is not
always the case and a lot of kernel constants are defined as part of
anonymous enums. This change fixes the logic by eagerly marking all
types as either referenced by any other type or not. This is enough to
distinguish two classes of anonymous enums and emit previously omitted
enum definitions.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann 
Link: https://lore.kernel.org/bpf/20190925203745.3173184-1-andriin@fb.com

libbpf: fix false uninitialized variable warning

2019-09-25T20:15:02+00:00

Some compilers emit warning for potential uninitialized next_id usage.
The code is correct, but control flow is too complicated for some
compilers to figure this out. Re-initialize next_id to satisfy
compiler.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann

libbpf: convert libbpf code to use new btf helpers

2019-08-07T21:43:49+00:00

Simplify code by relying on newly added BTF helper functions.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov