linux.git/tools/kvm, branch v4.16-rc2

tools/kvm_stat: sort '-f help' output

2017-12-21T12:03:32+00:00

Sort the fields returned by specifying '-f help' on the command line.
While at it, simplify the code a bit, indent the output and eliminate an
extra blank line at the beginning.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: add line for totals

2017-12-14T08:25:47+00:00

Add a line for the total number of events and current average at the
bottom of the body.
Note that both values exclude child trace events. I.e. if drilldown is
activated via interactive command 'x', only the totals are accounted, or
we'd be counting these twice (see previous commit "tools/kvm_stat: fix
child trace events accounting").

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: stop ignoring unhandled arguments

2017-12-14T08:25:46+00:00

Unhandled arguments, which could easily include typos, are simply
ignored. We should be strict to avoid undetected typos.
To reproduce start kvm_stat with an extra argument, e.g.
'kvm_stat -d bnuh5ol' and note that this will actually work.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: suppress usage information on command line errors

2017-12-14T08:25:46+00:00

Errors while parsing the '-g' command line argument result in display of
usage information prior to the error message. This is a bit confusing,
as the command line is syntactically correct.
To reproduce, run 'kvm_stat -g' and specify a non-existing or inactive
guest.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: handle invalid regular expressions

2017-12-14T08:25:45+00:00

Passing an invalid regular expression on the command line results in a
traceback. Note that interactive specification of invalid regular
expressions is not affected
To reproduce, run "kvm_stat -f '*'".

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: add hint on '-f help' to man page

2017-12-14T08:25:44+00:00

The man page update for this new functionality was omitted.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: fix child trace events accounting

2017-12-14T08:25:44+00:00

Child trace events were included in calculation of the overall total,
which is used for calculation of the percentages of the '%Total' column.
However, the parent trace envents' stats summarize the child trace
events, hence we'd incorrectly account for them twice, leading to
slightly wrong stats.
With this fix, we use the correct total. Consequently, the sum of the
child trace events' '%Total' column values is identical to the
respective value of the respective parent event. However, this also
means that the sum of the '%Total' column values will aggregate to more
than 100 percent.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: fix extra handling of 'help' with fields filter

2017-12-14T08:25:43+00:00

Commit 67fbcd62f54d ("tools/kvm_stat: add '-f help' to get the available
event list") added support for '-f help'. However, the extra handling of
'help' will also take effect when 'help' is specified as a regex in
interactive mode via 'f'. This results in display of all events while
only those matching this regex should be shown.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: fix missing field update after filter change

2017-12-14T08:25:42+00:00

When updating the fields filter, tracepoint events of fields previously
not visible were not enabled, as TracepointProvider.update_fields()
updated the member variable directly instead of using the setter, which
triggers the event enable/disable.
To reproduce, run 'kvm_stat -f kvm_exit', press 'c' to remove the
filter, and notice that no add'l fields that do not match the regex
'kvm_exit' will appear.
This issue was introduced by commit c469117df059 ("tools/kvm_stat:
simplify initializers").

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini

tools/kvm_stat: fix drilldown in events-by-guests mode

2017-12-14T08:25:42+00:00

When displaying debugfs events listed by guests, an attempt to switch to
reporting of stats for individual child trace events results in garbled
output. Reason is that when toggling drilldown, the update of the stats
doesn't honor when events are displayed by guests, as indicated by
Tui._display_guests.
To reproduce, run 'kvm_stat -d' and press 'b' followed by 'x'.

Signed-off-by: Stefan Raspl 
Signed-off-by: Paolo Bonzini