linux.git/tools/bpf, branch v4.16-rc2

tools: bpftool: add bash completion for cgroup commands

2018-02-08T10:59:50+00:00

Add bash completion for "bpftool cgroup" command family. While at it,
also fix the formatting of some keywords in the man page for cgroups.

Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
Signed-off-by: Quentin Monnet 
Reviewed-by: Jakub Kicinski 
Signed-off-by: Daniel Borkmann

tools: bpftool: add bash completion for `bpftool prog load`

2018-02-08T10:59:50+00:00

Add bash completion for bpftool command `prog load`. Completion for this
command is easy, as it only takes existing file paths as arguments.

Fixes: 49a086c201a9 ("bpftool: implement prog load command")
Signed-off-by: Quentin Monnet 
Reviewed-by: Jakub Kicinski 
Signed-off-by: Daniel Borkmann

tools: bpftool: make syntax for program map update explicit in man page

2018-02-08T10:59:50+00:00

Specify in the documentation that when using bpftool to update a map of
type BPF_MAP_TYPE_PROG_ARRAY, the syntax for the program used as a value
should use the "id|tag|pinned" keywords convention, as used with
"bpftool prog" commands.

Fixes: ff69c21a85a4 ("tools: bpftool: add documentation")
Signed-off-by: Quentin Monnet 
Reviewed-by: Jakub Kicinski 
Signed-off-by: Daniel Borkmann

tools: bpftool: exit doc Makefile early if rst2man is not available

2018-02-08T10:59:50+00:00

If rst2man is not available on the system, running `make doc` from the
bpftool directory fails with an error message. However, it creates empty
manual pages (.8 files in this case). A subsequent call to `make
doc-install` would then succeed and install those empty man pages on the
system.

To prevent this, raise a Makefile error and exit immediately if rst2man
is not available before generating the pages from the rst documentation.

Fixes: ff69c21a85a4 ("tools: bpftool: add documentation")
Reported-by: Jason van Aaardt 
Signed-off-by: Quentin Monnet 
Reviewed-by: Jakub Kicinski 
Signed-off-by: Daniel Borkmann

bpftool: recognize BPF_MAP_TYPE_CPUMAP maps

2018-01-19T22:16:52+00:00

Add BPF_MAP_TYPE_CPUMAP map type to the list
of map type recognized by bpftool and define
corresponding text representation.

Signed-off-by: Roman Gushchin 
Cc: Quentin Monnet 
Cc: Jakub Kicinski 
Cc: Daniel Borkmann 
Cc: Alexei Starovoitov 
Acked-by: Quentin Monnet 
Signed-off-by: Daniel Borkmann

tools: bpftool: report device information for offloaded maps

2018-01-18T21:54:25+00:00

Print the information about device on which map is created.

Signed-off-by: Jakub Kicinski 
Signed-off-by: Daniel Borkmann

tools/bpf_jit_disasm: silence a static checker warning

2018-01-18T21:15:37+00:00

There is a static checker warning that "proglen" has an upper bound but
no lower bound.  The allocation will just fail harmlessly so it's not a
big deal.

Signed-off-by: Dan Carpenter 
Signed-off-by: Daniel Borkmann

tools: bpftool: improve architecture detection by using ifindex

2018-01-18T00:26:15+00:00

The current architecture detection method in bpftool is designed for host
case.

For offload case, we can't use the architecture of "bpftool" itself.
Instead, we could call the existing "ifindex_to_name_ns" to get DEVNAME,
then read pci id from /sys/class/dev/DEVNAME/device/vendor, finally we map
vendor id to bfd arch name which will finally be used to select bfd backend
for the disassembler.

Reviewed-by: Jakub Kicinski 
Signed-off-by: Jiong Wang 
Acked-by: Alexei Starovoitov 
Signed-off-by: Daniel Borkmann

tools: bpftool: add -DPACKAGE when including bfd.h

2018-01-17T00:15:05+00:00

bfd.h is requiring including of config.h except when PACKAGE or
PACKAGE_VERSION are defined.

  /* PR 14072: Ensure that config.h is included first.  */
  #if !defined PACKAGE && !defined PACKAGE_VERSION
  #error config.h must be included before this header
  #endif

This check has been introduced since May-2012. It doesn't show up in bfd.h
on some Linux distribution, probably because distributions have remove it
when building the package.

However, sometimes the user might just build libfd from source code then
link bpftool against it. For this case, bfd.h will be original that we need
to define PACKAGE or PACKAGE_VERSION.

Acked-by: Jakub Kicinski 
Signed-off-by: Jiong Wang 
Signed-off-by: Daniel Borkmann

bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-16T01:49:49+00:00

Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
so the prog show command prints the numeric type value:

$ bpftool prog show
1: type 15  name bpf_prog1  tag ac9f93dbfd6d9b74
	loaded_at Jan 15/07:58  uid 0
	xlated 96B  jited 105B  memlock 4096B

This patch defines the corresponding textual representation:

$ bpftool prog show
1: cgroup_device  name bpf_prog1  tag ac9f93dbfd6d9b74
	loaded_at Jan 15/07:58  uid 0
	xlated 96B  jited 105B  memlock 4096B

Signed-off-by: Roman Gushchin 
Cc: Jakub Kicinski 
Cc: Quentin Monnet 
Cc: Daniel Borkmann 
Cc: Alexei Starovoitov 
Acked-by: Jakub Kicinski 
Signed-off-by: Daniel Borkmann