linux.git/sound/usb/format.c, branch v3.13

ALSA: usb-audio: store protocol version in struct audioformat

2013-06-27T19:59:47+00:00

Instead of reading bInterfaceProtocol from the descriptor whenever it's
needed, store this value in the audioformat structure.  Besides
simplifying some code, this will allow us to correctly handle vendor-
specific devices where the descriptors are marked with other values.

Signed-off-by: Clemens Ladisch

ALSA: pcm_format_to_bits strong-typed conversion

2013-04-29T11:36:15+00:00

Add a function to handle conversion from snd_pcm_format_t
to bitwise with proper typing.

Change such conversions to use this function and silence sparse
warnings.

Signed-off-by: Eldad Zack 
Signed-off-by: Takashi Iwai

ALSA: snd-usb: add quirks handler for DSD streams

2013-04-18T08:03:53+00:00

Unfortunately, none of the UAC standards provides a way to identify DSD
(Direct Stream Digital) formats. Hence, this patch adds a quirks
handler to identify USB interfaces that are capable of handling DSD.

That quirks handler can augment the already parsed formats bit-field,
by any of the new SNDRV_PCM_FMTBIT_DSD_{U8_U16} and setting the dsd_dop
flag in the audio format, if the driver should take care for the DOP
byte stuffing.

The only devices that are known to work with this are the ones with
a 'Playback Designs' vendor id.

Signed-off-by: Daniel Mack 
Signed-off-by: Takashi Iwai

ALSA: usb-audio: UAC2: do clock validity check earlier

2013-04-04T06:30:59+00:00

Move the check that parse_audio_format_rates_v2() do after
receiving the clock source entity ID directly into the find
function and add a validation flag to the function.

This patch does not introduce any logic flow change.

It is provided to allow introducing automatic clock switching
easier later. By moving this uac_clock_source_is_valid callsite,
2 additional callsites can be avoided.

Signed-off-by: Eldad Zack 
Signed-off-by: Takashi Iwai

ALSA: snd-usb: handle raw data format of UAC2 devices

2013-03-18T07:47:13+00:00

UAC2 compliant audio devices may announce the capability to transport
raw audio data on their endpoints. Catch this and handle it as
'special' stream on the ALSA side.

Signed-off-by: Daniel Mack 
Reported-by: Andreas Koch 
Signed-off-by: Takashi Iwai

ALSA: snd-usb: handle the bmFormats field as unsigned int

2013-03-18T07:47:04+00:00

This field may use up to 32 bits, so it should be handled as unsigned
int.

Signed-off-by: Daniel Mack 
Reported-by: Andreas Koch 
Signed-off-by: Takashi Iwai

ALSA: usb-audio: Return meaningful error codes instead of -1 in format.c

2012-11-21T10:31:52+00:00

Also, silences the following smatch warning:
sound/usb/format.c:170 parse_audio_format_rates_v1() warn:
returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Sachin Kamat 
Signed-off-by: Takashi Iwai

ALSA: usb-audio: avoid integer overflow in create_fixed_stream_quirk()

2012-02-15T13:58:15+00:00

A malicious USB device could feed in a large nr_rates value.  This would
cause the subsequent call to kmemdup() to allocate a smaller buffer than
expected, leading to out-of-bounds access.

This patch validates the nr_rates value and reuses the limit introduced
in commit 4fa0e81b ("ALSA: usb-audio: fix possible hang and overflow
in parse_uac2_sample_rate_range()").

Signed-off-by: Xi Wang 
Signed-off-by: Takashi Iwai

ALSA: usb-audio: fix possible hang and overflow in parse_uac2_sample_rate_range()

2012-01-08T15:03:12+00:00

A malicious USB device may feed in carefully crafted min/max/res values,
so that the inner loop in parse_uac2_sample_rate_range() could run for
a long time or even never terminate, e.g., given max = INT_MAX.

Also nr_rates could be a large integer, which causes an integer overflow
in the subsequent call to kmalloc() in parse_audio_format_rates_v2().
Thus, kmalloc() would allocate a smaller buffer than expected, leading
to a memory corruption.

To exploit the two vulnerabilities, an attacker needs physical access
to the machine to plug in a malicious USB device.

This patch makes two changes.

1) The type of "rate" is changed to unsigned int, so that the loop could
   stop once "rate" is larger than INT_MAX.

2) Limit nr_rates to 1024.

Suggested-by: Takashi Iwai 
Signed-off-by: Xi Wang 
Signed-off-by: Takashi Iwai

ALSA: usb-audio: increase control transfer timeout

2011-09-27T07:21:48+00:00

There are certain devices that are reportedly so slow that they need
more than 100 ms to handle control transfers.  Therefore, increase the
timeout in mixer(_quirks).c to 1000 ms.

The timeout parameter of snd_usb_ctl_msg() is now constant, so we can
drop it.

Reported-by: Felipe Balbi 
Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai