linux.git/sound/soc/sof/sof-of-dev.c, branch v6.7

ASoC: SOF: Convert to platform remove callback returning void

2023-10-10T18:21:04+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

The SOF platform drivers all use either sof_of_remove() or
sof_acpi_remove() which both return zero unconditionally. Change these
functions to return void and the drivers to use .remove_new(). There is
no semantical change.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Daniel Baluta 
Reviewed-by: AngeloGioacchino Del Regno 
Link: https://lore.kernel.org/r/20231009155945.285537-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown

ASoC: SOF: Use generic names for IPC types

2023-09-19T12:49:08+00:00

Use the new SOF_IPC_TYPE_3, SOF_IPC_TYPE_4 in core code.

No functional changes, just renaming.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Daniel Baluta 
Reviewed-by: Rander Wang 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20230919104226.32239-5-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: add IPC-dependent file names

2022-04-19T11:03:34+00:00

To avoid misleading file names, use different names for INTEL_IPC4
firmware files.

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Bard Liao 
Reviewed-by: Rander Wang 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Chao Song 
Link: https://lore.kernel.org/r/20220414184817.362215-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: add path indirection to each IPC type

2022-04-19T11:03:32+00:00

With the addition of the IPCv4, we need the ability to select
different paths for firmware and topologies.

First add an indirection. Follow-up patches will add mechanisms to
select a default IPC or override it.

No functionality change in this patch.

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Bard Liao 
Reviewed-by: Rander Wang 
Reviewed-by: Péter Ujfalusi 
Link: https://lore.kernel.org/r/20220414184817.362215-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: OF: Add shutdown callback for SOF OF device

2022-04-07T17:29:44+00:00

Add shutdown callback function for SOF OF device and call
snd_sof_device_shutdown in sof_of_shutdown callback for DSP
shutdown sequence.

Signed-off-by: YC Hung 
Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Péter Ujfalusi 
Link: https://lore.kernel.org/r/20220406194048.289787-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: OF: Avoid reverse module dependency

2021-12-15T14:02:50+00:00

Similar with commit 8a49cd11e68ed0 ("ASoC: SOF: ACPI: avoid reverse
module dependency") we will be having hardware specific drivers that
link against a common "helper" framework.

sof-of-dev.c becomes a library with the interface defined in the newly
created file sof-of-dev.h.

This is the final step started with Kconfig simplification in
commit 7548a391c53ca ("ASoC: SOF: i.MX: simplify Kconfig")

Signed-off-by: Daniel Baluta 
Reviewed-by: Paul Olaru 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20211215085703.137414-1-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: Remove pm_runtime_put_autosuspend() for SOF OF device

2021-12-14T13:22:16+00:00

In SOF OF device, pm_runtime_put_autosuspend() is not
matching any pm_runtime_get_sync().

This is imbalanced for PM runtime.

Also, for consistency we call pm_runtime_mark_last_busy()
before enabling PM runtime.

1. Remove pm_runtime_put_autosuspend() in probe_complete
2. Reorder PM runtime calls int probe_complete

Signed-off-by: Allen-KH Cheng 
Reviewed-by: Daniel Baluta 
Reviewed-by: Paul Olaru 
Reviewed-by: Pierre-Louis Bossart 
Signed-off-by: Daniel Baluta 
Link: https://lore.kernel.org/r/20211209200830.145005-1-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: Add mt8195 device descriptor

2021-11-18T13:57:40+00:00

Add SOF device and DT descriptor for Mediatek mt8195 platform.

Signed-off-by: YC Hung 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Daniel Baluta 
Signed-off-by: Daniel Baluta 
Link: https://lore.kernel.org/r/20211118100749.54628-6-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: OF: Add fw_path and tplg_path parameters

2021-10-05T12:09:59+00:00

This allows specifying an alternate path for SOF firmware or
SOF topology.

This is particularly useful for i.MX when running Linux vs Android.

Signed-off-by: Daniel Baluta 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20211005071949.1277613-1-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: add header file for ops

2021-09-28T12:16:24+00:00

Sparse (make C=2) complains about undeclared variables. Fix by adding
a real prototype instead of 'extern' in sof-of-dev.c

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Daniel Baluta 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Paul Olaru 
Signed-off-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20210928072807.27838-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown