linux.git/sound/soc/sof/ipc4.c, branch v6.8

ASoC: SOF: ipc4: Move window offset configuration earlier

2023-11-29T13:25:26+00:00

With the added exception handling support if the firmware fails to boot
up we are trying to do a panic dump from the telemetry slot. The slot
offsets would have been configured only after receiving the FW_READY
message which makes this panic dump unusable for early boot failures.

With IPC4 the DSP window offsets are at standard places unlike IPC3 where
the offsets needs to be queried from the FW_READY message.

Move the offset configuration to sof_ipc4_init from the fw_ready handler.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Bard Liao 
Reviewed-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20231129122805.10635-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: check return value of snd_sof_ipc_msg_data

2023-11-29T13:25:25+00:00

snd_sof_ipc_msg_data could return error.

Signed-off-by: Bard Liao 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Signed-off-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20231129122021.679-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: Handle ALSA kcontrol change notification from firmware

2023-11-24T15:38:01+00:00

The control change notification is sent as module notification with a
standardized event_id (higher 16 bit is 0xA15A).
Add generic code to handle the module notification and invoke the control
update callback if the notification is an ALSA kcontrol change message.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20231124150853.18648-5-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: Dump the notification payload

2023-10-12T19:28:11+00:00

Now that we have notifications with payload (kcontrol change
notifications), it is time to add the payload dump on the rx path as well.

Reviewed-by: Seppo Ingalsuo 
Reviewed-by: Ranjani Sridharan 
Signed-off-by: Peter Ujfalusi 
Signed-off-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20231012191850.147140-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: handle EXCEPTION_CAUGHT notification from firmware

2023-09-19T12:48:52+00:00

Driver will receive exception IPC message and process it by
snd_sof_dsp_panic.

Signed-off-by: Rander Wang 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Guennadi Liakhovetski 
Signed-off-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20230919092416.4137-10-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: add exception node in sof debugfs directory

2023-09-19T12:48:48+00:00

The exception node is created when FW is ready and clear to
zero when FW post boot.

Signed-off-by: Rander Wang 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Guennadi Liakhovetski 
Signed-off-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20230919092416.4137-6-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: add a helper function to search debug slot

2023-09-19T12:48:46+00:00

Currently IPC4 supports GDB slot, telemetry slot and
debug slot. This helper function will be used to get
the slot offset in debug windows for further processing.

Signed-off-by: Rander Wang 
Reviewed-by: Péter Ujfalusi 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Guennadi Liakhovetski 
Signed-off-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20230919092416.4137-4-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4/Intel: Implement split fw library

2023-09-15T18:03:35+00:00

Merge series from Peter Ujfalusi :

This series implements support for split library loading to comply with the HDA
DMA programming sequence recommendation, which is:
1. DSP side DMA programming and GEN bit set to 1
2. host side DMA programming and RUN bit set to 1

The SOF support for library loading is based on this sequence, backwards
compatibility with older reference firmware is supported (where only the
LOAD_LIBRARY message is supported).

ASoC: SOF: ipc4: Add new message type: SOF_IPC4_GLB_LOAD_LIBRARY_PREPARE

2023-09-15T12:15:33+00:00

On Intel platforms there is a strict order requirement for the DMA
programming:
DSP side configures the buffer and sets the GEN bit
Host side sets the RUN bit.

In order to follow this flow, a new global message type has been added to
prepare the DSP side of the DMA:

host sends LOAD_LIBRARY_PREPARE with the dma_id
DSP side sets its buffer and sets the GEN bit
Host sets the RUN bit
Host sends LOAD_LIBRARY with dma_id and lib_id
DSP receives the library data.

It is up to the platform code to use the new prepare stage message and how
to handle the reply to it from the firmware, which can indicate that the
message type is not supported/handled.
In this case the kernel should proceed to the LOAD_LIBRARY stage assuming
a single stage library loading:

host sends LOAD_LIBRARY_PREPARE with the dma_id
DSP replies that the message type is not supported/handled
Host acknowledges the return code and sets the RUN bit
Host sends LOAD_LIBRARY with dma_id and lib_id
DSP receives the library data.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Chao Song 
Link: https://lore.kernel.org/r/20230915114018.1701-4-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: ipc4: Convert status code 2 and 15 to -EOPNOTSUPP

2023-09-15T12:15:31+00:00

The status code 2 and 15 can be translated to -EOPNOTSUPP, so convert them
to a meaningful error number.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Chao Song 
Link: https://lore.kernel.org/r/20230915114018.1701-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown