linux.git/sound/soc/sof/intel, branch v5.8

ASoC: Intel: SOF: merge COMETLAKE_LP and COMETLAKE_H

2020-06-17T19:01:00+00:00

We already have two configurations for CometLake, and a third one
coming. On other platforms, we used a single Kconfig option, so we
should follow the same trend by merging the two cases in a backwards
compatible way.

The backwards compatibility is handled by overloading the COMETLAKE_LP
kconfig as COMETLAKE. In practice we've never seen a case where
COMETLAKE_H is not selected along with COMETLAKE_LP, so keeping one
of the two is enough.

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Kai Vehmanen 
Link: https://lore.kernel.org/r/20200617164755.18104-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: hda: Clear RIRB status before reading WP

2020-06-15T14:18:34+00:00

Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading
WP") from legacy HDA driver to fix the get response timeout issue.
Current SOF driver does not suffer from this issue because sync write
is enabled in hda_init. The issue will come back if the sync write is
disabled for some reason.

Signed-off-by: Brent Lu 
Reviewed-by: Takashi Iwai 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/1591959048-15813-1-git-send-email-brent.lu@intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: hda: fix generic hda codec support

2020-05-29T17:18:02+00:00

Add support for using generic codec driver with SOF. Generic driver
is used if:
 - snd_sof_intel_hda_common.hda_model="generic" is set, or
 - fallback if no other codec driver is found

The implementation is aligned with snd-hda-intel driver, and fixes audio
support for systems like Acer Swift 3 SF314-57G, on which this issue was
originally reported.

Signed-off-by: Kai Vehmanen 
Reviewed-by: Hui Wang 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Pierre-Louis Bossart 
BugLink: https://github.com/thesofproject/linux/issues/1807
BugLink: https://bugs.launchpad.net/bugs/1877757
Link: https://lore.kernel.org/r/20200529160358.12134-1-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: Baytrail: fix 'defined but not used' warnings

2020-05-29T15:55:31+00:00

With the allmodconfig option, CONFIG_SND_SOC_SOF_BAYTRAIL is disabled
due to mutual exclusion with the legacy driver. This generates
'defined by not used' warnings.

suspend/resume/remove are only supported for Baytrail for now, so move
the code under the CONFIG_SND_SOC_SOF_BAYTRAIL checks.

Fixes: ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks")
Reported-by: Stephen Rothwell 
Signed-off-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20200529150408.17236-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: BYT: harden IPC initialization and handling

2020-05-27T13:06:59+00:00

On probe and reset, we should not touch the SHIM_IMRD register since
it is configured by firmware.

The driver only configures SHIM_IMRX with the BUSY interrupt enabled
by default and DONE interrupt disabled. When sending an IPC message,
the DONE interrupt is enabled until the DSP response is provided.

This sequence hardens the IPC communication and avoid
interrupt-related issues when adding/removing modules or during system
suspend-resume transitions.

Signed-off-by: Keyon Jie 
Signed-off-by: Pierre-Louis Bossart 
Tested-by: Enric Balletbo i Serra 
Reviewed-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20200526203640.25980-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: BYT: mask BUSY or DONE interrupts in handler

2020-05-27T13:06:58+00:00

The DSP may send the same interrupt multiple times before it's handled
in the interrupt thread. Rather than masking it in the thread, mask it
in the handler directly.

This patch also removes useless checks that cannot happen, and masks
that are set don't need to be re-tested.

Suggested-by: Keyon Jie 
Signed-off-by: Pierre-Louis Bossart 
Tested-by: Enric Balletbo i Serra 
Reviewed-by: Ranjani Sridharan 
BugLink: https://github.com/thesofproject/linux/issues/1492
Link: https://lore.kernel.org/r/20200526203640.25980-8-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: BYT: add .remove op

2020-05-27T13:06:58+00:00

Add .remove op that disables interrupts and reset the DSP
for BYT and CHT platforms.

Signed-off-by: Ranjani Sridharan 
Signed-off-by: Pierre-Louis Bossart 
Tested-by: Enric Balletbo i Serra 
Link: https://lore.kernel.org/r/20200526203640.25980-7-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: byt: Add PM callbacks

2020-05-27T13:06:53+00:00

Add the PM callbacks for BYT/CHT platforms.

Signed-off-by: Ranjani Sridharan 
Signed-off-by: Pierre-Louis Bossart 
Tested-by: Enric Balletbo i Serra 
Link: https://lore.kernel.org/r/20200526203640.25980-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: loader: Adjust validation condition for fw_offset

2020-05-25T13:59:33+00:00

Condition in if statement should be same as trace message
and FW size equal to zero (after skipping offset) should
be marked as invalid.

Signed-off-by: Karol Trzcinski 
Signed-off-by: Kai Vehmanen 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20200520165911.21696-2-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: sdw: relax sdw machine select constraints

2020-05-18T12:24:56+00:00

On some platforms such as Up Extreme all links are enabled but only one
link can be used by external codec. Instead of exact match of two masks,
first check whether link_mask of mach is subset of link_mask supported
by hw and then go on searching link_adr.

Signed-off-by: randerwang 
Signed-off-by: Pierre-Louis Bossart 
Signed-off-by: Kai Vehmanen 
Reviewed-by: Guennadi Liakhovetski 
Link: https://lore.kernel.org/r/20200515135958.17511-6-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown