linux.git/sound/soc/sof/intel/hda-trace.c, branch v6.7

ASoC: SOF: Modify the host trace_init parameter list to include dmab

2022-05-19T15:44:17+00:00

Stop host code (AMD, Intel) to access sdev->dmatb directly.
Modify the trace_init prototype to include the pointer to a
struct snd_dma_buffer. The ipc3-dtrace passes for now the pointer to
sdev->dmatb, but the aim is to move all tracing related runtime information
local to a trace implementation.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Paul Olaru 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Bard Liao 
Reviewed-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20220516104711.26115-7-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: hdac_ext_stream: consistent prefixes for variables/members

2022-02-09T14:36:14+00:00

The existing code maximizes confusion by using 'stream' and 'hstream'
variables of different types, e.g:

struct hdac_stream *stream;
struct hdac_ext_stream *stream;
struct hdac_stream *hstream;
struct hdac_ext_stream *hstream;

This confusion is partly inherited from legacy code but SOF
contributors added their own creative spin, e.g.

struct hdac_ext_stream *link_dev;
struct hdac_ext_stream *dsp_stream;
struct hdac_ext_stream hda_stream;

and my personal favorite:

stream = &hda_stream->hda_stream;

This patch suggests a consistent naming across all Intel code related
to HDAudio stream management. The convention is - by hierarchical
order:

struct sof_intel_hda_stream *hda_stream;
struct hdac_ext_stream *hext_stream;
struct hdac_stream *hstream;

No functionality change - just renaming of variables/members.

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Rander Wang 
Signed-off-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20220209063104.9971-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: dma-trace: Pass pointer to params_ext struct in trace_init()

2022-02-08T13:38:04+00:00

Instead of passing a pointer to the stream_tag within the
struct sof_ipc_dma_trace_params_ext, pass the pointer to the containing
struct.

AMD needs to update buffer.phy_addr (and don't really use the stream_tag)
for the trace implementation.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20220128123623.23569-3-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: intel: hda-trace: Pass the dma buffer pointer to hda_dsp_trace_prepare

2022-02-08T13:38:03+00:00

Pass the snd_dma_buffer pointer as parameter to hda_dsp_trace_prepare()
function.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20220128123623.23569-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: fix string format for errors

2021-02-10T17:17:11+00:00

These are negative error return values, printing them as hex is annoying
and not beneficial. Switch back to signed type to make error lookup
simpler.

Reviewed-by: Kai Vehmanen 
Reviewed-by: Daniel Baluta 
Reviewed-by: Guennadi Liakhovetski 
Signed-off-by: Curtis Malainey 
Signed-off-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20210208232149.58899-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: hda: Enable DMI L1 for trace

2021-01-27T13:06:49+00:00

Enabling DMI L1 for capture streams could result in xruns during
pause/release. As pause/release is not a valid scenario for trace,
we can safely enable DMI L1 for it.

Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Kai Vehmanen 
Signed-off-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20210127020737.1088960-3-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: hda: enable DMI L1 for D0i3-compatible streams

2021-01-27T13:06:49+00:00

DMI L1 entry is currently disabled whenever any capture stream is
opened to prevent xruns during pause/release. But, in
order to maximise power savings for the wake-on-voice usecase,
DMI L1 entry should be enabled for D0i3-compatible capture streams.
Introduce a new field, flags in struct sof_intel_hda_stream
that stores whether a stream is dmi_l1_compatible. All playback streams,
and D0i3-compatible capture streams are DMI L1 compatible.

Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Kai Vehmanen 
Signed-off-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20210127020737.1088960-2-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only

2020-05-01T16:45:24+00:00

Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
tag.

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Daniel Baluta 
Reviewed-by: Kai Vehmanen 
Reviewed-by: Guennadi Liakhovetski 
Link: https://lore.kernel.org/r/20200501145850.15178-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: Add Intel specific HDA trace operations

2019-04-27T17:51:23+00:00

Add trace operations for Intel based HDA DSPs

Signed-off-by: Keyon Jie 
Signed-off-by: Liam Girdwood 
Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Takashi Iwai 
Signed-off-by: Mark Brown