linux.git/sound/oss, branch v4.5

sound/oss: remove VIRT_TO_BUS dependency

2015-12-09T13:40:51+00:00

The OSS sound drivers used to rely on virt_to_bus(), but don't any more,
so we can remove the Kconfig dependency.

As a lot of architectures don't provide VIRT_TO_BUS any more, removing
the dependency in sounds/oss/ would make the deprecated drivers appear
there, which we probably don't want. Instead I'm replacing the
simple dependency with 'VIRT_TO_BUS || RPC || NETWINDER' so we can
still build these sound drivers for the platforms that need them,
but don't change anything on other architectures.

As a follow-up, we can remove the virt_to_bus() implementation
and Kconfig symbol in the ARM architecture.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Takashi Iwai

sound: oss/sb_audio: use swap() in sb_audio_close()

2015-06-12T18:46:29+00:00

Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick 
Signed-off-by: Takashi Iwai

sound/oss: use schedule_timeout_interruptible()

2015-05-29T15:26:32+00:00

API consolidation with coccinelle found:
./sound/oss/msnd_pinnacle.c:1292:2-18:
        consolidation with schedule_timeout_*() recommended

This is a 1:1 conversion of the current calls to an available helper
only - so only an API consolidation to improve readability.

Patch was compile tested with x86_64_defconfig

Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Signed-off-by: Nicholas Mc Guire 
Signed-off-by: Takashi Iwai

sound: oss: fix build warning

2015-05-18T08:27:17+00:00

while building with allyesconfig it was giving a build warning about
unused variable. declare the variable only if the driver is built as a
module.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Takashi Iwai

sound/oss: fix deadlock in sequencer_ioctl(SNDCTL_SEQ_OUTOFBAND)

2015-04-18T07:05:55+00:00

A deadlock can be initiated by userspace via ioctl(SNDCTL_SEQ_OUTOFBAND)
on /dev/sequencer with TMR_ECHO midi event.

In this case the control flow is:
sound_ioctl()
-> case SND_DEV_SEQ:
   case SND_DEV_SEQ2:
     sequencer_ioctl()
     -> case SNDCTL_SEQ_OUTOFBAND:
          spin_lock_irqsave(&lock,flags);
          play_event();
          -> case EV_TIMING:
               seq_timing_event()
               -> case TMR_ECHO:
                    seq_copy_to_input()
                    -> spin_lock_irqsave(&lock,flags);

It seems that spin_lock_irqsave() around play_event() is not necessary,
because the only other call location in seq_startplay() makes the call
without acquiring spinlock.

So, the patch just removes spinlocks around play_event().
By the way, it removes unreachable code in seq_timing_event(),
since (seq_mode == SEQ_2) case is handled in the beginning.

Compile tested only.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Takashi Iwai

sound: Deparenthesize negative error returns

2015-03-24T10:41:37+00:00

Make the returns a bit more kernel standard style.

Signed-off-by: Joe Perches 
Signed-off-by: Takashi Iwai

sound/sb_midi: a couple indenting fixes

2015-02-25T19:08:27+00:00

Let's make things line up a little bit better.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

sound/sb_ess: white space cleanups

2015-02-25T19:08:21+00:00

These weren't aligned on the same lines as the surrounding code and the
printk was quite messy.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

sound/oss/opl3: remove some stray whitespace

2015-02-25T19:08:15+00:00

Removed an extra tab and a extra space character.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

sound: sys_timer: indent poll_def_tmr() correctly

2015-02-25T19:08:07+00:00

The indenting here was really whacky and not consistent from one line to
the next.  I also reverse the "if (opened)" and "if (tmr_running)" tests
so that I could remove two indent levels.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai