linux.git/sound/hda/hdmi_chmap.c, branch vsnprintf

ALSA: hda: Add input value sanity checks to HDMI channel map controls

2024-06-18T10:00:19+00:00

Add a simple sanity check to HD-audio HDMI Channel Map controls.
Although the value might not be accepted for the actual connection, we
can filter out some bogus values beforehand, and that should be enough
for making kselftest happier.

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai 
Link: https://lore.kernel.org/20240616073454.16512-7-tiwai@suse.de

ALSA: hda: Replace runtime->status->state reference to runtime->state

2022-09-27T06:47:33+00:00

The recent change in ALSA core allows drivers to get the current PCM
state directly from runtime object.  Replace the calls accordingly.

Reviewed-by: Jaroslav Kysela 
Link: https://lore.kernel.org/r/20220926135558.26580-6-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: hda: Use scnprintf() for printing texts for sysfs/procfs

2020-02-18T09:15:41+00:00

Some code in HD-audio driver calls snprintf() in a loop and still
expects that the return value were actually written size, while
snprintf() returns the expected would-be length instead.  When the
given buffer limit were small, this leads to a buffer overflow.

Use scnprintf() for addressing those issues.  It returns the actually
written size unlike snprintf().

Cc: 
Link: https://lore.kernel.org/r/20200218091409.27162-1-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: hda: More constifications

2020-01-05T15:14:32+00:00

Apply const prefix to the remaining possible places: the string
tables, the rate tables, the verb tables, the index tables, etc.

Just for minor optimization and no functional changes.

Link: https://lore.kernel.org/r/20200105144823.29547-10-tiwai@suse.de
Signed-off-by: Takashi Iwai

treewide: Add SPDX license identifier for missed files

2019-05-21T08:50:45+00:00

Add SPDX license identifiers to all files which:

 - Have no license information of any form

 - Have EXPORT_.*_SYMBOL_GPL inside which was used in the
   initial scan/conversion to ignore the file

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

ALSA: hda: Fix too short HDMI/DP chmap reporting

2017-11-17T11:20:37+00:00

We got a regression report about the HD-audio HDMI chmap, where some
surround channels are reported as UNKNOWN.  The git bisection pointed
the culprit at the commit 9b3dc8aa3fb1 ("ALSA: hda - Register chmap
obj as priv data instead of codec").  The story behind scene is like
this:

- While moving the code out of the legacy HDA to the HDA common place,
  the patch modifies the code to obtain the chmap array indirectly in
  a byte array, and it expands it to kctl value array.
- At the latter operation, the size of the array is wrongly passed by
  sizeof() to the pointer.
- It can be 4 on 32bit arch, thus too short for 6+ channels.
  (And that's the reason why it didn't hit other persons; it's 8 on
  64bit arch, thus it's usually enough.)

The code was further changed meanwhile, but the problem persisted.
Let's fix it by correctly evaluating the array size.

Fixes: 9b3dc8aa3fb1 ("ALSA: hda - Register chmap obj as priv data instead of codec")
Reported-by: VDR User 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: hda: fix some klockwork scan warnings

2016-06-16T08:10:12+00:00

This patch fixes some warnings from klockwork.

These warnings are not the real issues. The patch
adds the sanity check.

Signed-off-by: Libin Yang 
Signed-off-by: Takashi Iwai

ALSA: hda - Update chmap tlv to report sink's capability

2016-04-04T14:04:24+00:00

The existing TLV callback implementation copies all of the
cea_channel_speaker_allocation map table to the TLV container
irrespective of what is reported by sink. This is of little use
to the userspace application.

With this patch, it parses the spk_alloc block as queried from
the ELD, and copies only the corresponding mapping channel
allocation entries from the cea channel speaker allocation table.
Thus the user can parse the TLV container to identify sink's
capability and set the channel map accordingly.

It shouldn't impact the behavior in AMD chipset, as this makes
use of already parsed spk alloc block to calculate the channel
map.

Signed-off-by: Subhransu S. Prusty 
Signed-off-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: hda - Use snd_hdac namespace prefix for chmap exported APIs

2016-03-07T14:46:06+00:00

Signed-off-by: Subhransu S. Prusty 
Signed-off-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: hda - Move chmap support helpers/ops to core

2016-03-07T14:45:29+00:00

Chmap helpers, ops, controls are moved to core.

Signed-off-by: Subhransu S. Prusty 
Signed-off-by: Vinod Koul 
Signed-off-by: Takashi Iwai