linux.git/sound/core/seq, branch v3.19

ALSA: seq-dummy: remove deadlock-causing events on close

2015-01-26T12:53:13+00:00

When the last subscriber to a "Through" port has been removed, the
subscribed destination ports might still be active, so it would be
wrong to send "all sounds off" and "reset controller" events to them.
The proper place for such a shutdown would be the closing of the actual
MIDI port (and close_substream() in rawmidi.c already can do this).

This also fixes a deadlock when dummy_unuse() tries to send events to
its own port that is already locked because it is being freed.

Reported-by: Peter Billam 
Cc: 
Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: core: Deletion of unnecessary checks before two function calls

2014-11-21T19:06:57+00:00

The functions snd_seq_oss_timer_delete() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Takashi Iwai

Subject: ALSA: seq: Remove autoload locks in driver registration

2014-10-18T18:25:19+00:00

Since we're calling request_module() asynchronously now, we can get
rid of the autoload lock in snd_seq_device_register_driver(), as well
as in the snd-seq driver registration itself.  This enables the
automatic loading of dependent sequencer modules, such as
snd-seq-virmidi from snd-emu10k1-synth.

Signed-off-by: Takashi Iwai

ALSA: seq: bind seq driver automatically

2014-10-18T18:25:12+00:00

Currently the sequencer module binding is performed independently from
the card module itself.  The reason behind it is to keep the sequencer
stuff optional and allow the system running without it (e.g. for using
PCM or rawmidi only).  This works in most cases, but a remaining
problem is that the binding isn't done automatically when a new driver
module is probed.  Typically this becomes visible when a hotplug
driver like usb audio is used.

This patch tries to address this and other potential issues.  First,
the seq-binder (seq_device.c) tries to load a missing driver module at
creating a new device object.  This is done asynchronously in a workq
for avoiding the deadlock (modprobe call in module init path).

This action, however, should be enabled only when the sequencer stuff
was already initialized, i.e. snd-seq module was already loaded.  For
that, a new function, snd_seq_autoload_init() is introduced here; this
clears the blocking of autoloading, and also tries to load all pending
driver modules.

Reported-by: Adam Goode 
Signed-off-by: Takashi Iwai

ALSA: seq: Use atomic ops for autoload refcount

2014-10-15T12:00:16+00:00

... just to robustify for races.

Signed-off-by: Takashi Iwai

ALSA: seq: seq_memory.c: Fix closing brace followed by if

2014-06-23T15:58:33+00:00

Add a newline and, while at it, remove a space and redundant braces.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Takashi Iwai

ALSA: seq: Continue broadcasting events to ports if one of them fails

2014-06-04T15:30:58+00:00

Sometimes PORT_EXIT messages are lost when a process is exiting.
This happens if you subscribe to the announce port with client A,
then subscribe to the announce port with client B, then kill client A.
Client B will not see the PORT_EXIT message because client A's port is
closing and is earlier in the announce port subscription list. The
for each loop will try to send the announcement to client A and fail,
then will stop trying to broadcast to other ports. Killing B works fine
since the announcement will already have gone to A. The CLIENT_EXIT
message does not get lost.

How to reproduce problem:

*** termA
$ aseqdump -p 0:1
  0:1   Port subscribed            0:1 -> 128:0

*** termB
$ aseqdump -p 0:1

*** termA
  0:1   Client start               client 129
  0:1   Port start                 129:0
  0:1   Port subscribed            0:1 -> 129:0

*** termB
  0:1   Port subscribed            0:1 -> 129:0

*** termA
^C

*** termB
  0:1   Client exit                client 128
   <--- expected Port exit as well (before client exit)

Signed-off-by: Adam Goode 
Signed-off-by: Takashi Iwai

ALSA: seq: correctly detect input buffer overflow

2014-06-04T05:12:12+00:00

snd_seq_event_dup returns -ENOMEM in some buffer-full conditions,
but usually returns -EAGAIN. Make -EAGAIN trigger the overflow
condition in snd_seq_fifo_event_in so that the fifo is cleared
and -ENOSPC is returned to userspace as stated in the alsa-lib docs.

Signed-off-by: Adam Goode 
Signed-off-by: Takashi Iwai

ALSA: core: Fix format string mismatch in seq_midi.c

2014-04-28T10:18:47+00:00

Fix format string mismatch in snd_seq_midisynth_register_port().
Argument type of p is unsigned int.

Signed-off-by: Masanari Iida 
Signed-off-by: Takashi Iwai

ALSA: seq_oss: Use standard printk helpers

2014-02-14T07:14:18+00:00

Use the standard pr_xxx() helpers instead of home-baked snd_print*().

Signed-off-by: Takashi Iwai