linux.git/security/apparmor/policy.c, branch v3.11

apparmor: Fix smatch warning in aa_remove_profiles

2013-04-28T07:39:34+00:00

smatch reports
  error: potential NULL dereference 'ns'.

this can not actually occur because it relies on aa_split_fqname setting
both ns_name and name as null but ns_name will actually always have a
value in this case.

so remove the unnecessary if (ns_name) conditional that is resulting
in the false positive further down.

Signed-off-by: John Johansen

apparmor: move the free_profile fn ahead of aa_alloc_profile

2013-04-28T07:37:24+00:00

Move the free_profile fn ahead of aa_alloc_profile so it can be used
in aa_alloc_profile without a forward declaration.

Signed-off-by: John Johansen 
Acked-by: Kees Cook

apparmor: remove sid from profiles

2013-04-28T07:37:13+00:00

The sid is not going to be a direct property of a profile anymore, instead
it will be directly related to the label, and the profile will pickup
a label back reference.

For null-profiles replace the use of sid with a per namespace unique
id.

Signed-off-by: John Johansen 
Acked-by: Kees Cook

apparmor: fix IRQ stack overflow during free_profile

2012-10-24T15:12:50+00:00

BugLink: http://bugs.launchpad.net/bugs/1056078

Profile replacement can cause long chains of profiles to build up when
the profile being replaced is pinned. When the pinned profile is finally
freed, it puts the reference to its replacement, which may in turn nest
another call to free_profile on the stack. Because this may happen for
each profile in the replacedby chain this can result in a recusion that
causes the stack to overflow.

Break this nesting by directly walking the chain of replacedby profiles
(ie. use iteration instead of recursion to free the list). This results
in at most 2 levels of free_profile being called, while freeing a
replacedby chain.

Signed-off-by: John Johansen 
Signed-off-by: James Morris

Merge branch 'master' of git://git.infradead.org/users/eparis/selinux into next

2012-05-22T01:21:06+00:00

Per pull request, for 3.5.

apparmor: fix profile lookup for unconfined

2012-05-18T18:09:28+00:00

BugLink: http://bugs.launchpad.net/bugs/978038

also affects apparmor portion of
BugLink: http://bugs.launchpad.net/bugs/987371

The unconfined profile is not stored in the regular profile list, but
change_profile and exec transitions may want access to it when setting
up specialized transitions like switch to the unconfined profile of a
new policy namespace.

Signed-off-by: John Johansen

LSM: do not initialize common_audit_data to 0

2012-04-09T16:23:04+00:00

It isn't needed.  If you don't set the type of the data associated with
that type it is a pretty obvious programming bug.  So why waste the cycles?

Signed-off-by: Eric Paris

LSM: remove the COMMON_AUDIT_DATA_INIT type expansion

2012-04-09T16:23:01+00:00

Just open code it so grep on the source code works better.

Signed-off-by: Eric Paris

LSM: shrink sizeof LSM specific portion of common_audit_data

2012-04-03T16:48:40+00:00

Linus found that the gigantic size of the common audit data caused a big
perf hit on something as simple as running stat() in a loop.  This patch
requires LSMs to declare the LSM specific portion separately rather than
doing it in a union.  Thus each LSM can be responsible for shrinking their
portion and don't have to pay a penalty just because other LSMs have a
bigger space requirement.

Signed-off-by: Eric Paris 
Signed-off-by: Linus Torvalds

AppArmor: add const qualifiers to string arrays

2012-03-15T02:09:13+00:00

Signed-off-by: Jan Engelhardt 
Signed-off-by: John Johansen