linux.git/scripts/mod/modpost.c, branch v6.13-rc4

modpost: distinguish same module paths from different dump files

2024-12-21T03:42:10+00:00

Since commit 13b25489b6f8 ("kbuild: change working directory to external
module directory with M="), module paths are always relative to the top
of the external module tree.

The module paths recorded in Module.symvers are no longer globally unique
when they are passed via KBUILD_EXTRA_SYMBOLS for building other external
modules, which may result in false-positive "exported twice" errors.
Such errors should not occur because external modules should be able to
override in-tree modules.

To address this, record the dump file path in struct module and check it
when searching for a module.

Fixes: 13b25489b6f8 ("kbuild: change working directory to external module directory with M=")
Reported-by: Jon Hunter 
Closes: https://lore.kernel.org/all/eb21a546-a19c-40df-b821-bbba80f19a3d@nvidia.com/
Signed-off-by: Masahiro Yamada 
Tested-by: Jon Hunter

modpost: Add .irqentry.text to OTHER_SECTIONS

2024-12-08T08:11:34+00:00

The compiler can fully inline the actual handler function of an interrupt
entry into the .irqentry.text entry point. If such a function contains an
access which has an exception table entry, modpost complains about a
section mismatch:

  WARNING: vmlinux.o(__ex_table+0x447c): Section mismatch in reference ...

  The relocation at __ex_table+0x447c references section ".irqentry.text"
  which is not in the list of authorized sections.

Add .irqentry.text to OTHER_SECTIONS to cure the issue.

Reported-by: Sergey Senozhatsky 
Signed-off-by: Thomas Gleixner 
Cc: stable@vger.kernel.org # needed for linux-5.4-y
Link: https://lore.kernel.org/all/20241128111844.GE10431@google.com/
Signed-off-by: Masahiro Yamada

modpost: replace tdb_hash() with hash_str()

2024-11-27T23:46:03+00:00

Use a helper available in scripts/include/hash.h.

Signed-off-by: Masahiro Yamada

modpost: move strstarts() to modpost.h

2024-11-27T23:46:02+00:00

This macro is useful in file2alias.c as well.

Signed-off-by: Masahiro Yamada

modpost: introduce module_alias_printf() helper

2024-11-27T23:42:58+00:00

The generic ->do_entry() handler is currently limited to returning
a single alias string.

However, this is not flexible enough for several subsystems, which
currently require their own implementations:

 - do_usb_table()
 - do_of_table()
 - do_pnp_device_entry()
 - do_pnp_card_entries()

This commit introduces a helper function so that these special cases can
add multiple MODULE_ALIAS() and then migrate to the generic framework.

Signed-off-by: Masahiro Yamada

kbuild: compile constant module information only once

2024-09-07T08:24:08+00:00

Various information about modules is compiled into the info sections.
For that a dedicated .mod.c file is generated by modpost for each module
and then linked into the module.
However most of the information in the .mod.c is the same for all
modules, internal and external.
Split the shared information into a dedicated source file that is
compiled once and then linked into all modules.

This avoids frequent rebuilds for all .mod.c files when using
CONFIG_LOCALVERSION_AUTO because the local version ends up in .mod.c
through UTS_RELEASE and VERMAGIC_STRING.
The modules are still relinked in this case.

The code is also easier to maintain as it's now in a proper source file
instead of an inline string literal.

Signed-off-by: Thomas Weißschuh 
Signed-off-by: Masahiro Yamada

modpost: simplify modpost_log()

2024-09-01T11:34:50+00:00

With commit cda5f94e88b4 ("modpost: avoid using the alias attribute"),
only two log levels remain: LOG_WARN and LOG_ERROR. Simplify this by
making it a boolean variable.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Nathan Chancellor

modpost: improve the section mismatch warning format

2024-09-01T11:34:49+00:00

This commit improves the section mismatch warning format when there is
no suitable symbol name to print.

The section mismatch warning prints the reference source in the form
of + and the reference destination in the form
of .

However, there are some corner cases where  becomes
"(unknown)", as reported in commit 23dfd914d2bf ("modpost: fix null
pointer dereference").

In such cases, it is better to print the symbol address.

Signed-off-by: Masahiro Yamada

modpost: replace the use of NOFAIL() with xmalloc() etc.

2024-09-01T11:34:48+00:00

I think x*alloc() functions are cleaner.

Signed-off-by: Masahiro Yamada

modpost: detect endianness on run-time

2024-09-01T11:33:32+00:00

Endianness is currently detected on compile-time, but we can defer this
until run-time. This change avoids re-executing scripts/mod/mk_elfconfig
even if modpost in the linux-headers package needs to be rebuilt for a
foreign architecture.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Nicolas Schier