linux.git/scripts/kallsyms.c, branch v5.6-rc2 Linux kernel source tree scripts/kallsyms: fix memory corruption caused by write over-run 2020-02-10T20:18:09+00:00 Masahiro Yamada masahiroy@kernel.org 2020-02-10T16:18:52+00:00 9d1b38958b077f6c8d4bd196a115b643d7bd6717 memcpy() writes one more byte than allocated. Fixes: 8d60526999aa ("scripts/kallsyms: change table to store (strcut sym_entry *)") Reported-by: youling257 <youling257@gmail.com> Reported-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Tested-by: Pavel Machek <pavel@ucw.cz> 
memcpy() writes one more byte than allocated.

Fixes: 8d60526999aa ("scripts/kallsyms: change table to store (strcut sym_entry *)")
Reported-by: youling257 <youling257@gmail.com>
Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Pavel Machek <pavel@ucw.cz>
scripts/kallsyms: change table to store (strcut sym_entry *) 2020-02-03T16:54:30+00:00 Masahiro Yamada masahiroy@kernel.org 2020-02-02T05:09:21+00:00 8d60526999aace135de37220ec94ba40bc792234 The symbol table is extended every 10000 addition by using realloc(), where data copy might occur to the new buffer. To decrease the amount of possible data copy, let's change the table to store the pointer. The symbol type + symbol name part is appended at the end of (struct sym_entry), and allocated together with the struct body. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
The symbol table is extended every 10000 addition by using realloc(),
where data copy might occur to the new buffer.

To decrease the amount of possible data copy, let's change the table
to store the pointer.

The symbol type + symbol name part is appended at the end of
(struct sym_entry), and allocated together with the struct body.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kallsyms: rename local variables in read_symbol() 2020-02-03T16:54:15+00:00 Masahiro Yamada masahiroy@kernel.org 2020-02-02T05:09:20+00:00 be9f6133f8770bb9c5f4a3cb3df6d30d7d3f7e5b I will use 'sym' for the point to struce sym_entry in the next commit. Rename 'sym', 'stype' to 'name', 'type', which are more intuitive. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
I will use 'sym' for the point to struce sym_entry in the next commit.
Rename 'sym', 'stype' to 'name', 'type', which are more intuitive.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kallsyms: fix offset overflow of kallsyms_relative_base 2019-12-14T06:53:04+00:00 Masahiro Yamada masahiroy@kernel.org 2019-12-09T03:51:48+00:00 fd2ab2f6610b2bec70e626c38de8a4242fa88e48 Since commit 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it"), kallsyms_relative_base can be larger than _text, which causes overflow when building the 32-bit kernel. https://lkml.org/lkml/2019/12/7/156 This is because _text is, unless --all-symbols is specified, now trimmed from the symbol table before record_relative_base() is called. Handle the offset signedness also for kallsyms_relative_base. Introduce a new helper, output_address(), to reduce the code duplication. Fixes: 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it") Reported-by: Olof Johansson <olof@lixom.net> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
Since commit 5e5c4fa78745 ("scripts/kallsyms: shrink table before
sorting it"), kallsyms_relative_base can be larger than _text, which
causes overflow when building the 32-bit kernel.

https://lkml.org/lkml/2019/12/7/156

This is because _text is, unless --all-symbols is specified, now
trimmed from the symbol table before record_relative_base() is called.

Handle the offset signedness also for kallsyms_relative_base. Introduce
a new helper, output_address(), to reduce the code duplication.

Fixes: 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it")
Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kallsyms: remove redundant initializers 2019-11-25T12:07:05+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:44+00:00 831362fc317ae60413879deacdcc9617d9ce9e20 These are set to zero without the explicit initializers. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
These are set to zero without the explicit initializers.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: put check_symbol_range() calls close together 2019-11-25T12:06:49+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:43+00:00 d44270fc976b6c3b9e742e398580e4af8c69f7bd Put the relevant code close together. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Put the relevant code close together.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: make check_symbol_range() void function 2019-11-25T12:06:37+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:42+00:00 b6233d0ded3391a33bb0047edafe15169131eadb There is no more reason to check the return value of check_symbol_range(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
There is no more reason to check the return value of
check_symbol_range().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: move ignored symbol types to is_ignored_symbol() 2019-11-25T12:06:14+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:41+00:00 887df76de67f5a6dd423e5763c22ff07f0e50048 Collect the ignored patterns to is_ignored_symbol(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Collect the ignored patterns to is_ignored_symbol().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: move more patterns to the ignored_prefixes array 2019-11-25T12:06:01+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:40+00:00 97261e1e2240f627e27e93f7e410be1a7c97c80a Refactoring for shortening the code. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Refactoring for shortening the code.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: skip ignored symbols very early 2019-11-25T12:04:57+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:39+00:00 a41333e06acd1b37f3a3248fb90cd417218f9439 Unless the address range matters, symbols can be ignored earlier, which avoids unneeded memory allocation. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Unless the address range matters, symbols can be ignored earlier,
which avoids unneeded memory allocation.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>