linux.git/scripts/kallsyms.c, branch v5.5-rc4 Linux kernel source tree scripts/kallsyms: fix offset overflow of kallsyms_relative_base 2019-12-14T06:53:04+00:00 Masahiro Yamada masahiroy@kernel.org 2019-12-09T03:51:48+00:00 fd2ab2f6610b2bec70e626c38de8a4242fa88e48 Since commit 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it"), kallsyms_relative_base can be larger than _text, which causes overflow when building the 32-bit kernel. https://lkml.org/lkml/2019/12/7/156 This is because _text is, unless --all-symbols is specified, now trimmed from the symbol table before record_relative_base() is called. Handle the offset signedness also for kallsyms_relative_base. Introduce a new helper, output_address(), to reduce the code duplication. Fixes: 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it") Reported-by: Olof Johansson <olof@lixom.net> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
Since commit 5e5c4fa78745 ("scripts/kallsyms: shrink table before
sorting it"), kallsyms_relative_base can be larger than _text, which
causes overflow when building the 32-bit kernel.

https://lkml.org/lkml/2019/12/7/156

This is because _text is, unless --all-symbols is specified, now
trimmed from the symbol table before record_relative_base() is called.

Handle the offset signedness also for kallsyms_relative_base. Introduce
a new helper, output_address(), to reduce the code duplication.

Fixes: 5e5c4fa78745 ("scripts/kallsyms: shrink table before sorting it")
Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kallsyms: remove redundant initializers 2019-11-25T12:07:05+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:44+00:00 831362fc317ae60413879deacdcc9617d9ce9e20 These are set to zero without the explicit initializers. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
These are set to zero without the explicit initializers.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: put check_symbol_range() calls close together 2019-11-25T12:06:49+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:43+00:00 d44270fc976b6c3b9e742e398580e4af8c69f7bd Put the relevant code close together. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Put the relevant code close together.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: make check_symbol_range() void function 2019-11-25T12:06:37+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:42+00:00 b6233d0ded3391a33bb0047edafe15169131eadb There is no more reason to check the return value of check_symbol_range(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
There is no more reason to check the return value of
check_symbol_range().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: move ignored symbol types to is_ignored_symbol() 2019-11-25T12:06:14+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:41+00:00 887df76de67f5a6dd423e5763c22ff07f0e50048 Collect the ignored patterns to is_ignored_symbol(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Collect the ignored patterns to is_ignored_symbol().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: move more patterns to the ignored_prefixes array 2019-11-25T12:06:01+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:40+00:00 97261e1e2240f627e27e93f7e410be1a7c97c80a Refactoring for shortening the code. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Refactoring for shortening the code.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: skip ignored symbols very early 2019-11-25T12:04:57+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:39+00:00 a41333e06acd1b37f3a3248fb90cd417218f9439 Unless the address range matters, symbols can be ignored earlier, which avoids unneeded memory allocation. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Unless the address range matters, symbols can be ignored earlier,
which avoids unneeded memory allocation.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: add const qualifiers where possible 2019-11-25T12:04:33+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:38+00:00 4bfe2b7816a6e97fba7b4125166b33db4b31d29d Add 'const' where a function does not write to the pointer dereferenes. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
Add 'const' where a function does not write to the pointer dereferenes.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: make find_token() return (unsigned char *) 2019-11-25T12:04:11+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:37+00:00 2558c138aca75e5fc435e20fd37f0b0eea61bb65 The callers of this function expect (unsigned char *). I do not see a good reason to make this function return (void *). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
The callers of this function expect (unsigned char *). I do not see
a good reason to make this function return (void *).

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kallsyms: replace prefix_underscores_count() with strspn() 2019-11-25T12:03:51+00:00 Masahiro Yamada yamada.masahiro@socionext.com 2019-11-23T16:04:36+00:00 aa915245005bdb45ccbc96964853b4a27646390f You can do equivalent things with strspn(). I do not see noticeable performance difference. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> 
You can do equivalent things with strspn(). I do not see noticeable
performance difference.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>