linux.git/net, branch v2.6.17

[IPV4]: Increment ipInHdrErrors when TTL expires.

2006-06-12T20:09:59+00:00

Signed-off-by: Weidong 
Signed-off-by: David S. Miller

[TCP]: continued: reno sacked_out count fix

2006-06-12T04:18:56+00:00

From: Aki M Nyrhinen 

IMHO the current fix to the problem (in_flight underflow in reno)
is incorrect.  it treats the symptons but ignores the problem. the
problem is timing out packets other than the head packet when we
don't have sack. i try to explain (sorry if explaining the obvious).

with sack, scanning the retransmit queue for timed out packets is
fine because we know which packets in our retransmit queue have been
acked by the receiver.

without sack, we know only how many packets in our retransmit queue the
receiver has acknowledged, but no idea which packets.

think of a "typical" slow-start overshoot case, where for example
every third packet in a window get lost because a router buffer gets
full.

with sack, we check for timeouts on those every third packet (as the
rest have been sacked). the packet counting works out and if there
is no reordering, we'll retransmit exactly the packets that were 
lost.

without sack, however, we check for timeout on every packet and end up
retransmitting consecutive packets in the retransmit queue. in our
slow-start example, 2/3 of those retransmissions are unnecessary. these
unnecessary retransmissions eat the congestion window and evetually
prevent fast recovery from continuing, if enough packets were lost.

Signed-off-by: David S. Miller

[DCCP] Ackvec: fix soft lockup in ackvec handling code

2006-06-12T04:08:03+00:00

A soft lockup existed in the handling of ack vector records.
Specifically, when a tail of the list of ack vector records was
removed, it was possible to end up iterating infinitely on an element
of the tail.

Signed-off-by: Andrea Bittau 
Signed-off-by: Ian McDonald 
Signed-off-by: David S. Miller

[BRIDGE]: fix locking and memory leak in br_add_bridge

2006-06-05T23:39:34+00:00

There are several bugs in error handling in br_add_bridge:
- when dev_alloc_name fails, allocated net_device is not freed
- unregister_netdev is called when rtnl lock is held
- free_netdev is called before netdev_run_todo has a chance to be run after
  unregistering net_device

Signed-off-by: Jiri Benc 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[IRDA]: Missing allocation result check in irlap_change_speed().

2006-06-05T22:34:52+00:00

The skb allocation may fail, which can result in a NULL pointer dereference
in irlap_queue_xmit().

Coverity CID: 434.

Signed-off-by: Florin Malita 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[NET]: Eliminate unused /proc/sys/net/ethernet

2006-06-05T22:34:11+00:00

The /proc/sys/net/ethernet directory has been sitting empty for more than
10 years!  Time to eliminate it!

Signed-off-by: Jes Sorensen 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[TCP]: Avoid skb_pull if possible when trimming head

2006-06-05T22:03:37+00:00

Trimming the head of an skb by calling skb_pull can cause the packet
to become unaligned if the length pulled is odd.  Since the length is
entirely arbitrary for a FIN packet carrying data, this is actually
quite common.

Unaligned data is not the end of the world, but we should avoid it if
it's easily done.  In this case it is trivial.  Since we're discarding
all of the head data it doesn't matter whether we move skb->data forward
or back.

However, it is still possible to have unaligned skb->data in general.
So network drivers should be prepared to handle it instead of crashing.

This patch also adds an unlikely marking on len < headlen since partial
ACKs on head data are extremely rare in the wild.  As the return value
of __pskb_trim_head is no longer ever NULL that has been removed.

Signed-off-by: Herbert Xu ~{PmV>HI~} 
Signed-off-by: David S. Miller

[TCP] tcp_highspeed: Fix problem observed by Xiaoliang (David) Wei

2006-06-03T00:51:08+00:00

When snd_cwnd is smaller than 38 and the connection is in
congestion avoidance phase (snd_cwnd > snd_ssthresh), the snd_cwnd
seems to stop growing.

The additive increase was confused because C array's are 0 based.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NETFILTER]: PPTP helper: fix sstate/cstate typo

2006-05-29T05:51:05+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NETFILTER]: mark H.323 helper experimental

2006-05-29T05:50:40+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller