linux.git/net/wireless/core.c, branch v2.6.37

Revert "wireless: Use first phyX name available when registering phy devices."

2010-10-11T18:46:52+00:00

This reverts commit 5a254ffe3ffdfa84fe076009bd8e88da412180d2.

The commit failed to take into account that allocated wireless devices
(wiphys) are not added into the device list upon allocation, but only
when they are registered. Therefore, it opened up a race between
allocating and registering a name, so that if two processes allocate and
register concurrently ("alloc, alloc, register, register" rather than
"alloc, register, alloc, register") the code will attempt to use the
same name twice.

Signed-off-by: Johannes Berg

wireless: Use first phyX name available when registering phy devices.

2010-10-05T17:35:21+00:00

Choose first available phyX name when creating phy devices.  This
means that reloading a wifi driver will not cause a change in the
name of it's phy device.

Also, allow users to rename a phy to any un-used name, including
phy%d.

Signed-off-by: Ben Greear 
Signed-off-by: John W. Linville

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6

2010-09-24T19:52:34+00:00

Conflicts:
	drivers/net/wireless/ath/ath5k/base.c
	net/mac80211/main.c

cfg80211/nl80211: introduce p2p device types

2010-09-16T19:46:06+00:00

This adds P2P-STA and P2P-GO as device types so
we can distinguish between those and normal STA
or AP (respectively) type interfaces.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

include/net/cfg80211.h: wiphy_ messages use dev_printk

2010-09-16T19:19:44+00:00

The output becomes:

[   41.261941] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'

Signed-off-by: Joe Perches 
Signed-off-by: John W. Linville

wireless: register wiphy rfkill w/o holding cfg80211_mutex

2010-08-31T18:48:47+00:00

Otherwise lockdep complains...

https://bugzilla.kernel.org/show_bug.cgi?id=17311

[ INFO: possible circular locking dependency detected ]
2.6.36-rc2-git4 #12
-------------------------------------------------------
kworker/0:3/3630 is trying to acquire lock:
 (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x12/0x14

but task is already holding lock:
 (rfkill_global_mutex){+.+.+.}, at: []
rfkill_switch_all+0x24/0x49 [rfkill]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #2 (rfkill_global_mutex){+.+.+.}:
       [] lock_acquire+0x120/0x15b
       [] __mutex_lock_common+0x54/0x52e
       [] mutex_lock_nested+0x34/0x39
       [] rfkill_register+0x2b/0x29c [rfkill]
       [] wiphy_register+0x1ae/0x270 [cfg80211]
       [] ieee80211_register_hw+0x1b4/0x3cf [mac80211]
       [] iwl_ucode_callback+0x9e9/0xae3 [iwlagn]
       [] request_firmware_work_func+0x54/0x6f
       [] kthread+0x8c/0x94
       [] kernel_thread_helper+0x4/0x10

-> #1 (cfg80211_mutex){+.+.+.}:
       [] lock_acquire+0x120/0x15b
       [] __mutex_lock_common+0x54/0x52e
       [] mutex_lock_nested+0x34/0x39
       [] cfg80211_get_dev_from_ifindex+0x1b/0x7c [cfg80211]
       [] cfg80211_wext_giwscan+0x58/0x990 [cfg80211]
       [] ioctl_standard_iw_point+0x1a8/0x272
       [] ioctl_standard_call+0x91/0xa7
       [] T.723+0xbd/0x12c
       [] wext_handle_ioctl+0x31/0x6d
       [] dev_ioctl+0x63d/0x67a
       [] sock_ioctl+0x48/0x21d
       [] do_vfs_ioctl+0x4ba/0x509
       [] sys_ioctl+0x51/0x74
       [] system_call_fastpath+0x16/0x1b

-> #0 (rtnl_mutex){+.+.+.}:
       [] __lock_acquire+0xa93/0xd9a
       [] lock_acquire+0x120/0x15b
       [] __mutex_lock_common+0x54/0x52e
       [] mutex_lock_nested+0x34/0x39
       [] rtnl_lock+0x12/0x14
       [] cfg80211_rfkill_set_block+0x1a/0x7b [cfg80211]
       [] rfkill_set_block+0x80/0xd5 [rfkill]
       [] __rfkill_switch_all+0x3f/0x6f [rfkill]
       [] rfkill_switch_all+0x38/0x49 [rfkill]
       [] rfkill_op_handler+0x105/0x136 [rfkill]
       [] process_one_work+0x248/0x403
       [] worker_thread+0x139/0x214
       [] kthread+0x8c/0x94
       [] kernel_thread_helper+0x4/0x10

Signed-off-by: John W. Linville 
Acked-by: Johannes Berg

cfg80211/mac80211: extensible frame processing

2010-08-24T20:27:56+00:00

Allow userspace to register for more than just
action frames by giving the frame subtype, and
make it possible to use this in various modes
as well.

With some tweaks and some added functionality
this will, in the future, also be usable in AP
mode and be able to replace the cooked monitor
interface currently used in that case.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

cfg80211: support sysfs namespaces

2010-08-16T19:26:40+00:00

Enable using network namespaces with
wireless devices even when sysfs is
enabled using the same infrastructure
that was built for netdevs.

Signed-off-by: Johannes Berg 
Acked-by: "Eric W. Biederman" 
Signed-off-by: John W. Linville

wireless: Convert wiphy_debug macro to function

2010-07-27T19:14:13+00:00

Save a few bytes of text

(allyesconfig)
$ size drivers/net/wireless/built-in.o*
   text	   data	    bss	    dec	    hex	filename
3924568	 100548	 871056	4896172	 4ab5ac	drivers/net/wireless/built-in.o.new
3926520	 100548	 871464	4898532	 4abee4	drivers/net/wireless/built-in.o.old

$ size net/wireless/core.o*
   text	   data	    bss	    dec	    hex	filename
  12843	    216	   3768	  16827	   41bb	net/wireless/core.o.new
  12328	    216	   3656	  16200	   3f48	net/wireless/core.o

Signed-off-by: Joe Perches 
Signed-off-by: John W. Linville

cfg80211: fix race between sysfs and cfg80211

2010-07-21T19:13:42+00:00

device_add() is called before adding the phy to the cfg80211 device
list.

So if a userspace program uses sysfs uevents to detect new phy
devices, and queries nl80211 to get phy info, it can get ENODEV even
though the phy exists in sysfs.

An easy workaround is to hold the cfg80211 mutex until the phy is
present in sysfs/cfg80211/debugfs.

Signed-off-by: Maxime Bizon 
Signed-off-by: John W. Linville