linux.git/net/tls/tls_device_fallback.c, branch v6.8

tls: rename MAX_IV_SIZE to TLS_MAX_IV_SIZE

2023-10-13T10:26:09+00:00

It's defined in include/net/tls.h, avoid using an overly generic name.

Signed-off-by: Sabrina Dubroca 
Signed-off-by: David S. Miller

tls: drop unnecessary cipher_type checks in tls offload

2023-10-13T10:26:09+00:00

We should never reach tls_device_reencrypt, tls_enc_record, or
tls_enc_skb with a cipher_type that can't be offloaded. Replace those
checks with a DEBUG_NET_WARN_ON_ONCE, and use cipher_desc instead of
hard-coding offloadable cipher types.

Signed-off-by: Sabrina Dubroca 
Signed-off-by: David S. Miller

tls: get salt using crypto_info_salt in tls_enc_skb

2023-10-13T10:26:09+00:00

I skipped this conversion in my previous series.

Signed-off-by: Sabrina Dubroca 
Signed-off-by: David S. Miller

tls: expand use of tls_cipher_desc in tls_sw_fallback_init

2023-08-28T00:17:42+00:00

tls_sw_fallback_init already gets the key and tag size from
tls_cipher_desc. We can now also check that the cipher type is valid,
and stop hard-coding the algorithm name passed to crypto_alloc_aead.

Signed-off-by: Sabrina Dubroca 
Link: https://lore.kernel.org/r/c8c94b8fcafbfb558e09589c1f1ad48dbdf92f76.1692977948.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski

tls: allocate the fallback aead after checking that the cipher is valid

2023-08-28T00:17:42+00:00

No need to allocate the aead if we're going to fail afterwards.

Signed-off-by: Sabrina Dubroca 
Link: https://lore.kernel.org/r/335e32511ed55a0b30f3f81a78fa8f323b3bdf8f.1692977948.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski

tls: rename tls_cipher_size_desc to tls_cipher_desc

2023-08-28T00:17:41+00:00

We're going to add other fields to it to fully describe a cipher, so
the "_size" name won't match the contents.

Signed-off-by: Sabrina Dubroca 
Link: https://lore.kernel.org/r/76ca6c7686bd6d1534dfa188fb0f1f6fabebc791.1692977948.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski

tls: reduce size of tls_cipher_size_desc

2023-08-28T00:17:41+00:00

tls_cipher_size_desc indexes ciphers by their type, but we're not
using indices 0..50 of the array. Each struct tls_cipher_size_desc is
20B, so that's a lot of unused memory. We can reindex the array
starting at the lowest used cipher_type.

Introduce the get_cipher_size_desc helper to find the right item and
avoid out-of-bounds accesses, and make tls_cipher_size_desc's size
explicit so that gcc reminds us to update TLS_CIPHER_MIN/MAX when we
add a new cipher.

Signed-off-by: Sabrina Dubroca 
Link: https://lore.kernel.org/r/5e054e370e240247a5d37881a1cd93a67c15f4ca.1692977948.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski

net/tls: fix comment typo

2023-06-23T02:38:46+00:00

Spell "retransmit" properly.

Found by searching for keyword "tranm".

Signed-off-by: Yueh-Shun Li 
Link: https://lore.kernel.org/r/20230622012627.15050-7-shamrocklee@posteo.net
Signed-off-by: Jakub Kicinski

net/tls: Fix memory leak in tls_enc_skb() and tls_sw_fallback_init()

2022-11-12T04:08:17+00:00

'aead_req' and 'aead_send' is allocated but not freed in default switch
case. This commit fixes the potential memory leak by freeing them under
the situation.

Note that the default cases here should never be reached as they'd
mean we allowed offloading an unsupported algorithm.

Fixes: ea7a9d88ba21 ("net/tls: Use cipher sizes structs")
Signed-off-by: Yu Liao 
Reviewed-by: Gal Pressman 
Link: https://lore.kernel.org/r/20221110090329.2036382-1-liaoyu15@huawei.com
Signed-off-by: Jakub Kicinski

net/tls: Support 256 bit keys with TX device offload

2022-09-23T00:27:42+00:00

Add the missing clause for 256 bit keys in tls_set_device_offload(), and
the needed adjustments in tls_device_fallback.c.

Reviewed-by: Tariq Toukan 
Signed-off-by: Gal Pressman 
Signed-off-by: Jakub Kicinski