linux.git/net/tipc/link.c, branch v2.6.26

[TIPC]: Enhance validation of format on incoming messages

2008-04-16T02:04:54+00:00

This patch ensures that TIPC properly handles incoming messages
that have incorrect or unexpected formats.  Most significantly,
it now ensures that each sl_buff has at least as much data as
the message header indicates it should, and that the entire
message header is stored contiguously; this prevents TIPC from
accidentally accessing memory that is not part of the sk_buff.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

[TIPC]: Force linearization of non-linear sk_buffs

2008-04-16T02:03:23+00:00

This patch allows TIPC to process incoming messages that are
stored in a fragmented sk_buff, by forcing the linearization
of any such messages it receives.

Note: This is an interim solution to allow TIPC to operate with
Ethernet devices that generate non-linear buffers (such as the
gianfar driver), until such time as the rest of TIPC is enhanced
to handle sk_buffs with multiple data areas.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

[TIPC]: Minor cleanup of message header code

2008-03-06T23:06:55+00:00

This patch eliminates some unused or duplicate message header
symbols, and fixes up the comments and/or location of a few
other symbols.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

tipc: fix integer as NULL pointer sparse warnings in tipc

2008-02-25T02:38:31+00:00

net/tipc/cluster.c:145:2: warning: Using plain integer as NULL pointer
net/tipc/link.c:3254:36: warning: Using plain integer as NULL pointer
net/tipc/ref.c:151:15: warning: Using plain integer as NULL pointer
net/tipc/zone.c:85:2: warning: Using plain integer as NULL pointer

Signed-off-by: Harvey Harrison 
Signed-off-by: David S. Miller

[TIPC]: Fix two minor sparse warnings.

2007-08-03T02:42:31+00:00

fix two warnings generated by sparse:

link.c:2386 symbol 'msgcount' shadows an earlier one
node.c:244 symbol 'addr_string' shadows an earlier one

Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller

[TIPC]: fix tipc_link_create error handling

2007-07-31T09:28:02+00:00

if printbuf allocation or tipc_node_attach_link() fails, invalid
references to the link are left in the associated node and bearer
structures.
Fix by allocating printbuf early and moving timer initialization
and the addition of the new link to the b_ptr->links list after
tipc_node_attach_link() succeeded.

Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller

[TIPC]: Optimize stream send routine to avoid fragmentation

2007-07-11T05:06:12+00:00

This patch enhances TIPC's stream socket send routine so that
it avoids transmitting data in chunks that require fragmentation
and reassembly, thereby improving performance at both the
sending and receiving ends of the connection.

The "maximum packet size" hint that records MTU info allows
the socket to decide how big a chunk it should send; in the
event that the hint has become stale, fragmentation may still
occur, but the data will be passed correctly and the hint will
be updated in time for the following send.  Note: The 66060 byte
pseudo-MTU used for intra-node connections requires the send
routine to perform an additional check to ensure it does not
exceed TIPC"s limit of 66000 bytes of user data per chunk.

Signed-off-by: Allan Stephens 
Signed-off-by: Jon Paul Maloy 
Signed-off-by: David S. Miller

[NET]: cleanup extra semicolons

2007-04-26T05:29:24+00:00

Spring cleaning time...

There seems to be a lot of places in the network code that have
extra bogus semicolons after conditionals.  Most commonly is a
bogus semicolon after: switch() { }

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}

2007-04-26T05:28:29+00:00

To clearly state the intent of copying to linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.

Signed-off-by: Arnaldo Carvalho de Melo

[NET] TIPC: Fix whitespace errors.

2007-02-11T07:20:15+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller