linux.git/net/tipc/link.c, branch v2.6.23

[TIPC]: Fix two minor sparse warnings.

2007-08-03T02:42:31+00:00

fix two warnings generated by sparse:

link.c:2386 symbol 'msgcount' shadows an earlier one
node.c:244 symbol 'addr_string' shadows an earlier one

Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller

[TIPC]: fix tipc_link_create error handling

2007-07-31T09:28:02+00:00

if printbuf allocation or tipc_node_attach_link() fails, invalid
references to the link are left in the associated node and bearer
structures.
Fix by allocating printbuf early and moving timer initialization
and the addition of the new link to the b_ptr->links list after
tipc_node_attach_link() succeeded.

Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller

[TIPC]: Optimize stream send routine to avoid fragmentation

2007-07-11T05:06:12+00:00

This patch enhances TIPC's stream socket send routine so that
it avoids transmitting data in chunks that require fragmentation
and reassembly, thereby improving performance at both the
sending and receiving ends of the connection.

The "maximum packet size" hint that records MTU info allows
the socket to decide how big a chunk it should send; in the
event that the hint has become stale, fragmentation may still
occur, but the data will be passed correctly and the hint will
be updated in time for the following send.  Note: The 66060 byte
pseudo-MTU used for intra-node connections requires the send
routine to perform an additional check to ensure it does not
exceed TIPC"s limit of 66000 bytes of user data per chunk.

Signed-off-by: Allan Stephens 
Signed-off-by: Jon Paul Maloy 
Signed-off-by: David S. Miller

[NET]: cleanup extra semicolons

2007-04-26T05:29:24+00:00

Spring cleaning time...

There seems to be a lot of places in the network code that have
extra bogus semicolons after conditionals.  Most commonly is a
bogus semicolon after: switch() { }

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}

2007-04-26T05:28:29+00:00

To clearly state the intent of copying to linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.

Signed-off-by: Arnaldo Carvalho de Melo

[NET] TIPC: Fix whitespace errors.

2007-02-11T07:20:15+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[TIPC]: Remove code bloat introduced by print buffer rework

2006-10-19T02:55:18+00:00

This patch allows the compiler to optimize out any code that tries to
send debugging output to the null print buffer (TIPC_NULL), a capability
that was unintentionally broken during the recent print buffer rework.

Signed-off-by: Allan Stephens 
Signed-off-by: Per Liden 
Signed-off-by: David S. Miller

[TIPC]: fix printk warning

2006-10-04T07:31:03+00:00

gcc spits out this warning:

net/tipc/link.c: In function ‘link_retransmit_failure’:
net/tipc/link.c:1669: warning: cast from pointer to integer of different
size

More than a little bit ugly, storing integers in void*, but at least the
code is correct, unlike some of the more crufty Linux kernel code found
elsewhere.

Rather than having two casts to massage the value into u32, it's easier
just to have a single cast and use "%lu", since it's just a printk.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[NET]: Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-21T21:51:30+00:00

Signed-off-by: Panagiotis Issaris 
Signed-off-by: David S. Miller

[TIPC] Fixed sk_buff panic caused by tipc_link_bundle_buf (REVISED)

2006-07-04T02:39:36+00:00

The recent change to direct inspection of bundle buffer tailroom did not
account for the possiblity of unrequested tailroom added by skb_alloc(),
thereby allowing a bundle to be created that exceeds the current link MTU.
An additional check now ensures that bundling works correctly no matter
if the bundle buffer is smaller, larger, or equal to the link MTU.

Signed-off-by: Allan Stephens 
Signed-off-by: Per Liden 
Signed-off-by: David S. Miller