linux.git/net/sunrpc/cache.c, branch v2.6.35

Merge branch 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing

2010-05-24T15:01:10+00:00

* 'bkl/ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing:
  uml: Pushdown the bkl from harddog_kern ioctl
  sunrpc: Pushdown the bkl from sunrpc cache ioctl
  sunrpc: Pushdown the bkl from ioctl
  autofs4: Pushdown the bkl from ioctl
  uml: Convert to unlocked_ioctls to remove implicit BKL
  ncpfs: BKL ioctl pushdown
  coda: Clean-up whitespace problems in pioctl.c
  coda: BKL ioctl pushdown
  drivers: Push down BKL into various drivers
  isdn: Push down BKL into ioctl functions
  scsi: Push down BKL into ioctl functions
  dvb: Push down BKL into ioctl functions
  smbfs: Push down BKL into ioctl function
  coda/psdev: Remove BKL from ioctl function
  um/mmapper: Remove BKL usage
  sn_hwperf: Kill BKL usage
  hfsplus: Push down BKL into ioctl function

sunrpc: Pushdown the bkl from sunrpc cache ioctl

2010-05-22T15:44:20+00:00

Pushdown the bkl to cache_ioctl_pipefs.

Signed-off-by: Frederic Weisbecker 
Cc: "J. Bruce Fields" 
Cc: Neil Brown 
Cc: Nfs 
Cc: Thomas Gleixner 
Cc: John Kacur 
Cc: Arnd Bergmann

Merge branch 'for-2.6.35' of git://linux-nfs.org/~bfields/linux

2010-05-20T00:24:54+00:00

* 'for-2.6.35' of git://linux-nfs.org/~bfields/linux: (45 commits)
  Revert "nfsd4: distinguish expired from stale stateids"
  nfsd: safer initialization order in find_file()
  nfs4: minor callback code simplification, comment
  NFSD: don't report compiled-out versions as present
  nfsd4: implement reclaim_complete
  nfsd4: nfsd4_destroy_session must set callback client under the state lock
  nfsd4: keep a reference count on client while in use
  nfsd4: mark_client_expired
  nfsd4: introduce nfs4_client.cl_refcount
  nfsd4: refactor expire_client
  nfsd4: extend the client_lock to cover cl_lru
  nfsd4: use list_move in move_to_confirmed
  nfsd4: fold release_session into expire_client
  nfsd4: rename sessionid_lock to client_lock
  nfsd4: fix bare destroy_session null dereference
  nfsd4: use local variable in nfs4svc_encode_compoundres
  nfsd: further comment typos
  sunrpc: centralise most calls to svc_xprt_received
  nfsd4: fix unlikely race in session replay case
  nfsd4: fix filehandle comment
  ...

sunrpc: Include missing smp_lock.h

2010-05-17T01:06:31+00:00

Now that cache_ioctl_procfs() calls the bkl explicitly, we need to
include the relevant header as well.

This fixes the following build error:

	net/sunrpc/cache.c: In function 'cache_ioctl_procfs':
	net/sunrpc/cache.c:1355: error: implicit declaration of function 'lock_kernel'
	net/sunrpc/cache.c:1359: error: implicit declaration of function 'unlock_kernel'

Reported-by: Stephen Rothwell 
Signed-off-by: Frederic Weisbecker

procfs: Push down the bkl from ioctl

2010-05-17T01:06:12+00:00

Push down the bkl from procfs's ioctl main handler to its users.
Only three procfs users implement an ioctl (non unlocked) handler.
Turn them into unlocked_ioctl and push down the Devil inside.

v2: PDE(inode)->data doesn't need to be under bkl
v3: And don't forget to git-add the result
v4: Use wrappers to pushdown instead of an invasive and error prone
    handlers surgery.

Signed-off-by: Frederic Weisbecker 
Acked-by: Arnd Bergmann 
Cc: Thomas Gleixner 
Cc: Andrew Morton 
Cc: Ingo Molnar 
Cc: John Kacur 
Cc: KAMEZAWA Hiroyuki 
Cc: Al Viro 
Cc: Alexey Dobriyan

sunrpc/cache: fix module refcnt leak in a failure path

2010-03-24T14:40:46+00:00

Don't forget to release the module refcnt if seq_open() returns failure.

Signed-off-by: Li Zefan 
Cc: J. Bruce Fields 
Cc: Neil Brown 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: J. Bruce Fields

sunrpc: never return expired entries in sunrpc_cache_lookup

2010-03-15T01:48:52+00:00

If sunrpc_cache_lookup finds an expired entry, remove it from
the cache and return a freshly created non-VALID entry instead.
This ensures that we only ever get a usable entry, or an
entry that will become usable once an update arrives.
i.e. we will never need to repeat the lookup.

This allows us to remove the 'is_expired' test from cache_check
(i.e. from cache_is_valid).  cache_check should never get an expired
entry as 'lookup' will never return one.  If it does happen - due to
inconvenient timing - then just accept it as still valid, it won't be
very much past it's use-by date.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

sunrpc/cache: factor out cache_is_expired

2010-03-14T22:08:37+00:00

This removes a tiny bit of code duplication, but more important
prepares for following patch which will perform the expiry check in
cache_lookup and the rest of the validity check in cache_check.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

sunrpc: don't keep expired entries in the auth caches.

2010-03-14T22:03:54+00:00

currently expired entries remain in the auth caches as long
as there is a reference.
This was needed long ago when the auth_domain cache used the same
cache infrastructure.  But since that (being a very different sort
of cache) was separated, this test is no longer needed.

So remove the test on refcnt and tidy up the surrounding code.

This allows the cache_dequeue call (which needed to be there to
drop a potentially awkward reference) can be moved outside of the
spinlock which is a better place for it.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

net: Move && and || to end of previous line

2009-11-30T00:55:45+00:00

Not including net/atm/

Compiled tested x86 allyesconfig only
Added a > 80 column line or two, which I ignored.
Existing checkpatch plaints willfully, cheerfully ignored.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller