linux.git/net/sunrpc/cache.c, branch v2.6.31

sunrpc: align cache_clean work's timer

2009-06-16T01:14:58+00:00

Align cache_clean work.

Signed-off-by: Anton Blanchard 
Cc: Neil Brown 
Cc: Trond Myklebust 
Cc: "David S. Miller" 
Signed-off-by: Andrew Morton 
Acked-by: David S. Miller 
Signed-off-by: J. Bruce Fields

proc 2/2: remove struct proc_dir_entry::owner

2009-03-30T21:14:44+00:00

Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan

SUNRPC: The sunrpc server code should not be used by out-of-tree modules

2009-01-07T22:18:42+00:00

Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

sunrpc: assign PDE->data before gluing PDE into /proc tree

2008-05-02T09:44:36+00:00

Simply replace proc_create and further data assigned with proc_create_data.

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

svcrpc: move unused field from cache_deferred_req

2008-04-23T20:13:37+00:00

This field is set once and never used; probably some artifact of an
earlier implementation idea.

Signed-off-by: J. Bruce Fields

[SUNRPC]: Use proc_create() to setup ->proc_fops first

2008-02-28T22:00:59+00:00

Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen 
Signed-off-by: David S. Miller

SUNRPC: Move exported symbol definitions after function declaration part 2

2008-02-01T22:01:24+00:00

Do it for the server code...

Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

knfsd: allow cache_register to return error on failure

2008-02-01T21:42:05+00:00

Newer server features such as nfsv4 and gss depend on proc to work, so a
failure to initialize the proc files they need should be treated as
fatal.

Thanks to Andrew Morton for style fix and compile fix in case where
CONFIG_NFSD_V4 is undefined.

Cc: Andrew Morton 
Acked-by: NeilBrown 
Signed-off-by: J. Bruce Fields

nfsd: move cache proc (un)registration to separate function

2008-02-01T21:42:04+00:00

Just some minor cleanup.

Also I don't see much point in trying to register further proc entries
if initial entries fail; so just stop trying in that case.

Acked-by: NeilBrown 
Signed-off-by: J. Bruce Fields

knfsd: cache unregistration needn't return error

2008-02-01T21:42:04+00:00

There's really nothing much the caller can do if cache unregistration
fails.  And indeed, all any caller does in this case is print an error
and continue.  So just return void and move the printk's inside
cache_unregister.

Acked-by: NeilBrown 
Signed-off-by: J. Bruce Fields