linux.git/net/sctp, branch v2.6.26

sctp: Mark the tsn as received after all allocations finish

2008-07-08T09:28:39+00:00

If we don't have the buffer space or memory allocations fail,
the data chunk is dropped, but TSN is still reported as received.
This introduced a data loss that can't be recovered.  We should
only mark TSNs are received after memory allocations finish.
The one exception is the invalid stream identifier, but that's
due to user error and is reported back to the user.

This was noticed by Michael Tuexen.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: Make sure N * sizeof(union sctp_addr) does not overflow.

2008-06-21T05:04:34+00:00

As noticed by Gabriel Campana, the kmalloc() length arg
passed in by sctp_getsockopt_local_addrs_old() can overflow
if ->addr_num is large enough.

Therefore, enforce an appropriate limit.

Signed-off-by: David S. Miller

sctp: Correclty set changeover_active for SFR-CACC

2008-06-17T00:00:29+00:00

Right now, any time we set a primary transport we set
the changeover_active flag.  As a result, we invoke SFR-CACC
even when there has been no changeover events.

Only set changeover_active, when there is a true changeover
event, i.e. we had a primary path and we are changing to
another transport.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: Correctly cleanup procfs entries upon failure.

2008-06-16T23:59:55+00:00

This patch remove the proc fs entry which has been created if fail to
set up proc fs entry for the SCTP protocol.

Signed-off-by: Wei Yongjun 
Acked-by: Neil Horman 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: Fix ECN markings for IPv6

2008-06-04T19:40:15+00:00

Commit e9df2e8fd8fbc95c57dbd1d33dada66c4627b44c ("[IPV6]: Use
appropriate sock tclass setting for routing lookup.") also changed the
way that ECN capable transports mark this capability in IPv6.  As a
result, SCTP was not marking ECN capablity because the traffic class
was never set.  This patch brings back the markings for IPv6 traffic.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: Flush the queue only once during fast retransmit.

2008-06-04T19:39:36+00:00

When fast retransmit is triggered by a sack, we should flush the queue
only once so that only 1 retransmit happens.  Also, since we could
potentially have non-fast-rtx chunks on the retransmit queue, we need
make sure any chunks eligable for fast retransmit are sent first
during fast retransmission.

Signed-off-by: Vlad Yasevich 
Tested-by: Wei Yongjun 
Signed-off-by: David S. Miller

sctp: Start T3-RTX timer when fast retransmitting lowest TSN

2008-06-04T19:39:11+00:00

When we are trying to fast retransmit the lowest outstanding TSN, we
need to restart the T3-RTX timer, so that subsequent timeouts will
correctly tag all the packets necessary for retransmissions.

Signed-off-by: Vlad Yasevich 
Tested-by: Wei Yongjun 
Signed-off-by: David S. Miller

sctp: Correctly implement Fast Recovery cwnd manipulations.

2008-06-04T19:38:43+00:00

Correctly keep track of Fast Recovery state and do not reduce
congestion window multiple times during sucht state.

Signed-off-by: Vlad Yasevich 
Tested-by: Wei Yongjun 
Signed-off-by: David S. Miller

sctp: Move sctp_v4_dst_saddr out of loop

2008-06-04T19:38:07+00:00

There's no need to execute sctp_v4_dst_saddr() for each
iteration, just move it out of loop.

Signed-off-by: Gui Jianfeng 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: retran_path update bug fix

2008-06-04T19:37:33+00:00

If the current retran_path is the only active one, it should
update it to the the next inactive one.

Signed-off-by: Gui Jianfeng 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller