linux.git/net/sctp/socket.c, branch v2.6.32

sctp: Fix regression introduced by new sctp_connectx api

2009-11-14T03:56:51+00:00

A new (unrealeased to the user) sctp_connectx api

c6ba68a26645dbc5029a9faa5687ebe6fcfc53e4
    sctp: support non-blocking version of the new sctp_connectx() API

introduced a regression cought by the user regression test
suite.  In particular, the API requires the user library to
re-allocate the buffer and could potentially trigger a SIGFAULT.

This change corrects that regression by passing the original
address buffer to the kernel unmodified, but still allows for
a returned association id.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: Set source addresses on the association before adding transports

2009-11-14T03:56:50+00:00

Recent commit 8da645e101a8c20c6073efda3c7cc74eec01b87f
	sctp: Get rid of an extra routing lookup when adding a transport
introduced a regression in the connection setup.  The behavior was

different between IPv4 and IPv6.  IPv4 case ended up working because the
route lookup routing returned a NULL route, which triggered another
route lookup later in the output patch that succeeded.  In the IPv6 case,
a valid route was returned for first call, but we could not find a valid
source address at the time since the source addresses were not set on the
association yet.  Thus resulted in a hung connection.

The solution is to set the source addresses on the association prior to
adding peers.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

net: Make setsockopt() optlen be unsigned.

2009-09-30T23:12:20+00:00

This provides safety against negative optlen at the type
level instead of depending upon (sometimes non-trivial)
checks against this sprinkled all over the the place, in
each and every implementation.

Based upon work done by Arjan van de Ven and feedback
from Linus Torvalds.

Signed-off-by: David S. Miller

sctp: Fix SCTP_MAXSEG socket option to comply to spec.

2009-09-04T22:21:00+00:00

We had a bug that we never stored the user-defined value for
MAXSEG when setting the value on an association.  Thus future
PMTU events ended up re-writing the frag point and increasing
it past user limit.  Additionally, when setting the option on
the socket/endpoint, we effect all current associations, which
is against spec.

Now, we store the user 'maxseg' value along with the computed
'frag_point'.  We inherit 'maxseg' from the socket at association
creation and use it as an upper limit for 'frag_point' when its
set.

Signed-off-by: Vlad Yasevich

sctp: Send user messages to the lower layer as one

2009-09-04T22:20:57+00:00

Currenlty, sctp breaks up user messages into fragments and
sends each fragment to the lower layer by itself.  This means
that for each fragment we go all the way down the stack
and back up.  This also discourages bundling of multiple
fragments when they can fit into a sigle packet (ex: due
to user setting a low fragmentation threashold).

We introduce a new command SCTP_CMD_SND_MSG and hand the
whole message down state machine.  The state machine and
the side-effect parser will cork the queue, add all chunks
from the message to the queue, and then un-cork the queue
thus causing the chunks to get transmitted.

Signed-off-by: Vlad Yasevich

sctp: Disallow new connection on a closing socket

2009-09-04T22:20:56+00:00

If a socket has a lot of association that are in the process of
of being closed/aborted, it is possible for a remote to establish
new associations during the time period that the old ones are shutting
down.  If this was a result of a close() call, there will be no socket
and will cause a memory leak.  We'll prevent this by setting the
socket state to CLOSING and disallow new associations when in this state.

Signed-off-by: Vlad Yasevich

sctp: fix warning at inet_sock_destruct() while release sctp socket

2009-07-06T19:47:08+00:00

Commit 'net: Move rx skb_orphan call to where needed' broken sctp protocol
with warning at inet_sock_destruct(). Actually, sctp can do this right with
sctp_sock_rfree_frag() and sctp_skb_set_owner_r_frag() pair.

    sctp_sock_rfree_frag(skb);
    sctp_skb_set_owner_r_frag(skb, newsk);

This patch not revert the commit d55d87fdff8252d0e2f7c28c2d443aee17e9d70f,
instead remove the sctp_sock_rfree_frag() function.

------------[ cut here ]------------
WARNING: at net/ipv4/af_inet.c:151 inet_sock_destruct+0xe0/0x142()
Modules linked in: sctp ipv6 dm_mirror dm_region_hash dm_log dm_multipath
scsi_mod ext3 jbd uhci_hcd ohci_hcd ehci_hcd [last unloaded: scsi_wait_scan]
Pid: 1808, comm: sctp_test Not tainted 2.6.31-rc2 #40
Call Trace:
 [] warn_slowpath_common+0x6a/0x81
 [] ? inet_sock_destruct+0xe0/0x142
 [] warn_slowpath_null+0x12/0x15
 [] inet_sock_destruct+0xe0/0x142
 [] __sk_free+0x19/0xcc
 [] sk_free+0x18/0x1a
 [] sctp_close+0x192/0x1a1 [sctp]
 [] inet_release+0x47/0x4d
 [] sock_release+0x19/0x5e
 [] sock_close+0x21/0x25
 [] __fput+0xde/0x189
 [] fput+0x18/0x1a
 [] filp_close+0x56/0x60
 [] put_files_struct+0x5d/0xa1
 [] exit_files+0x39/0x3d
 [] do_exit+0x1a5/0x5dd
 [] ? d_kill+0x35/0x3b
 [] ? dequeue_signal+0xa6/0x115
 [] do_group_exit+0x63/0x8a
 [] get_signal_to_deliver+0x2e1/0x2f9
 [] do_notify_resume+0x7c/0x6b5
 [] ? autoremove_wake_function+0x0/0x34
 [] ? __d_free+0x3d/0x40
 [] ? d_free+0x2a/0x3c
 [] ? vfs_write+0x103/0x117
 [] ? sys_socketcall+0x178/0x182
 [] work_notifysig+0x13/0x19
---[ end trace 9db92c463e789fba ]---

Signed-off-by: Wei Yongjun 
Acked-by: Herbert Xu 
Acked-by: Vlad Yasevich 
Signed-off-by: David S. Miller

net: correct off-by-one write allocations reports

2009-06-18T07:29:12+00:00

commit 2b85a34e911bf483c27cfdd124aeb1605145dc80
(net: No more expensive sock_hold()/sock_put() on each tx)
changed initial sk_wmem_alloc value.

We need to take into account this offset when reporting
sk_wmem_alloc to user, in PROC_FS files or various
ioctls (SIOCOUTQ/TIOCOUTQ)

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

sctp: Use frag list abstraction interfaces.

2009-06-09T07:24:07+00:00

Signed-off-by: David S. Miller

sctp: support non-blocking version of the new sctp_connectx() API

2009-06-03T13:14:47+00:00

Prior implementation of the new sctp_connectx() call that returns
an association ID did not work correctly on non-blocking socket.
This is because we could not return both a EINPROGRESS error and
an association id.  This is a new implementation that supports this.

Originally from Ivan Skytte Jørgensen