linux.git/net/sctp/socket.c, branch v2.6.31

sctp: fix warning at inet_sock_destruct() while release sctp socket

2009-07-06T19:47:08+00:00

Commit 'net: Move rx skb_orphan call to where needed' broken sctp protocol
with warning at inet_sock_destruct(). Actually, sctp can do this right with
sctp_sock_rfree_frag() and sctp_skb_set_owner_r_frag() pair.

    sctp_sock_rfree_frag(skb);
    sctp_skb_set_owner_r_frag(skb, newsk);

This patch not revert the commit d55d87fdff8252d0e2f7c28c2d443aee17e9d70f,
instead remove the sctp_sock_rfree_frag() function.

------------[ cut here ]------------
WARNING: at net/ipv4/af_inet.c:151 inet_sock_destruct+0xe0/0x142()
Modules linked in: sctp ipv6 dm_mirror dm_region_hash dm_log dm_multipath
scsi_mod ext3 jbd uhci_hcd ohci_hcd ehci_hcd [last unloaded: scsi_wait_scan]
Pid: 1808, comm: sctp_test Not tainted 2.6.31-rc2 #40
Call Trace:
 [] warn_slowpath_common+0x6a/0x81
 [] ? inet_sock_destruct+0xe0/0x142
 [] warn_slowpath_null+0x12/0x15
 [] inet_sock_destruct+0xe0/0x142
 [] __sk_free+0x19/0xcc
 [] sk_free+0x18/0x1a
 [] sctp_close+0x192/0x1a1 [sctp]
 [] inet_release+0x47/0x4d
 [] sock_release+0x19/0x5e
 [] sock_close+0x21/0x25
 [] __fput+0xde/0x189
 [] fput+0x18/0x1a
 [] filp_close+0x56/0x60
 [] put_files_struct+0x5d/0xa1
 [] exit_files+0x39/0x3d
 [] do_exit+0x1a5/0x5dd
 [] ? d_kill+0x35/0x3b
 [] ? dequeue_signal+0xa6/0x115
 [] do_group_exit+0x63/0x8a
 [] get_signal_to_deliver+0x2e1/0x2f9
 [] do_notify_resume+0x7c/0x6b5
 [] ? autoremove_wake_function+0x0/0x34
 [] ? __d_free+0x3d/0x40
 [] ? d_free+0x2a/0x3c
 [] ? vfs_write+0x103/0x117
 [] ? sys_socketcall+0x178/0x182
 [] work_notifysig+0x13/0x19
---[ end trace 9db92c463e789fba ]---

Signed-off-by: Wei Yongjun 
Acked-by: Herbert Xu 
Acked-by: Vlad Yasevich 
Signed-off-by: David S. Miller

net: correct off-by-one write allocations reports

2009-06-18T07:29:12+00:00

commit 2b85a34e911bf483c27cfdd124aeb1605145dc80
(net: No more expensive sock_hold()/sock_put() on each tx)
changed initial sk_wmem_alloc value.

We need to take into account this offset when reporting
sk_wmem_alloc to user, in PROC_FS files or various
ioctls (SIOCOUTQ/TIOCOUTQ)

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

sctp: Use frag list abstraction interfaces.

2009-06-09T07:24:07+00:00

Signed-off-by: David S. Miller

sctp: support non-blocking version of the new sctp_connectx() API

2009-06-03T13:14:47+00:00

Prior implementation of the new sctp_connectx() call that returns
an association ID did not work correctly on non-blocking socket.
This is because we could not return both a EINPROGRESS error and
an association id.  This is a new implementation that supports this.

Originally from Ivan Skytte Jørgensen

sctp: simplify sctp listening code

2009-03-13T18:37:56+00:00

sctp_inet_listen() call is split between UDP and TCP style.  Looking
at the code, the two functions are almost the same and can be
merged into a single helper.  This also fixes a bug that was
fixed in the UDP function, but missed in the TCP function.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: fix the length check in sctp_getsockopt_maxburst()

2009-03-03T06:49:17+00:00

The code in sctp_getsockopt_maxburst() doesn't allow len to be larger
then struct sctp_assoc_value, which is a common case where app writers
just pass down the sizeof(buf) or something similar.

This patch fix the problem.

Signed-off-by: Wei Yongjun 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: remove dup code in net/sctp/socket.c

2009-03-03T06:49:16+00:00

Remove dup check of "if (optlen < sizeof(int))".

Signed-off-by: Wei Yongjun 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

sctp: Inherit all socket options from parent correctly.

2009-02-16T08:03:11+00:00

During peeloff/accept() sctp needs to save the parent socket state
into the new socket so that any options set on the parent are
inherited by the child socket.  This was found when the
parent/listener socket issues SO_BINDTODEVICE, but the
data was misrouted after a route cache flush.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

trivial: fix then -> than typos in comments and documentation

2009-01-06T10:28:06+00:00

- (better, more, bigger ...) then -> (...) than

Signed-off-by: Frederik Schwarzer 
Signed-off-by: Jiri Kosina

sctp: Add validity check for SCTP_PARTIAL_DELIVERY_POINT socket option

2008-12-26T00:59:03+00:00

The latest ietf socket extensions API draft said:

  8.1.21.  Set or Get the SCTP Partial Delivery Point

    Note also that the call will fail if the user attempts to set
    this value larger than the socket receive buffer size.

This patch add this validity check for SCTP_PARTIAL_DELIVERY_POINT
socket option.

Signed-off-by: Wei Yongjun 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller