linux.git/net/sctp/socket.c, branch v2.6.23

[SCTP]: Convert bind_addr_list locking to RCU

2007-09-16T23:03:28+00:00

Since the sctp_sockaddr_entry is now RCU enabled as part of
the patch to synchronize sctp_localaddr_list, it makes sense to
change all handling of these entries to RCU.  This includes the
sctp_bind_addrs structure and it's list of bound addresses.

This list is currently protected by an external rw_lock and that
looks like an overkill.  There are only 2 writers to the list:
bind()/bindx() calls, and BH processing of ASCONF-ACK chunks.
These are already seriealized via the socket lock, so they will
not step on each other.  These are also relatively rare, so we
should be good with RCU.

The readers are varied and they are easily converted to RCU.

Signed-off-by: Vlad Yasevich 
Acked-by: Paul E. McKenney 
Acked-by: Sridhar Samdurala 
Signed-off-by: David S. Miller

[SCTP]: Add RCU synchronization around sctp_localaddr_list

2007-09-16T23:02:12+00:00

sctp_localaddr_list is modified dynamically via NETDEV_UP
and NETDEV_DOWN events, but there is not synchronization
between writer (even handler) and readers.  As a result,
the readers can access an entry that has been freed and
crash the sytem.

Signed-off-by: Vlad Yasevich 
Acked-by: Paul E. McKenney 
Acked-by: Sridhar Samdurala 
Signed-off-by: David S. Miller

SCTP: Correctly disable listening when backlog is 0.

2007-08-30T18:03:58+00:00

Signed-off-by: Vlad Yasevich

SCTP: Pick the correct port when binding to 0.

2007-08-30T17:55:20+00:00

sctp_bindx() allows the use of unspecified port.  The problem is
that every address we bind to ends up selecting a new port if
the user specified port 0.  This patch allows re-use of the
already selected port when the port from bindx was 0.

Signed-off-by: Vlad Yasevich

SCTP: IPv4 mapped addr not returned in SCTPv6 accept()

2007-08-01T15:19:06+00:00

When issuing a connect call on an AF_INET6 sctp socket with
a IPv4-mapped destination, the peer address that is returned
by getpeeraddr() should be v4-mapped as well.

Signed-off-by: Vlad Yasevich

sctp: try to fix readlock

2007-08-01T15:19:06+00:00

unlock the reader lock in error case.

Signed-off-by: Sebastian Siewior 
Signed-off-by: Vlad Yasevich

sctp: remove shadowed symbols

2007-08-01T15:19:06+00:00

Fixes the following sparse warnings:
net/sctp/sm_make_chunk.c:1457:9: warning: symbol 'len' shadows an earlier one
net/sctp/sm_make_chunk.c:1356:23: originally declared here
net/sctp/socket.c:1534:22: warning: symbol 'chunk' shadows an earlier one
net/sctp/socket.c:1387:20: originally declared here

Signed-off-by: Sebastian Siewior 
Signed-off-by: Vlad Yasevich

sctp: move global declaration to header file.

2007-08-01T15:19:06+00:00

sctp_chunk_cachep & sctp_bucket_cachep is used module global, so move it
to a header file.

Signed-off-by: Sebastian Siewior 
Signed-off-by: Vlad Yasevich

sctp: make locally used function static

2007-08-01T15:19:05+00:00

Forward declarion is static, the function itself is not. Make it
consistent.

Signed-off-by: Sebastian Siewior 
Signed-off-by: Vlad Yasevich

[NET] SCTP: Fix whitespace errors.

2007-07-19T01:44:50+00:00

Signed-off-by: YOSHIFUJI Hideaki