linux.git/net/sctp/socket.c, branch v2.6.22

SCTP: Check to make sure file is valid before setting timeout

2007-07-06T00:40:11+00:00

In-kernel sockets created with sock_create_kern don't usually
have a file and file descriptor allocated to them.  As a result,
when SCTP tries to check the non-blocking flag, we Oops when
dereferencing a NULL file pointer.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

SCTP: Fix thinko in sctp_copy_laddrs()

2007-07-06T00:40:08+00:00

Correctly dereference bytes_copied in sctp_copy_laddrs().
I totally must have spaced when doing this.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

SCTP: lock_sock_nested in sctp_sock_migrate

2007-06-26T13:29:09+00:00

sctp_sock_migrate() grabs the socket lock on a newly allocated socket while
holding the socket lock on an old socket.  lockdep worries that this might
be a recursive lock attempt.

 task/3026 is trying to acquire lock:
  (sk_lock-AF_INET){--..}, at: [] sctp_sock_migrate+0x2e3/0x327 [sctp]
 but task is already holding lock:
  (sk_lock-AF_INET){--..}, at: [] sctp_accept+0xdf/0x1e3 [sctp]

This patch tells lockdep that this locking is safe by using
lock_sock_nested().

Signed-off-by: Zach Brown 
Signed-off-by: Vlad Yasevich

SCTP: Fix sctp_getsockopt_get_peer_addrs

2007-06-19T13:47:32+00:00

	This is the split out of the patch that we agreed I should split
out from my last patch.  It changes space_left to be computed in the same
way the to variable is.  I know we talked about changing space_left to an
int, but I think size_t is more appropriate, since we should never have
negative space in our buffer, and computing using offsetof means space_left
should now never drop below zero.

Signed-off-by: Neil Horman 
Acked-by: Sridhar Samudrala 
Signed-off-by: Vlad Yasevich

SCTP: update sctp_getsockopt helpers to allow oversized buffers

2007-06-19T13:46:34+00:00

	I noted the other day while looking at a bug that was ostensibly
in some perl networking library, that we strictly avoid allowing getsockopt
operations to complete if we pass in oversized buffers.  This seems to make
libraries like Perl::NET malfunction since it seems to allocate oversized
buffers for use in several operations.  It also seems to be out of line with
the way udp, tcp and ip getsockopt routines handle buffer input (since the
*optlen pointer in both an input and an output and gets set to the length
of the data that we copy into the buffer).  This patch brings our getsockopt
helpers into line with other protocols, and allows us to accept oversized
buffers for our getsockopt operations.  Tested by me with good results.

Signed-off-by: Neil Horman 
Acked-by: Sridhar Samudrala 
Signed-off-by: Vlad Yasevich

[SCTP] Flag a pmtu change request

2007-06-13T20:44:42+00:00

Currently, if the socket is owned by the user, we drop the ICMP
message.  As a result SCTP forgets that path MTU changed and
never adjusting it's estimate.  This causes all subsequent
packets to be fragmented.  With this patch, we'll flag the association
that it needs to udpate it's estimate based on the already updated
routing information.

Signed-off-by: Vlad Yasevich 
Acked-by: Sridhar Samudrala

[SCTP] Fix leak in sctp_getsockopt_local_addrs when copy_to_user fails

2007-06-13T20:44:41+00:00

If the copy_to_user or copy_user calls fail in sctp_getsockopt_local_addrs(),
the function should free locally allocated storage before returning error.
Spotted by Coverity.

Signed-off-by: Vlad Yasevich 
Acked-by: Sridhar Samudrala

[SCTP]: Allow unspecified port in sctp_bindx()

2007-06-13T20:44:41+00:00

Allow sctp_bindx() to accept multiple address with
unspecified port.  In this case, all addresses inherit
the first bound port.  We still catch full mis-matches.

Signed-off-by: Vlad Yasevich 
Acked-by: Sridhar Samudrala

[SCTP]: Correctly set daddr for IPv6 sockets during peeloff

2007-06-13T20:44:41+00:00

During peeloff of AF_INET6 socket, the inet6_sk(sk)->daddr
wasn't set correctly since the code was assuming IPv4 only.
Now we use a correct call to set the destination address.

Signed-off-by: Vlad Yasevich 
Acked-by: Sridhar Samudrala

[SCTP]: Correctly copy addresses in sctp_copy_laddrs

2007-05-11T06:45:30+00:00

I broke the  non-wildcard case recently.  This is to fixes it.
Now, explictitly bound addresses can ge retrieved using the API.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller