linux.git/net/sctp/protocol.c, branch v2.6.25

[SCTP]: IPv4 vs IPv6 addresses mess in sctp_inet[6]addr_event.

2008-04-13T01:40:38+00:00

All IP addresses that are present in a system are duplicated on
struct sctp_sockaddr_entry. They are linked in the global list
called sctp_local_addr_list. And this struct unions IPv4 and IPv6
addresses.

So, there can be rare case, when a sockaddr_in.sin_addr coincides
with the corresponding part of the sockaddr_in6 and the notifier
for IPv4 will carry away an IPv6 entry.

The fix is to check the family before comparing the addresses.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

[SCTP]: Fix a race between module load and protosw access

2008-03-20T22:17:14+00:00

There is a race is SCTP between the loading of the module
and the access by the socket layer to the protocol functions.
In particular, a list of addresss that SCTP maintains is
not initialized prior to the registration with the protosw.
Thus it is possible for a user application to gain access
to SCTP functions before everything has been initialized.
The problem shows up as odd crashes during connection
initializtion when we try to access the SCTP address list.

The solution is to refactor how we do registration and
initialize the lists prior to registering with the protosw.
Care must be taken since the address list initialization
depends on some other pieces of SCTP initialization.  Also
the clean-up in case of failure now also needs to be refactored.

Signed-off-by: Vlad Yasevich 
Acked-by: Sridhar Samudrala 
Signed-off-by: David S. Miller

[NET] endianness noise: INADDR_ANY

2008-03-18T05:44:53+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[SCTP]: Fix local_addr deletions during list traversals.

2008-03-12T01:05:02+00:00

Since the lists are circular, we need to explicitely tag
the address to be deleted since we might end up freeing
the list head instead.  This fixes some interesting SCTP
crashes.

Signed-off-by: Chidambar 'ilLogict' Zinnoury 
Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

[SCTP]: Clean up naming conventions of sctp protocol/address family registration

2008-02-28T21:41:05+00:00

I noticed while looking into some odd behavior in sctp, that the variable
name sctp_pf_inet6_specific was used twice to represent two different
pieces of data (its both a structure name and a pointer to that type of
structure), which is confusing to say the least, and potentially dangerous
depending on the variable scope.  This patch cleans that up, and makes the
protocol and address family registration names in SCTP more regular,
increasing readability.

Signed-off-by: Neil Horman 
Signed-off-by: Vlad Yasevich 

 ipv6.c     |   12 ++++++------
 protocol.c |   12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

[SCTP]: Stop claiming that this is a "reference implementation"

2008-02-05T15:59:07+00:00

I was notified by Randy Stewart that lksctp claims to be
"the reference implementation".  First of all, "the
refrence implementation" was the original implementation
of SCTP in usersapce written ty Randy and a few others.
Second, after looking at the definiton of 'reference implementation',
we don't really meet the requirements.

Signed-off-by: Vlad Yasevich

[NETNS]: Add namespace parameter to ip_route_output_key.

2008-01-28T23:11:07+00:00

Needed to propagate it down to the ip_route_output_flow.

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[NETNS]: Add netns parameter to inet_(dev_)add_type.

2008-01-28T23:01:27+00:00

The patch extends the inet_addr_type and inet_dev_addr_type with the
network namespace pointer. That allows to access the different tables
relatively to the network namespace.

The modification of the signature function is reported in all the
callers of the inet_addr_type using the pointer to the well known
init_net.

Acked-by: Benjamin Thery 
Acked-by: Daniel Lezcano 
Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

[NET] CORE: Introducing new memory accounting interface.

2008-01-28T23:00:18+00:00

This patch introduces new memory accounting functions for each network
protocol. Most of them are renamed from memory accounting functions
for stream protocols. At the same time, some stream memory accounting
functions are removed since other functions do same thing.

Renaming:
	sk_stream_free_skb()		->	sk_wmem_free_skb()
	__sk_stream_mem_reclaim()	->	__sk_mem_reclaim()
	sk_stream_mem_reclaim()		->	sk_mem_reclaim()
	sk_stream_mem_schedule 		->    	__sk_mem_schedule()
	sk_stream_pages()      		->	sk_mem_pages()
	sk_stream_rmem_schedule()	->	sk_rmem_schedule()
	sk_stream_wmem_schedule()	->	sk_wmem_schedule()
	sk_charge_skb()			->	sk_mem_charge()

Removeing
	sk_stream_rfree():	consolidates into sock_rfree()
	sk_stream_set_owner_r(): consolidates into skb_set_owner_r()
	sk_stream_mem_schedule()

The following functions are added.
    	sk_has_account(): check if the protocol supports accounting
	sk_mem_uncharge(): do the opposite of sk_mem_charge()

In addition, to achieve consolidation, updating sk_wmem_queued is
removed from sk_mem_charge().

Next, to consolidate memory accounting functions, this patch adds
memory accounting calls to network core functions. Moreover, present
memory accounting call is renamed to new accounting call.

Finally we replace present memory accounting calls with new interface
in TCP and SCTP.

Signed-off-by: Takahiro Yasui 
Signed-off-by: Hideo Aoki 
Signed-off-by: David S. Miller

[SCTP]: Change use_as_src into a full address state

2008-01-28T22:59:24+00:00

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller