linux.git/net/sched, branch v2.6.25

[NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop

2008-04-14T22:10:42+00:00

TC_H_MAJ(parentid) for root classes is the same as for ingress, and if
ingress qdisc is created qdisc_lookup() returns its pointer (without
ingress NULL is returned). After this all qdisc_lookups give the same,
and we get endless loop. (I don't know how this could hide for so long
- it should trigger with every leaf class deleted if it's qdisc isn't
empty.)

After this fix qdisc_lookup() is omitted both for ingress and root
parents, but looking for root is only wasting a little time here...
Many thanks to Enrico Demarin for finding a test for catching this
bug, which probably bothered quite a lot of admins.
 
Reported-by: Enrico Demarin ,
Signed-off-by: Jarek Poplawski 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET_SCHED] cls_u32: refcounting fix for u32_delete()

2008-04-13T01:37:13+00:00

Deleting of nonroot hnodes mostly doesn't work in u32_delete():
refcnt == 1 is expected, but such hnodes' refcnts are initialized
with 0 and charged only with "link" nodes. Now they'll start with
1 like usual. Thanks to Patrick McHardy for an improving suggestion.

Signed-off-by: Jarek Poplawski 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

[NET]: Add preemption point in qdisc_run

2008-03-28T23:25:26+00:00

The qdisc_run loop is currently unbounded and runs entirely in a
softirq.  This is bad as it may create an unbounded softirq run.

This patch fixes this by calling need_resched and breaking out if
necessary.

It also adds a break out if the jiffies value changes since that would
indicate we've been transmitting for too long which starves other
softirqs.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

sch_htb: fix "too many events" situation

2008-03-24T05:00:38+00:00

HTB is event driven algorithm and part of its work is to apply
scheduled events at proper times. It tried to defend itself from
livelock by processing only limited number of events per dequeue.
Because of faster computers some users already hit this hardcoded
limit.

This patch limits processing up to 2 jiffies (why not 1 jiffie ?
because it might stop prematurely when only fraction of jiffie
remains).

Signed-off-by: Martin Devera 
Signed-off-by: David S. Miller

[PKT_SCHED]: annotate cls_u32

2008-03-18T05:46:46+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[PKT_SCHED] ematch: Fix build warning.

2008-02-10T11:48:15+00:00

Commit 954415e33ed6cfa932c13e8c2460bd05e50723b5 ("[PKT_SCHED] ematch:
tcf_em_destroy robustness") removed a cast on em->data when
passing it to kfree(), but em->data is an integer type that can
hold pointers as well as other values so the cast is necessary.

Signed-off-by: David S. Miller

[NET_SCHED] sch_htb: htb_requeue fix

2008-02-10T07:44:00+00:00

htb_requeue() enqueues skbs for which htb_classify() returns NULL.
This is wrong because such skbs could be handled by NET_CLS_ACT code,
and the decision could be different than earlier in htb_enqueue().
So htb_requeue() is changed to work and look more like htb_enqueue().

Signed-off-by: Jarek Poplawski 
Signed-off-by: David S. Miller

[PKT_SCHED] ematch: tcf_em_destroy robustness

2008-02-10T07:26:53+00:00

Make the code in tcf_em_tree_destroy more robust and cleaner:
 * Don't need to cast pointer to kfree() or avoid passing NULL.
 * After freeing the tree, clear the pointer to avoid possible problems
from repeated free.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[PKT_SCHED]: deinline functions in meta match

2008-02-10T07:26:17+00:00

A couple of functions in meta match don't need to be inline.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[PKT_SCHED] ematch: oops from uninitialized variable (resend)

2008-02-09T11:47:19+00:00

Setting up a meta match causes a kernel OOPS because of uninitialized
elements in tree.

[   37.322381] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
[   37.322381] IP: [] :em_meta:em_meta_destroy+0x17/0x80

[   37.322381] Call Trace:
[   37.322381]  [] tcf_em_tree_destroy+0x2d/0xa0
[   37.322381]  [] tcf_em_tree_validate+0x2dc/0x4a0
[   37.322381]  [] nla_parse+0x92/0xe0
[   37.322381]  [] :cls_basic:basic_change+0x202/0x3c0
[   37.322381]  [] kmem_cache_alloc+0x67/0xa0
[   37.322381]  [] tc_ctl_tfilter+0x3b1/0x580
[   37.322381]  [] rtnetlink_rcv_msg+0x0/0x260
[   37.322381]  [] netlink_rcv_skb+0x74/0xa0
[   37.322381]  [] rtnetlink_rcv+0x18/0x20
[   37.322381]  [] netlink_unicast+0x263/0x290
[   37.322381]  [] __alloc_skb+0x96/0x160
[   37.322381]  [] netlink_sendmsg+0x274/0x340
[   37.322381]  [] sock_sendmsg+0x12b/0x140
[   37.322381]  [] autoremove_wake_function+0x0/0x30
[   37.322381]  [] autoremove_wake_function+0x0/0x30
[   37.322381]  [] sock_sendmsg+0x12b/0x140
[   37.322381]  [] zone_statistics+0xb1/0xc0
[   37.322381]  [] sys_sendmsg+0x20e/0x360
[   37.322381]  [] sockfd_lookup_light+0x41/0x80
[   37.322381]  [] handle_mm_fault+0x3eb/0x7f0
[   37.322381]  [] system_call_after_swapgs+0x7b/0x80

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller