linux.git/net/rds, branch v5.7-rc2

net/rds: Use ERR_PTR for rds_message_alloc_sgs()

2020-04-15T19:33:29+00:00

Returning the error code via a 'int *ret' when the function returns a
pointer is very un-kernely and causes gcc 10's static analysis to choke:

net/rds/message.c: In function ‘rds_message_map_pages’:
net/rds/message.c:358:10: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  358 |   return ERR_PTR(ret);

Use a typical ERR_PTR return instead.

Signed-off-by: Jason Gunthorpe 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

net/rds: Fix MR reference counting problem

2020-04-09T17:22:00+00:00

In rds_free_mr(), it calls rds_destroy_mr(mr) directly.  But this
defeats the purpose of reference counting and makes MR free handling
impossible.  It means that holding a reference does not guarantee that
it is safe to access some fields.  For example, In
rds_cmsg_rdma_dest(), it increases the ref count, unlocks and then
calls mr->r_trans->sync_mr().  But if rds_free_mr() (and
rds_destroy_mr()) is called in between (there is no lock preventing
this to happen), r_trans_private is set to NULL, causing a panic.
Similar issue is in rds_rdma_unuse().

Reported-by: zerons 
Signed-off-by: Ka-Cheong Poon 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

net/rds: Replace struct rds_mr's r_refcount with struct kref

2020-04-09T17:22:00+00:00

And removed rds_mr_put().

Signed-off-by: Ka-Cheong Poon 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

net/rds: Track user mapped pages through special API

2020-02-17T02:37:09+00:00

Convert net/rds to use the newly introduces pin_user_pages() API,
which properly sets FOLL_PIN. Setting FOLL_PIN is now required for
code that requires tracking of pinned pages.

Note that this effectively changes the code's behavior: it now
ultimately calls set_page_dirty_lock(), instead of set_page_dirty().
This is probably more accurate.

As Christoph Hellwig put it, "set_page_dirty() is only safe if we are
dealing with a file backed page where we have reference on the inode it
hangs off." [1]

[1] https://lore.kernel.org/r/20190723153640.GB720@lst.de

Cc: Hans Westgaard Ry 
Cc: Santosh Shilimkar 
Signed-off-by: Leon Romanovsky 
Signed-off-by: John Hubbard 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

net/rds: Use prefetch for On-Demand-Paging MR

2020-01-18T09:48:19+00:00

Try prefetching pages when using On-Demand-Paging MR using
ib_advise_mr.

Signed-off-by: Hans Westgaard Ry 
Acked-by: Santosh Shilimkar 
Signed-off-by: Leon Romanovsky

net/rds: Handle ODP mr registration/unregistration

2020-01-18T09:48:19+00:00

On-Demand-Paging MRs are registered using ib_reg_user_mr and
unregistered with ib_dereg_mr.

Signed-off-by: Hans Westgaard Ry 
Acked-by: Santosh Shilimkar 
Signed-off-by: Leon Romanovsky

net/rds: Detect need of On-Demand-Paging memory registration

2020-01-16T14:15:25+00:00

Add code to check if memory intended for RDMA is FS-DAX-memory. RDS
will fail with error code EOPNOTSUPP if FS-DAX-memory is detected.

Signed-off-by: Hans Westgaard Ry 
Acked-by: Santosh Shilimkar 
Signed-off-by: Leon Romanovsky

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2019-11-17T05:51:42+00:00

Lots of overlapping changes and parallel additions, stuff
like that.

Signed-off-by: David S. Miller

rds: ib: update WR sizes when bringing up connection

2019-11-16T20:59:08+00:00

Currently WR sizes are updated from rds_ib_sysctl_max_send_wr and
rds_ib_sysctl_max_recv_wr when a connection is shut down. As a result,
a connection being down while rds_ib_sysctl_max_send_wr or
rds_ib_sysctl_max_recv_wr are updated, will not update the sizes when
it comes back up.

Move resizing of WRs to rds_ib_setup_qp so that connections will be setup
with the most current WR sizes.

Signed-off-by: Dag Moxnes 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

net/rds: Remove unnecessary null check

2019-10-17T19:23:03+00:00

Null check before dma_pool_destroy is redundant, so remove it.
This is detected by coccinelle.

Signed-off-by: YueHaibing 
Signed-off-by: David S. Miller