linux.git/net/openvswitch/datapath.c, branch v3.17-rc2

openvswitch: fix duplicate #include headers

2014-08-07T23:02:57+00:00

The #include headers net/genetlink.h and linux/genetlink.h both were
included twice, so delete each of the duplicate.

Signed-off-by: Jean Sacren 
Cc: Pravin Shelar 
Cc: dev@openvswitch.org
Signed-off-by: David S. Miller

openvswitch: Use IS_ERR_OR_NULL

2014-07-29T22:31:56+00:00

This patch introduces the use of the macro IS_ERR_OR_NULL in place of
tests for NULL and IS_ERR.

The following Coccinelle semantic patch was used for making the change:

@@
expression e;
@@

- e == NULL || IS_ERR(e)
+ IS_ERR_OR_NULL(e)
 || ...

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Avoid memory corruption in queue_userspace_packet()

2014-07-24T16:37:20+00:00

In queue_userspace_packet(), the ovs_nla_put_flow return value is
not checked. This is fine as long as key_attr_size() returns the
correct value. In case it does not, the current code may corrupt buffer
memory. Add a run time assertion catch this case to avoid silent
failure.

Reported-by: Ben Pfaff 
Signed-off-by: Andy Zhou 
Signed-off-by: Pravin B Shelar

openvswitch: Allow each vport to have an array of 'port_id's.

2014-07-24T08:15:04+00:00

In order to allow handlers directly read upcalls from datapath,
we need to support per-handler netlink socket for each vport in
datapath.  This commit makes this happen.  Also, it is guaranteed
to be backward compatible with previous branch.

Signed-off-by: Alex Wang 
Acked-by: Thomas Graf 
Signed-off-by: Pravin B Shelar

openvswitch: make generic netlink group const

2014-07-17T06:41:13+00:00

Generic netlink tables can be const.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2014-07-16T21:09:34+00:00

Signed-off-by: David S. Miller

openvswitch: introduce rtnl ops stub

2014-07-01T21:40:17+00:00

This stub now allows userspace to see IFLA_INFO_KIND for ovs master and
IFLA_INFO_SLAVE_KIND for slave.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

openvswitch: Use exact lookup for flow_get and flow_del.

2014-07-01T03:47:15+00:00

Due to the race condition in userspace, there is chance that two
overlapping megaflows could be installed in datapath.  And this
causes userspace unable to delete the less inclusive megaflow flow
even after it timeout, since the flow_del logic will stop at the
first match of masked flow.

This commit fixes the bug by making the kernel flow_del and flow_get
logic check all masks in that case.

Introduced by 03f0d916a (openvswitch: Mega flow implementation).

Signed-off-by: Alex Wang 
Acked-by: Andy Zhou 
Signed-off-by: Pravin B Shelar

openvswitch: Fix tracking of flags seen in TCP flows.

2014-06-29T21:10:51+00:00

Flow statistics need to take into account the TCP flags from the packet
currently being processed (in 'key'), not the TCP flags matched by the
flow found in the kernel flow table (in 'flow').

This bug made the Open vSwitch userspace fin_timeout action have no effect
in many cases.
This bug is introduced by commit 88d73f6c411ac2f0578 (openvswitch: Use
TCP flags in the flow key for stats.)

Reported-by: Len Gao 
Signed-off-by: Ben Pfaff 
Acked-by: Jarno Rajahalme 
Acked-by: Jesse Gross 
Signed-off-by: Pravin B Shelar

openvswitch: Simplify genetlink code.

2014-05-22T23:27:37+00:00

Following patch get rid of struct genl_family_and_ops which is
redundant due to changes to struct genl_family.

Signed-off-by: Kyle Mestery 
Acked-by: Kyle Mestery 
Signed-off-by: Pravin B Shelar