linux.git/net/openvswitch/datapath.c, branch v3.16-rc2

openvswitch: Simplify genetlink code.

2014-05-22T23:27:37+00:00

Following patch get rid of struct genl_family_and_ops which is
redundant due to changes to struct genl_family.

Signed-off-by: Kyle Mestery 
Acked-by: Kyle Mestery 
Signed-off-by: Pravin B Shelar

openvswitch: Minimize ovs_flow_cmd_new|set critical sections.

2014-05-22T23:27:36+00:00

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Split ovs_flow_cmd_new_or_set().

2014-05-22T23:27:36+00:00

Following patch will be easier to reason about with separate
ovs_flow_cmd_new() and ovs_flow_cmd_set() functions.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Minimize ovs_flow_cmd_del critical section.

2014-05-22T23:27:36+00:00

ovs_flow_cmd_del() now allocates reply (if needed) after the flow has
already been removed from the flow table.  If the reply allocation
fails, a netlink error is signaled with netlink_set_err(), as is
already done in ovs_flow_cmd_new_or_set() in the similar situation.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Reduce locking requirements.

2014-05-22T23:27:36+00:00

Reduce and clarify locking requirements for ovs_flow_cmd_alloc_info(),
ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info().

A datapath pointer is available only when holding a lock.  Change
ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info() to take a
dp_ifindex directly, rather than a datapath pointer that is then
(only) used to get the dp_ifindex.  This is useful, since the
dp_ifindex is available even when the datapath pointer is not, both
before and after taking a lock, which makes further critical section
reduction possible.

Make ovs_flow_cmd_alloc_info() take an 'acts' argument instead a
'flow' pointer.  This allows some future patches to do the allocation
before acquiring the flow pointer.

The locking requirements after this patch are:

ovs_flow_cmd_alloc_info(): May be called without locking, must not be
called while holding the RCU read lock (due to memory allocation).
If 'acts' belong to a flow in the flow table, however, then the
caller must hold ovs_mutex.

ovs_flow_cmd_fill_info(): Either ovs_mutex or RCU read lock must be held.

ovs_flow_cmd_build_info(): This calls both of the above, so the caller
must hold ovs_mutex.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Minimize dp and vport critical sections.

2014-05-22T23:27:35+00:00

Move most memory allocations away from the ovs_mutex critical
sections.  vport allocations still happen while the lock is taken, as
changing that would require major refactoring. Also, vports are
created very rarely so it should not matter.

Change ovs_dp_cmd_get() now only takes the rcu_read_lock(), rather
than ovs_lock(), as nothing need to be changed.  This was done by
ovs_vport_cmd_get() already.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Build flow cmd netlink reply only if needed.

2014-05-22T23:27:34+00:00

Use netlink_has_listeners() and NLM_F_ECHO flag to determine if a
reply is needed or not for OVS_FLOW_CMD_NEW, OVS_FLOW_CMD_SET, or
OVS_FLOW_CMD_DEL.  Currently, OVS userspace does not request a reply
for OVS_FLOW_CMD_NEW, but usually does for OVS_FLOW_CMD_DEL, as stats
may have changed.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Clarify locking.

2014-05-22T23:27:34+00:00

Remove unnecessary locking from functions that are always called with
appropriate locking.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Thomas Graf 
Signed-off-by: Pravin B Shelar

openvswitch: Avoid assigning a NULL pointer to flow actions.

2014-05-22T23:27:34+00:00

Flow SET can accept an empty set of actions, with the intended
semantics of leaving existing actions unmodified.  This seems to have
been brokin after OVS 1.7, as we have assigned the flow's actions
pointer to NULL in this case, but we never check for the NULL pointer
later on.  This patch restores the intended behavior and documents it
in the include/linux/openvswitch.h.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Remove 5-tuple optimization.

2014-05-16T20:40:29+00:00

The 5-tuple optimization becomes unnecessary with a later per-NUMA
node stats patch.  Remove it first to make the changes easier to
grasp.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Jesse Gross