linux.git/net/openvswitch/datapath.c, branch v3.14-rc7

openvswitch: Suppress error messages on megaflow updates

2014-02-05T06:32:38+00:00

With subfacets, we'd expect megaflow updates message to carry
the original micro flow. If not, EINVAL is returned and kernel
logs an error message.  Now that the user space subfacet layer is
removed, it is expected that flow updates can arrive with a
micro flow other than the original. Change the return code to
EEXIST and remove the kernel error log message.

Reported-by: Ben Pfaff 
Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Fix ovs_dp_cmd_msg_size()

2014-02-05T06:21:23+00:00

commit 43d4be9cb55f3bac5253e9289996fd9d735531db (openvswitch: Allow user space
to announce ability to accept unaligned Netlink messages) introduced
OVS_DP_ATTR_USER_FEATURES netlink attribute in datapath responses,
but the attribute size was not taken into account in ovs_dp_cmd_msg_size().

Signed-off-by: Daniele Di Proietto 
Signed-off-by: Jesse Gross

openvswitch: Fix kernel panic on ovs_flow_free

2014-02-05T06:21:17+00:00

Both mega flow mask's reference counter and per flow table mask list
should only be accessed when holding ovs_mutex() lock. However
this is not true with ovs_flow_table_flush(). The patch fixes this bug.

Reported-by: Joe Stringer 
Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Pad OVS_PACKET_ATTR_PACKET if linear copy was performed

2014-02-05T06:21:11+00:00

While the zerocopy method is correctly omitted if user space
does not support unaligned Netlink messages. The attribute is
still not padded correctly as skb_zerocopy() will not ensure
padding and the attribute size is no longer pre calculated
though nla_reserve() which ensured padding previously.

This patch applies appropriate padding if a linear data copy
was performed in skb_zerocopy().

Signed-off-by: Thomas Graf 
Acked-by: Zoltan Kiss 
Signed-off-by: Jesse Gross

ovs: make functions local

2014-01-06T23:54:39+00:00

Several functions and datastructures could be local
Found with 'make namespacecheck'

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jesse Gross

openvswitch: Compute checksum in skb_gso_segment() if needed

2014-01-06T23:53:24+00:00

The copy & csum optimization is no longer present with zerocopy
enabled. Compute the checksum in skb_gso_segment() directly by
dropping the HW CSUM capability from the features passed in.

Signed-off-by: Thomas Graf 
Signed-off-by: Jesse Gross

openvswitch: Use skb_zerocopy() for upcall

2014-01-06T23:53:17+00:00

Use of skb_zerocopy() can avoid the expensive call to memcpy()
when copying the packet data into the Netlink skb. Completes
checksum through skb_checksum_help() if not already done in
GSO segmentation.

Zerocopy is only performed if user space supported unaligned
Netlink messages. memory mapped netlink i/o is preferred over
zerocopy if it is set up.

Cost of upcall is significantly reduced from:
+   7.48%       vhost-8471  [k] memcpy
+   5.57%     ovs-vswitchd  [k] memcpy
+   2.81%       vhost-8471  [k] csum_partial_copy_generic

to:
+   5.72%     ovs-vswitchd  [k] memcpy
+   3.32%       vhost-5153  [k] memcpy
+   0.68%       vhost-5153  [k] skb_zerocopy

(megaflows disabled)

Signed-off-by: Thomas Graf 
Signed-off-by: Jesse Gross

openvswitch: Pass datapath into userspace queue functions

2014-01-06T23:53:07+00:00

Allows removing the net and dp_ifindex argument and simplify the
code.

Signed-off-by: Thomas Graf 
Signed-off-by: Jesse Gross

openvswitch: Drop user features if old user space attempted to create datapath

2014-01-06T23:53:00+00:00

Drop user features if an outdated user space instance that does not
understand the concept of user_features attempted to create a new
datapath.

Signed-off-by: Thomas Graf 
Signed-off-by: Jesse Gross

openvswitch: Allow user space to announce ability to accept unaligned Netlink messages

2014-01-06T23:52:53+00:00

Signed-off-by: Thomas Graf 
Reviewed-by: Daniel Borkmann 
Signed-off-by: Jesse Gross