linux.git/net/mpls, branch v5.19

net: mpls: fix memdup.cocci warning

2022-04-08T04:06:41+00:00

Simply use kmemdup instead of explicitly allocating and copying memory.

Generated by: scripts/coccinelle/api/memdup.cocci

Signed-off-by: GONG, Ruiqi 
Link: https://lore.kernel.org/r/20220406114629.182833-1-gongruiqi1@huawei.com
Signed-off-by: Jakub Kicinski

net: mpls: Fix GCC 12 warning

2022-02-10T15:29:39+00:00

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable outside the switch, which silences the warning:

./net/mpls/af_mpls.c:1624:21: error: statement will never be executed [-Werror=switch-unreachable]
  1624 |                 int err;
       |                     ^~~

Signed-off-by: Victor Erminpour 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2021-12-02T19:44:56+00:00

Signed-off-by: Jakub Kicinski

net: mpls: Make for_nexthops iterator const

2021-11-29T12:46:52+00:00

There are separate for_nexthops and change_nexthops iterators. The
for_nexthops variant should use const.

Signed-off-by: Benjamin Poirier 
Signed-off-by: David S. Miller

net: mpls: Remove duplicate variable from iterator macro

2021-11-29T12:46:52+00:00

__nh is just a copy of nh with a different type.

Signed-off-by: Benjamin Poirier 
Signed-off-by: David S. Miller

net: mpls: Remove rcu protection from nh_dev

2021-11-29T12:39:42+00:00

Following the previous commit, nh_dev can no longer be accessed and
modified concurrently.

Signed-off-by: Benjamin Poirier 
Signed-off-by: David S. Miller

net: mpls: Fix notifications when deleting a device

2021-11-29T12:39:42+00:00

There are various problems related to netlink notifications for mpls route
changes in response to interfaces being deleted:
* delete interface of only nexthop
	DELROUTE notification is missing RTA_OIF attribute
* delete interface of non-last nexthop
	NEWROUTE notification is missing entirely
* delete interface of last nexthop
	DELROUTE notification is missing nexthop

All of these problems stem from the fact that existing routes are modified
in-place before sending a notification. Restructure mpls_ifdown() to avoid
changing the route in the DELROUTE cases and to create a copy in the
NEWROUTE case.

Fixes: f8efb73c97e2 ("mpls: multipath route support")
Signed-off-by: Benjamin Poirier 
Signed-off-by: David S. Miller

mpls: defer ttl decrement in mpls_forward()

2021-07-23T16:17:56+00:00

Defer ttl decrement to optimize in tx_err case. There is no need
to decrease ttl in the case of goto tx_err.

Signed-off-by: Kangmin Park 
Signed-off-by: David S. Miller

mpls: Remove redundant assignment to err

2021-04-27T21:17:00+00:00

Variable err is set to -ENOMEM but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

net/mpls/af_mpls.c:1022:2: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Signed-off-by: David S. Miller

net: avoid infinite loop in mpls_gso_segment when mpls_hlen == 0

2021-03-10T00:12:20+00:00

A packet with skb_inner_network_header(skb) == skb_network_header(skb)
and ETH_P_MPLS_UC will prevent mpls_gso_segment from pulling any headers
from the packet. Subsequently, the call to skb_mac_gso_segment will
again call mpls_gso_segment with the same packet leading to an infinite
loop. In addition, ensure that the header length is a multiple of four,
which should hold irrespective of the number of stacked labels.

Signed-off-by: Balazs Nemeth 
Acked-by: Willem de Bruijn 
Reviewed-by: David Ahern 
Signed-off-by: David S. Miller