linux.git/net/mctp, branch v5.15

mctp: perform route destruction under RCU read lock

2021-09-08T10:29:16+00:00

The kernel test robot reports:

  [  843.509974][  T345] =============================
  [  843.524220][  T345] WARNING: suspicious RCU usage
  [  843.538791][  T345] 5.14.0-rc2-00606-g889b7da23abf #1 Not tainted
  [  843.553617][  T345] -----------------------------
  [  843.567412][  T345] net/mctp/route.c:310 RCU-list traversed in non-reader section!!

- we're missing the rcu read lock acquire around the destruction path.

This change adds the acquire/release - the path is already atomic, and
we're using the _rcu list iterators.

Reported-by: kernel test robot 
Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Specify route types, require rtm_type in RTM_*ROUTE messages

2021-08-11T23:01:17+00:00

This change adds a 'type' attribute to routes, which can be parsed from
a RTM_NEWROUTE message. This will help to distinguish local vs. peer
routes in a future change.

This means userspace will need to set a correct rtm_type in RTM_NEWROUTE
and RTM_DELROUTE messages; we currently only accept RTN_UNICAST.

Signed-off-by: Jeremy Kerr 
Link: https://lore.kernel.org/r/20210810023834.2231088-1-jk@codeconstruct.com.au
Signed-off-by: Jakub Kicinski

mctp: remove duplicated assignment of pointer hdr

2021-08-05T09:56:01+00:00

The pointer hdr is being initialized and also re-assigned with the
same value from the call to function mctp_hdr. Static analysis reports
that the initializated value is unused. The second assignment is
duplicated and can be removed.

Addresses-Coverity: ("Unused value").
Signed-off-by: Colin Ian King 
Signed-off-by: David S. Miller

mctp: Allow per-netns default networks

2021-07-29T14:06:50+00:00

Currently we have a compile-time default network
(MCTP_INITIAL_DEFAULT_NET). This change introduces a default_net field
on the net namespace, allowing future configuration for new interfaces.

Signed-off-by: Matt Johnston 
Signed-off-by: David S. Miller

mctp: Add dest neighbour lladdr to route output

2021-07-29T14:06:50+00:00

Now that we have a neighbour implementation, hook it up to the output
path to set the dest hardware address for outgoing packets.

Signed-off-by: Matt Johnston 
Signed-off-by: David S. Miller

mctp: Implement message fragmentation & reassembly

2021-07-29T14:06:50+00:00

This change implements MCTP fragmentation (based on route & device MTU),
and corresponding reassembly.

The MCTP specification only allows for fragmentation on the originating
message endpoint, and reassembly on the destination endpoint -
intermediate nodes do not need to reassemble/refragment.  Consequently,
we only fragment in the local transmit path, and reassemble
locally-bound packets. Messages are required to be in-order, so we
simply cancel reassembly on out-of-order or missing packets.

In the fragmentation path, we just break up the message into MTU-sized
fragments; the skb structure is a simple copy for now, which we can later
improve with a shared data implementation.

For reassembly, we keep track of incoming message fragments using the
existing tag infrastructure, allocating a key on the (src,dest,tag)
tuple, and reassembles matching fragments into a skb->frag_list.

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Populate socket implementation

2021-07-29T14:06:50+00:00

Start filling-out the socket syscalls: bind, sendmsg & recvmsg.

This requires an input route implementation, so we add to
mctp_route_input, allowing lookups on binds & message tags. This just
handles single-packet messages at present, we will add fragmentation in
a future change.

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Add neighbour netlink interface

2021-07-29T14:06:50+00:00

This change adds the netlink interfaces for manipulating the MCTP
neighbour table.

Signed-off-by: Matt Johnston 
Signed-off-by: David S. Miller

mctp: Add neighbour implementation

2021-07-29T14:06:50+00:00

Add an initial neighbour table implementation, to be used in the route
output path.

Signed-off-by: Matt Johnston 
Signed-off-by: David S. Miller

mctp: Add netlink route management

2021-07-29T14:06:50+00:00

This change adds RTM_GETROUTE, RTM_NEWROUTE & RTM_DELROUTE handlers,
allowing management of the MCTP route table.

Includes changes from Jeremy Kerr .

Signed-off-by: Matt Johnston 
Signed-off-by: David S. Miller