linux.git/net/mac80211/debugfs_sta.c, branch v2.6.26

mac80211: make debugfs files root-only

2008-04-08T20:44:43+00:00

Unfortunately, debugfs can be made to access invalid memory by
open()ing a file and then waiting until the corresponding debugfs
file has been removed (and, probably, the underlying object.)

That could be exploited by any user if the user is able to open
debugfs files and can cause networking devices, STA entries or
similar to disappear which is quite easy to do.

Hence, all debugfs files should be root-only.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: A-MPDU MLME use dynamic allocation

2008-03-27T20:03:20+00:00

This patch alters the A-MPDU MLME in sta_info to use dynamic allocation,
thus drastically improving memory usage - from a constant ~2 Kbyte in
the previous (static) allocation to a lower limit of ~200 Byte and an upper
limit of ~2 Kbyte.

Signed-off-by: Ron Rindjunsky 
Signed-off-by: Tomas Winkler 
Signed-off-by: John W. Linville

mac80211: fix wrong Rx A-MPDU control via debugfs

2008-03-27T20:03:17+00:00

This patch eliminate the use of buf_size as a trigger in favor of a new
flag to control Rx A-MPDU sessions through debugfs

Signed-off-by: Ron Rindjunsky 
Signed-off-by: Tomas Winkler 
Signed-off-by: John W. Linville

mac80211: clean up sta_info and document locking

2008-03-06T20:30:47+00:00

This patch cleans up the sta_info struct and documents how
each set of variables is locked. Notably, flags locking is
completely missing. It also adds kernel-doc for some (but
not all yet) members of the struct.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: RCU-ify STA info structure access

2008-03-06T20:30:46+00:00

This makes access to the STA hash table/list use RCU to protect
against freeing of items. However, it's not a true RCU, the
copy step is missing: whenever somebody changes a STA item it
is simply updated. This is an existing race condition that is
now somewhat understandable.

This patch also fixes the race key freeing vs. STA destruction
by making sure that sta_info_destroy() is always called under
RTNL and frees the key.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: remove STA infos last_ack stuff

2008-02-29T20:42:02+00:00

These things aren't used and the only possible use is within
rate control algorithms, however those can, if they need it,
keep track of it in their private data. last_ack_ms isn't
even updated so completely useless.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: fix debugfs_sta print_mac() warning

2008-02-29T20:41:38+00:00

When print_mac() was marked as __pure to avoid emitting a function
call in pr_debug() scenarios, a warning in this code surfaced since
it relies on the fact that the buffer is modified and doesn't use
the return value. This patch makes it use the return value instead.

Signed-off-by: Johannes Berg 
Reported-by: Harvey Harrison 
Signed-off-by: John W. Linville

mac80211: remove sta TIM flag, fix expiry TIM handling

2008-02-29T20:37:26+00:00

The TIM flag that is kept in each station's info is completely
useless, there's no code (aside from the debugfs display code)
checking it, hence it can be removed. While doing that, I noticed
that the TIM handling is broken when buffered frames expire, so
fix that.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: remove port control enable switch, clean up sta flags

2008-02-29T20:19:33+00:00

This patch removes the 802.1X port acess control enable flag
since it is not required. Instead, set the authorized flag for
each station that we normally communicate with (WDS peers, IBSS
peers and APs we're associated to) and require hostapd to set
the authorized flag for all stations when port control is not
enabled.

Also, since I was working in that area, this documents station
flags and removes the unused "permanent" one.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

cfg80211 API for channels/bitrates, mac80211 and driver conversion

2008-02-29T20:19:32+00:00

This patch creates new cfg80211 wiphy API for channel and bitrate
registration and converts mac80211 and drivers to the new API. The
old mac80211 API is completely ripped out. All drivers (except ath5k)
are updated to the new API, in many cases I expect that optimisations
can be done.

Along with the regulatory code I've also ripped out the
IEEE80211_HW_DEFAULT_REG_DOMAIN_CONFIGURED flag, I believe it to be
unnecessary if the hardware simply gives us whatever channels it wants
to support and we then enable/disable them as required, which is pretty
much required for travelling.

Additionally, the patch adds proper "basic" rate handling for STA
mode interface, AP mode interface will have to have new API added
to allow userspace to set the basic rate set, currently it'll be
empty... However, the basic rate handling will need to be moved to
the BSS conf stuff.

I do expect there to be bugs in this, especially wrt. transmit
power handling where I'm basically clueless about how it should work.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville