linux.git/net/llc, branch v2.6.17

[LLC]: Use pskb_trim_rcsum() in llc_fixup_skb().

2006-04-19T22:37:13+00:00

Kernel Bugzilla #6409

If we use plain skb_trim(), that's wrong, because if
the SKB is cloned, and it can be because we unshared
it in the caller, we have to allow reallocation.  The
pskb_trim*() family of routines is therefore the most
appropriate here.

Signed-off-by: David S. Miller

[LLC]: llc_mac_hdr_init const arguments

2006-03-21T06:59:36+00:00

Cleanup of LLC.  llc_mac_hdr_init can take constant arguments,
and it is defined twice once in llc_output.h that is otherwise unused.

Signed-off-by: Stephen Hemminger 
Acked-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[LLC]: Fix sap refcounting

2006-03-21T05:28:11+00:00

Thanks to Leslie Harlley Watter  for reporting the
problem an testing this patch.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[LLC]: Replace inline with inline

2006-03-21T05:27:43+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[LLC]: Fix struct proto .name

2006-03-21T05:27:23+00:00

Cut'n'paste error from ddp_proto.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[NET]: Add a dev_ioctl() fallback to sock_ioctl()

2006-01-03T22:18:33+00:00

Currently all network protocols need to call dev_ioctl as the default
fallback in their ioctl implementations.  This patch adds a fallback
to dev_ioctl to sock_ioctl if the protocol returned -ENOIOCTLCMD.
This way all the procotol ioctl handlers can be simplified and we don't
need to export dev_ioctl.

Signed-off-by: Christoph Hellwig 
Signed-off-by: David S. Miller

[NET]: move struct proto_ops to const

2006-01-03T21:11:15+00:00

I noticed that some of 'struct proto_ops' used in the kernel may share
a cache line used by locks or other heavily modified data. (default
linker alignement is 32 bytes, and L1_CACHE_LINE is 64 or 128 at
least)

This patch makes sure a 'struct proto_ops' can be declared as const,
so that all cpus can share all parts of it without false sharing.

This is not mandatory : a driver can still use a read/write structure
if it needs to (and eventually a __read_mostly)

I made a global stubstitute to change all existing occurences to make
them const.

This should reduce the possibility of false sharing on SMP, and
speedup some socket system calls.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

[NET]: Avoid atomic xchg() for non-error case

2006-01-03T21:10:44+00:00

It also looks like there were 2 places where the test on sk_err was
missing from the event wait logic (in sk_stream_wait_connect and
sk_stream_wait_memory), while the rest of the sock_error() users look
to be doing the right thing.  This version of the patch fixes those,
and cleans up a few places that were testing ->sk_err directly.

Signed-off-by: Benjamin LaHaise 
Signed-off-by: David S. Miller

[LLC]: Fix compiler warnings introduced by TX window scaling changes.

2005-11-17T23:17:42+00:00

Noticed by Olaf Hering.

The comparisons want a u8 here (the data type on the left-hand branch
is a u8 structure member, and the constant on the right-hand branch is
"~((u8) 128)"), but C turns it into an integer so we get:

net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value':
net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited range of data type
net/llc/llc_c_ac.c:999: warning: large integer implicitly truncated to unsigned type

Fix this up by explicitly recasting the right-hand branch constant
into a "u8" once more.

Signed-off-by: David S. Miller

[LLC]: Make core block on remote busy.

2005-11-15T05:57:46+00:00

Signed-off-by: Jochen Friedrich 
Acked-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller